| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When generating a plugin without ActiveRecord (-O),
ActionCable wasn't include, which causes problems with the
require action_cable statement in cable.js
add active_job require statement
also updated order of require statements to match with all.rb
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Didn't feel we were clear enough about our motivation for placing Rails first
and why we needed to call `load_plugins`.
|
| | | |
| | | |
| | | |
| | | | |
The useless explicit self calls were driving me nuts.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When calling `load_plugins` minitest would fill out its extensions, then
we'd tackle ourselves on as the last plugin. Because minitest loads plugins
in order we will ultimately have the last say on what reporters will be used.
Invert that strategy by putting ourselves first and give other plugins plenty
of leeway to override our default reporter setup.
Fixes #24179.
|
|\ \ \ \
| | | | |
| | | | | |
Use || instead of `or` in bin/(update|setup) tpl as preferred by rails code convention
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix WebSocket already open log message typo
|
| |/ / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix typo for redirect_back (docs)
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
indetical -> identical
[skip ci]
|
|\ \ \ \
| | | | |
| | | | | |
Fixed abrupt start of sentence in changelog [ci skip]
|
|/ / / /
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[ci skip]
Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft.
This is a follow up to c94045d and contains changes made since the
release of beta1.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[ci skip]
This updates the 5.0 release notes guide to reflect changes that
happened after beta1 has been released.
I'll sync the other changelogs later today but I'll push this batch to
prevent against cumbersome merge conflicts.
|
|\ \ \ \
| | | | |
| | | | | |
Require enumerable module when using #sum
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
In https://github.com/rails/rails/commit/dfa48f200cbc5c1ca18457a8cde14642e12af5,
a call to `#sum` was added. For that to always work, we need to require the
core_ext/enumerable module.
|
|\ \ \ \
| | | | |
| | | | | |
update Active Job default adapter [ci skip]
|
| | |/ /
| |/| |
| | | |
| | | | |
Follow up to 625baa69d14881ac49ba2e5c7d9cac4b222d7022
|
|\ \ \ \
| | | | |
| | | | | |
Cable: add isolated tests and FAYE=1 test runs
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
changed default value of `caching` option to `nil`
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The default is that's false, caching even if you do not specify the caching option is determined not to use,
and `tmp/caching-dev.txt` will be deleted.
If it is this, regardless of whether or not there is `tmp/caching-dev.txt`, be sure to order would be necessary to specify the caching option,
I think that in than good to so as not to do anything by default.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Comment out config.file_watcher during Rails upgrade process
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[related #24243]
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
switched layout :mailer to a string so that mail layout can be properly sent
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
found and mail can be delivered properly
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | |
| | | | | | | |
Fix request.reset_session for API controllers
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Due to that `ActionDispatch::Flash` (the flash API's middleware) is not
included for API controllers, the `request.reset_session` method, which
relies on there being a `flash=` method which is in fact defined by the
middleware, was previously breaking. Similarly to how
add46482a540b33184f3011c5c307f4b8e90c9cc created a method to be
overridden by the flash middleware in order to ensure non-breakage, this
is how flashes are now reset.
Fixes #24222
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
remove Rails 4 text from asset pipeline guide
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
RochesterinNYC/better-error-message-for-includes-relations-missing
Improve error message for missing relations for includes and eager_load
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
relations
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Added more tests for reserved hash keys of ActiveJob::Arguments.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Added tests for checking all reserved hash keys of ActiveJob::Arguments.
- Moved unrelated code from the test to the correct place, i.e. newly created
test.
|
|\ \ \ \ \ \ \
| |_|_|_|/ / /
|/| | | | | | |
use rails 5 favicon.ico for rails guides [ci skip]
|
| | |_|/ / /
| |/| | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Document and Match the Rails logger interface
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The logger interface to get all Rails features is not obvious. This change adds documentation on how to assign a logger that will use all Rails features.
We are also matching the stdout logging interface to the default logger in bootstrap https://github.com/rails/rails/blob/f5a5988352b165143f0f9d622707c351c1470882/railties/lib/rails/application/bootstrap.rb#L42-L45.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Creates development and test databases in db:migrate task
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts a334425caff9b2140d5e99fcfc2eb8c4ab10bdfa.
The main reason is that now the workflow is inconsistent when using
spring.
When using spring `RAILS_ENV` is always set, so only one database is
created.
This means that in development `bin/rake db:create` and `bundle exec
rake db:create` have different results.
It also breaks the `bin/setup` script since `bin/rake db:setup
db:test:prepare` will fail.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
fix a comment in atom_feed_helper.rb
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improve ActiveSupport::Dependencies code understanding
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In a previous patch, all log-related stuff was removed. However,
some logs are still useful to understand the code. Therefore, in
this patch, I put those log messages back as comments.
[ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This configuration improves git diff, git log -p -W, git grep -p, ...,
and allows to inspect the history of a method with a command like
git log -L:new_constants_in:activesupport/lib/active_support/dependencies.rb
Let me also appeal to authority by saying it is present in the Ruby
repository as well
https://github.com/ruby/ruby/blob/trunk/.gitattributes
:)
|