| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| |
| | |
y-yagi/deprecate_halt_callback_chains_on_return_false
deprecate `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
`halt_and_display_warning_on_return_false`
`halt_and_display_warning_on_return_false` is not a public API and
application is using `halt_callback_chains_on_return_false`.
https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults.rb.tt#L29
https://github.com/rails/rails/blob/5-0-stable/activesupport/lib/active_support.rb#L86..L88
Therefore, deprecate messages should be issued for
`halt_callback_chains_on_return_false` instead of
`halt_and_display_warning_on_return_false`.
|
|\
| |
| | |
remove link to edgeapi [ci skip]
|
|/ |
|
|\
| |
| | |
Improve linking inside guides
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
To ease reading the "Active Support Core Extensions" guide, let's
automatically link references to Ruby files.
It's also possible to reference other components' files in the even
though it's not used in the guides at the moment.
[Petr Skocik & Robin Dupret]
|
| |
| |
| |
| |
| |
| |
| | |
To make sure that the user won't look at a feature that doesn't
already exist if they are looking at a previous version of the guides,
let's automatically inject the Rails version the guides have been
generated against.
|
| | |
|
|\ \
| | |
| | |
| | | |
Deprecate locking of dirty records
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
kamipo/remove_deprecated_passing_string_to_define_callback
Remove deprecated passing string to define callback
|
| | |
| | |
| | |
| | | |
`set_callback` and `skip_callback`
|
| | |
| | |
| | |
| | | |
And raise `ArgumentError` when passing string to define callback.
|
|\ \ \
| | | |
| | | | |
Revert "Remove useless `column_alias` in `subquery_for_count`"
|
|/ / /
| | |
| | |
| | | |
This reverts commit 28977f1fa3d7b15c1608174a165e60b71ddf3995.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/pk_and_ref_columns_should_be_identical_type
`primary_key` and `references` columns should be identical type
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Follow up to #26266.
The default type of `primary_key` and `references` were changed to
`bigint` since #26266. But legacy migration and sqlite3 adapter should
keep its previous behavior.
|
|\ \ \ \
| | | | |
| | | | | |
Move some ActionCable logs to debug level
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
kamipo/decouple_building_arel_ast_for_uniqueness_validator
Decouple the building Arel ASTs for uniqueness validator
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
These methods are obviously for internal use.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently uniqueness validator is coupled with building Arel ASTs.
This commit extracts `WhereClauseFactory#build_for_case_sensitive` for
decouple the building Arel ASTs.
|
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If select clause is specified and last column has a column alias,
additional column alias causes a statement invalid.
Add test coverage for counting a single column with NULL values.
Fixes #27676, #27682, and #27705.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Restore the behaviour of the compatibility layer for integer-like PKs
* kamipo/fix_mysql_pk_dumping_correctly:
Restore custom primary key tests lost at #26266
Restore the behaviour of the compatibility layer for integer-like PKs
Correctly dump integer-like primary key with default nil
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Some custom primary key tests (added at #17631, #17696, #18220, #18228)
were lost at #26266. Restore the tests to improve test coverage.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The PR #27384 changed migration compatibility behaviour.
```ruby
class CreateMasterData < ActiveRecord::Migration[5.0]
def change
create_table :master_data, id: :integer do |t|
t.string :name
end
end
end
```
Previously this migration created non-autoincremental primary key
expected. But after the PR, the primary key changed to autoincremental,
it is unexpected.
This change restores the behaviour of the compatibility layer.
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The PR #27384 changed integer-like primary key to be autoincrement
unless an explicit default. This means that integer-like primary key is
restored as autoincrement unless dumping the default nil explicitly.
We should dump integer-like primary key with default nil correctly.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Deprecate `ColumnDumper#migration_keys`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`ColumnDumper#migration_keys` was extracted to customize keys for
standardized column arguments widths. But the feature was removed in
df84e98. The internal method is no longer used for that.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Remove superfluous `MySQL::Column` tests
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since text default treated as an empty string in non-strict mode has
been removed in #26154, `MySQL::Column` behaves like any other column.
Also, The difference between strict and non-strict mode is covered by
`test_mysql_not_null_defaults_strict` and `test_mysql_not_null_defaults_non_strict`.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove `ActiveModel::TestCase` from lib
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`ActiveModel::TestCase` is used only for the test of Active Model.
Also, it is a private API and can not be used in applications.
Therefore, it is not necessary to include it in lib.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Correct spelling
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
```
go get -u github.com/client9/misspell/cmd/misspell
misspell -w -error -source=text .
```
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Add test for DateTime#blank?
|
|/ / / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Indicate action that failed in YamlColumn
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Add `:args` to `process.action_mailer` event.
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Collect all file patterns when running multiple rake test tasks
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Replaces the rake_patterns instance variable with simple require, as
`autorun` will run tests from all eagerly required test files.
Fixes #27801
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Docs: Correction: Module::DelegationError
|