aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix ruby 1.8 compat. const_defined? only takes a second arg on 1.9.Jon Leighton2011-11-291-3/+4
|
* Deprecated `define_attr_method` in `ActiveModel::AttributeMethods`Jon Leighton2011-11-296-66/+60
| | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated.
* Deprecate set_locking_column in favour of self.locking_column=Jon Leighton2011-11-294-10/+56
|
* Deprecate set_primary_key in favour of self.primary_key=Jon Leighton2011-11-2918-43/+71
|
* Make sure the original_foo accessor still works (but deprecated) if we are ↵Jon Leighton2011-11-292-13/+86
| | | | using self.foo=
* extract methodJon Leighton2011-11-291-49/+25
|
* Deprecate set_sequence_name in favour of self.sequence_name=Jon Leighton2011-11-295-16/+38
|
* Add tests for set_sequence_name etcJon Leighton2011-11-292-1/+23
|
* Deprecate set_inheritance_column in favour of self.inheritance_column=Jon Leighton2011-11-295-24/+48
|
* Deprecate set_table_name in favour of self.table_name= or defining your own ↵Jon Leighton2011-11-2921-72/+138
| | | | method.
* respond_to? information of AR is not the responsibility of the specAaron Patterson2011-11-292-8/+10
| | | | resolver.
* Merge pull request #3636 from joshsusser/masterJon Leighton2011-11-2914-23/+112
|\ | | | | association methods are now generated in modules
| * don't change class definition in test caseJosh Susser2011-11-292-6/+4
| |
| * avoid warningsJosh Susser2011-11-276-15/+15
| | | | | | | | | | | | | | This change uses Module.redefine_method as defined in ActiveSupport. Making Module.define_method public would be as clean in the code, and would also emit warnings when redefining an association. That is pretty messy given current tests, so I'm leaving it for someone else to decide what approach is better.
| * changelog & docs for GeneratedFeatureMethodsJosh Susser2011-11-272-0/+26
| |
| * use GeneratedFeatureMethods module for associationsJosh Susser2011-11-277-15/+57
| |
| * add test for super-ing to association methodsJosh Susser2011-11-151-2/+12
| |
| * association methods are now generated in modulesJosh Susser2011-11-159-30/+43
| | | | | | | | | | | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods.
* | Fix resolver_test.rb on travis (postgresql isn't setup, so it can't load the ↵Jon Leighton2011-11-291-6/+6
| | | | | | | | connection adapter)
* | Fix schema_cache_test.rb for sqlite3_memJon Leighton2011-11-291-6/+0
| |
* | Merge pull request #3797 from HeeL/testVijay Dev2011-11-291-1/+8
|\ \ | | | | | | splited a long line to shorter ones
| * | splited a long line to shorter onesSergey Parizhskiy2011-11-291-1/+8
|/ /
* | Merge pull request #3790 from masterkain/patch-1Vijay Dev2011-11-291-1/+1
|\ \ | | | | | | Fix typo in AS::TaggedLogging
| * | Fix typo in AS::TaggedLoggingClaudio Poli2011-11-291-1/+1
| | |
* | | Merge pull request #3793 from marcandre/asset_hostJosé Valim2011-11-282-2/+10
|\ \ \ | |/ / |/| | Handle correctly optional parameters for callable asset_host.
| * | Handle correctly optional parameters for callable asset_host.Marc-Andre Lafortune2011-11-292-2/+10
|/ /
* | remove unused instance variableAaron Patterson2011-11-281-1/+0
| |
* | just check in all connectionsAaron Patterson2011-11-281-6/+2
| |
* | remove useless class_evalAaron Patterson2011-11-281-2/+0
| |
* | Move connection resoluion logic to it's own testable class.Aaron Patterson2011-11-283-92/+115
| |
* | clean up string => hash conversion for connection poolAaron Patterson2011-11-281-19/+17
| |
* | pools are 1:1 with spec now rather than 1:1 with classAaron Patterson2011-11-284-7/+8
| |
* | break establish_connection to smaller methodsAaron Patterson2011-11-282-33/+43
| |
* | added information about callbacks created by autosave association (#3639)Jakub Kuźma2011-11-281-4/+16
| |
* | Merge pull request #3768 from janv/masterAaron Patterson2011-11-282-1/+12
|\ \ | | | | | | Test and fix for Issue 3450
| * | Test case and fix for rails/rails#3450Jan Varwig2011-11-272-1/+12
| | | | | | | | | | | | Asssigning a parent id to a belongs_to association actually updates the object that is validated when the association has :validates => true
* | | Merge pull request #3785 from lest/backtrace-cleaner-envJosé Valim2011-11-284-18/+27
|\ \ \ | | | | | | | | Put backtrace_cleaner to env
| * | | put backtrace_cleaner to envlest2011-11-284-18/+27
|/ / /
* | | Merge pull request #3783 from HeeL/masterVijay Dev2011-11-281-1/+1
|\ \ \ | | | | | | | | fixed a typo in a travis message
| * | | fixed a typo in a message when there is no failuresin a buildSergey Parizhskiy2011-11-281-1/+1
|/ / /
* | | Merge pull request #3278 from arunagw/rails_rake_task_warningJosé Valim2011-11-281-0/+1
|\ \ \ | | | | | | | | Global variable `$rails_rake_task' not initialized Warning removed
| * | | global variable `$rails_rake_task' not initialized Warning removedArun Agrawal2011-11-281-0/+1
|/ / /
* | | Merge pull request #3657 from arunagw/mysql2_bump_masterJosé Valim2011-11-282-2/+2
|\ \ \ | | | | | | | | Bump Mysql2!
| * | | Bump Mysql2!Arun Agrawal2011-11-222-2/+2
| | | |
* | | | Revert "use any? to check for size"Vijay Dev2011-11-281-1/+1
| | | | | | | | | | | | | | | | This reverts commit c4af5f00f602b9e1c3166872902265836daf321b.
* | | | Revert "Use any instead of length"José Valim2011-11-281-1/+1
| | | | | | | | | | | | | | | | This reverts commit 1756629835d39f60ef4c96aff81ac503c71b98b7.
* | | | Revert "Used any? instead of length call"Xavier Noria2011-11-282-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reason: This is slower, and any? is not equivalent in the general case. See discussion in https://github.com/rails/rails/pull/3779 This reverts commit 20cbf8eddc3844126d20f1218f068889d17b0dcf.
* | | | Merge pull request #3776 from nashby/add-namespace-to-formJosé Valim2011-11-273-2/+95
|\ \ \ \ | | | | | | | | | | add namespace options to form_for
| * | | | update CHANGELOGVasiliy Ermolovich2011-11-281-0/+10
| | | | |
| * | | | add namespace options to form_forVasiliy Ermolovich2011-11-272-2/+85
| | | | | | | | | | | | | | | | | | | | | | | | | You can provide a namespace for your form to ensure uniqueness of id attributes on form elements. The namespace attribute will be prefixed with underscore on the generate HTML id