| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \
| |/ / / /
|/| | | | |
Respect 'SchemaDumper.ignore_tables' in databases structure dump
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Use NOT IN in SQL query
* Quote table names propertly
* Use array form of command invocation
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
When using `sql` as the schema format, or even just doing `rake
db:structure:dump`, it would be good to respect the list of ignored
tables that has been configured.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Message encryptor auth tag check
Fixes MessageEncryptor when used in AEAD mode. Specifically, we need to check if the `auth_tag` is nil. This may arise when an AEAD encryptor is used to decrypt a ciphertext generated from a different mode, such as CBC-HMAC. Basically, the number of double dashes will differ and `auth_tag` may be nil in this case.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When MessageEncryptor tries to +decrypt_and_verify+ ciphertexts
generated in a different mode (such CBC-HMAC), the +auth_tag+ may be
+nil+ and must explicitly check for it.
See the discussion here:
https://github.com/rails/rails/pull/28132#discussion_r116388462
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Don't cache locally if unless_exist was passed
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Some cache backends support the `unless_exist` option, which tells them
not to overwrite an existing entry. The local cache currently always
stores the new value, even though the backend may have rejected it.
Since we can't tell which value will end up in the backend cache, we
should delete the key from the local cache, so that the next read for
that key will go to the backend and pick up the correct value.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously this implied that system tests provided other non-headless
drivers when Selenium is the only driver that uses `:using`,
`:screen_size` or `:options` arguments.
This change clarifies that Selenium is the only non-headless driver.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It's more likely you'll generate a test for testing users than a users
creates test. This is a better example of a real world test.
Additionally the users create view is unlikely to have the text
"UserCreates" since that is likely generated as well. This is now an
example of visiting the users index.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It wasn't clear that system tests don't run with the rest of the test
suite and are part of a separate command.
This documents the `test:system` command as well as update the Rails
runner help documentation to make it clearer that system tests are run
via their own command by default.
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Allow irb options to be passed from `rails console` command
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #28988
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Mailer fixtures in Testing guide.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Update guide to clarify that mailer fixtures are not created when
using the mailer generator.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
eileencodes/force-encoding-to-original-string-encoding
Maintain original encoding from path
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When the path info is read from the socket it's encoded as ASCII 8BIT.
The unescape method changes the encoding to UTF8 but it should maintain
the encoding of the string that's passed in.
This causes parameters to be force encoded to UTF8 when we don't
actually know what the encoding of the parameter should be.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
meinac/fix_ambigious_exception_message_of_select_query_method
Fix ambigious error message of select query method [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
rake -T should load development env by default, not test
|
| | |_|_|_|/
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Handle loops in the cause chain in Rescuable#rescue_with_handler
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Pass block in ActionController::Parameters#delete
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In order to fully support the same interface as `Hash#delete`, we need
to pass the block through to the underlying method, not just the key.
This used to work correctly, but it regressed when
`ActionController::Parameters` stopped inheriting from `Hash` in 5.0.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Don't eager loading if unneeded for `FinderMethods#exists?`
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes #29025.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Because we don't need to load tasks for DBs that we don't use for the current app.
Also, these Tasks classes load AR::Base in their class level, and so immediately kick :active_record on_load hooks.
This used to happen when we were loading tasks, not when we run a task.
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix a typo in guide [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | |
| | | | | |
| | | | | | |
y-yagi/allow_to_receive_arbitrary_arguments_in_aggregated_results
Allow to receive arbitrary arguments in `aggregated_results`
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | | |
Argument was added to `aggregated_results` in minitest 5.10.2.
Ref: https://github.com/seattlerb/minitest/commit/c6ba2afd90473b76d289562edd24f7d7ca8484f9
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Allow capybara minor releases
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
Capybara 2.14.0 was released. Loosen the tight constraint in the
generated Gemfile, so that Rails applications can take advantage of the
new version
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Correct Autoloading and STI guide (issue #26994)
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Fix link to `assert_nothing_raised` doc [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
The `assert_nothing_raised` was moved to `ActiveSupport::Testing::Assertions` in 3cece0b6574c496605df055a2ebf77177f5b6e7f.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Should escape meta characters in regexp
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix `warning: ambiguous first argument`
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
```
% ARCONN=sqlite3 be ruby -w -Itest test/cases/quoting_test.rb
test/cases/quoting_test.rb:92: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/cases/quoting_test.rb:96: warning: ambiguous first argument; put parentheses or a space even after `/' operator
Using sqlite3
Run options: --seed 9495
.....................................
Finished in 0.046403s, 797.3622 runs/s, 1120.6172 assertions/s.
37 runs, 52 assertions, 0 failures, 0 errors, 0 skips
```
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Clarify deprecation message for #quoted_id
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In this case, it's the method definition that's more at fault, rather
than the current caller.
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Remove unused `DelegationTest#call_method`
|