| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |/ / / / |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This CHANGELOG.md is a continuation of the 5-1-stable one, there
shouldn't be any duplicate entries.
[ci skip]
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
Add default_scope note to ActiveRecord guide
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds note to explain unexpected behavior described in issue #28561.
Developers may be surprised that the internal representation of similar
query conditions in Hash and Array formats in default_scope will yield
different results for model initialization.
Link: https://github.com/rails/rails/issues/28561
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Fix a failed AR test when running with OracleAdapter
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
CI against Ruby 2.3.4
|
| | |/ / / /
| | | | |
| | | | |
| | | | | |
https://www.ruby-lang.org/en/news/2017/03/30/ruby-2-3-4-released/
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
y-yagi/add_missing_backtick_to_deprecation_message
Add missing backtick to deprecation message
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Fix example usage of ActiveRecord::Base.establish_connection [ci skip]
|
| | | | | |
| | | | |
| | | | | |
`ActiveRecord::Base.establish_connection` accepts a single symbol argument to specify a named connection; a single string argument appears to be interpreted as a connection URI
|
| | | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Restore rails-ujs.js UMD module support
|
| | | | | | | |
|
| | |/ / / / |
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
Move HashWithIndifferentAccess tests to separate file
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Do not include default response headers for AC::Metal
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In Rails 4.2, `ActionController::Metal` controllers did not include the
default headers from `ActionDispatch::Response`. However, through e16afe6, and a
general shift towards having `ActionController::Metal` objects contain
`ActionDispatch::Response` objects (instead of just returning an array
of status, headers, and body), this behavior was lost. This PR helps to
restore the original behavior by having `ActionController::Metal`
controllers generate Response objects without the default headers, while
`ActionController::Base` now overrides the factory method to make sure
its version does have the default headers.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Update comment in sanitizer helper test [skip ci]
|
| | | |/ / / /
| |/| | | |
| | | | | | |
The previously referenced file no longer appears to exist in the project.
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Raise when using a bad symlink
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
There was a case where a dev made a symlink that worked on some machines and not on others. The issue manifested itself on a machine with `RAILS_ENV=staging` as the had their `config/environments/staging.rb` symlinked to another config file. The behavior was very hard to track down.
Current behavior: If you use a bad symlink in a file, you get no warnings or failures or anything. If you have a bad symlink it just ignores the file as if it didn't exist (`File.exist?` returns false for a bad symlink).
Patch behavior: With this patch when a file is not present we check if a symlink exists. If it does, that indicates there is a bad symlink and we should raise
```
File "config/environments/staging.rb" is a symlink that does not point to a valid file
```
|
| |\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Add an alias for reverse_merge to with_defaults
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In the context of controller parameters, reverse_merge is commonly used
to provide defaults for user input. Having an alias to reverse_merge
called with_defaults feels more idiomatic for Rails.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add comma and change verb.
[ci skip]
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
add hint on after_action filters
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Adds a hint that ``after_action``-callbacks are not executed when an
exception was raised in the rest of the request cycle. The
``before_action`` section mentions "If there are additional filters
scheduled to run after that filter, they are also cancelled." but this
is IMO not sufficient.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
htanata/ar_relation_inspect_should_not_load_all_records
Load only needed records on ActiveRecord::Relation#inspect
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Instead of loading all records and returning only a subset of those,
just load the records as needed.
Fixes #25537.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix the example code for `Rails.groups` [ci skip]
|
| | | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
`Rails.groups` contains `Rails.env` that is inspected as String.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
CI against Ruby 2.2.7
|
| | |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
https://www.ruby-lang.org/en/news/2017/03/28/ruby-2-2-7-released/
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
FinderMethods#fourty_two docs cite proper source
|
| | |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
silly method gets a silly doc fix,
or I'm missing an even sillier joke and I'm about to get schooled.
BUT I'm pretty sure this is some serious Beaudrillard simulacrum, though.
I'm just doing my part to spread the gospel of Douglas Adams.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix link to rails-ujs
|
| | |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
https://github.com/rails/rails-ujs is merged into actionview in favor of https://github.com/rails/rails/pull/28098.
[skip ci]
|
| |/ / / / / /
| | | | | |
| | | | | | |
[ci skip]
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix `primary_keys` across multiple schemas
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes #28470.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This CHANGELOG.md is a continuation of the 5-1-stable one, there
shouldn't be any duplicate entries.
[ci skip]
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Make `driven_by` overridable
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Sometimes we want to use rack_test partially instead of selenium for test speed:
```ruby
class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
driven_by :selenium, using: :chrome, screen_size: [1400, 1400], options: {url: "http://chrome:4444/wd/hub"}
end
class WithJavaScriptTest < ApplicationSystemTestCase
end
class WithoutJavaScriptTest < ApplicationSystemTestCase
driven_by :rack_test
end
```
In the abobe case, `WithoutJavaScriptTest` uses selenium because
`SystemTestCase` calls superclass' driver on `#initialize` (`self.class.superclass.driver.use`).
Using `class_attribute` can handle inherited `driven_by`.
|
| |\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Remove unnecessary `javascript` option check
|
| |/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
Follow up to #28546
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Make internal methods to private
|
