Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Make valid_type? public | Sam Ruby | 2013-02-14 | 4 | -17/+12 | |
|/ / / | ||||||
* | | | Merge pull request #9254 from warnickr/9253_avoid_bigdecimal_performance_issue | Carlos Antonio da Silva | 2013-02-13 | 1 | -4/+5 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before writing a numeric attribute value, ActiveRecord does an implicit conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false. This is known to be very slow in Ruby 1.9.3 (see http://www.ruby-forum.com/topic/4409452 and https://bugs.ruby-lang.org/issues/7645#change-35188). The Ruby core team has implemented a fix for this issue that will be included in Ruby 2, but they appear to have no intention of back-porting this fix to Ruby 1.9.3. In my case, the performance impact of this issue was enormous (200% - 300% performance hit) for some of the pages in my application. See c75b5a88a82c79fdf95dfea4d72bf3c5a829930e applied to 3-2-stable branch for more reasoning and a benchmark. | |||||
| * | | | 9253: Before writing a numeric attribute value, ActiveRecord does an implicit | Ryan Warnick | 2013-02-13 | 1 | -4/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false. This is known to be very slow in Ruby 1.9.3. | |||||
* | | | | Merge pull request #9115 from bensie/issue_5802 | Steve Klabnik | 2013-02-13 | 3 | -1/+36 | |
|\ \ \ \ | | | | | | | | | | | Don't call after_commit when creating through an association and save fails, fixes #5802 | |||||
| * | | | | Don't call after_commit when creating through an association and save fails, ↵ | James Miller | 2013-02-13 | 3 | -1/+36 | |
|/ / / / | | | | | | | | | | | | | fixes #5802 | |||||
* / / / | Avoid to_sym calls | Santiago Pastorino | 2013-02-13 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Merge pull request #9204 from ranjaykrishna/col-prob | Aaron Patterson | 2013-02-12 | 8 | -1/+43 | |
|\ \ \ | | | | | | | | | schema dumper tests now conducted by ActiveRecord::Base.Connection | |||||
| * | | | checking in the abstractions for valid type checking: | Ranjay Krishna | 2013-02-12 | 8 | -1/+43 | |
| | | | | ||||||
* | | | | Merge pull request #9206 from ranjaykrishna/use_define_method | Carlos Antonio da Silva | 2013-02-12 | 1 | -18/+13 | |
|\ \ \ \ | | | | | | | | | | | Use define method instead of class_eval | |||||
| * | | | | reverted back our changes and added in the new define_method | Ranjay Krishna | 2013-02-12 | 1 | -18/+13 | |
| |/ / / | ||||||
* | | | | test for regression from a712e08ebe21f6d8653a0e6602df2e0f5d40d9ca | Aaron Patterson | 2013-02-11 | 1 | -0/+6 | |
| | | | | ||||||
* | | | | Merge pull request #9250 from senny/8583_fix_engines_documentation_example_code | Steve Klabnik | 2013-02-11 | 1 | -4/+12 | |
|\ \ \ \ | | | | | | | | | | | fix example code in engines guide | |||||
| * | | | | fix the example code in the engines guide. closes #8583. | Yves Senn | 2013-02-11 | 1 | -0/+8 | |
| | | | | | ||||||
| * | | | | remove trailing whitespace from engines guide | Yves Senn | 2013-02-11 | 1 | -4/+4 | |
| | | | | | ||||||
* | | | | | Merge pull request #9247 from lest/store-module | Carlos Antonio da Silva | 2013-02-11 | 4 | -12/+54 | |
|\ \ \ \ \ | |/ / / / |/| | | | | define Active Record Store accessors in a module | |||||
| * | | | | define Active Record Store accessors in a module | Sergey Nartimov | 2013-02-11 | 4 | -12/+54 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow store accessors to be overrided like other attribute methods, e.g.: class User < ActiveRecord::Base store :settings, accessors: [ :color, :homepage ], coder: JSON def color super || 'red' end end | |||||
* | | | | | Improve changelog entry from #9221 [ci skip] | Carlos Antonio da Silva | 2013-02-11 | 2 | -18/+16 | |
| | | | | | ||||||
* | | | | | Add changelog entry for #9177 [ci skip] | Carlos Antonio da Silva | 2013-02-11 | 1 | -4/+11 | |
| | | | | | | | | | | | | | | | | | | | | Add test:all and test:all:db rake tests to speed up full test runs. | |||||
* | | | | | Merge pull request #9221 from thenickcox/image_alt_attribute | Carlos Antonio da Silva | 2013-02-11 | 3 | -4/+40 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Improve img alt attribute for screen readers | |||||
| * | | | | Improve img alt attribute for screen readers | thenickcox | 2013-02-09 | 3 | -4/+40 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method | |||||
* | | | | | fixing bit string test | Aaron Patterson | 2013-02-10 | 1 | -3/+3 | |
| | | | | | ||||||
* | | | | | Merge pull request #9245 from vasconcelloslf/fix_guide_typo | Steve Klabnik | 2013-02-10 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | fix a typo on the engine guide | |||||
| * | | | | | fix a typo on the engine guide | Luis Vasconcellos | 2013-02-11 | 1 | -1/+1 | |
|/ / / / / | ||||||
* | | | | | Merge pull request #9240 from tricknotes/supress-warning | Guillermo Iguaran | 2013-02-10 | 1 | -0/+2 | |
|\ \ \ \ \ | | | | | | | | | | | | | Supress warning about method redifinition | |||||
| * | | | | | Supress warning about method redifinition | Ryunosuke SATO | 2013-02-11 | 1 | -0/+2 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In i18n gem, the following methods are defined. - `Hash#except` - `Hash#slice` But if there are defined already, i18n skips these definitions. So these definition by `active_support` are required before `require 'i18n'`. | |||||
* | | | | | Merge pull request #9238 from norman/unicode_62 | Carlos Antonio da Silva | 2013-02-10 | 2 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | Update to latest Unicode data. | |||||
| * | | | | | Update to latest Unicode data. | Norman Clarke | 2013-02-10 | 2 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Release notes at: http://www.unicode.org/versions/Unicode6.2.0/ | |||||
* | | | | | | Merge pull request #8643 from tricknotes/remove-method-redefined-warning | Andrew White | 2013-02-10 | 1 | -0/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove method redefined warning | |||||
| * | | | | | | Remove method redefined warning | Ryunosuke SATO | 2013-02-11 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In `i18n` gem, the method definition of `Hash#deep_merge!` is skipped when it is already defined. - warning: method redefined; discarding old deep_merge! | |||||
* | | | | | | | Merge pull request #7730 from beyond/gzip | Xavier Noria | 2013-02-10 | 3 | -2/+25 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | added compress options for gzip | |||||
| * | | | | | | | added compress options for gzip | Beyond | 2013-02-10 | 3 | -2/+25 | |
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | added test for compress options of gzip update changelog | |||||
* | | | | | | | Prefer Ruby 2.0; require 1.9.3+ | Jeremy Kemper | 2013-02-09 | 4 | -9/+9 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #9234 from senny/9231_no_numbers_in_route_namespaces_allowed | Carlos Antonio da Silva | 2013-02-09 | 2 | -1/+13 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | The `:controller` option for routes can contain numbers. closes #9231. | |||||
| * | | | | | | | the `:controller` option for routes can contain numbers. closes #9231. | Yves Senn | 2013-02-09 | 2 | -1/+13 | |
| | | | | | | | | ||||||
* | | | | | | | | Merge pull request #9233 from rahul100885/master | Carlos Antonio da Silva | 2013-02-09 | 3 | -1/+6 | |
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | Added notice message for destroy method in scaffold | |||||
| * | | | | | | | Added notice message for destroy method in scaffold | Rahul P. Chaudhari | 2013-02-10 | 3 | -1/+6 | |
| | | | | | | | | ||||||
* | | | | | | | | Update activerecord/CHANGELOG.md | Guillermo Iguaran | 2013-02-09 | 1 | -1/+1 | |
| | | | | | | | | ||||||
* | | | | | | | | Merge pull request #9232 from robertomiranda/where-with-empty-hash | Guillermo Iguaran | 2013-02-09 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | Use IN operator like Arel for empty hash in where clause | |||||
| * | | | | | | | Use IN operator like arel for empty hash in where clause | robertomiranda | 2013-02-09 | 1 | -1/+1 | |
|/ / / / / / / | ||||||
* | | | | | | | Add missing require to AP | Carlos Antonio da Silva | 2013-02-08 | 1 | -0/+1 | |
| | | | | | | | ||||||
* | | | | | | | Reverting e170014113 (Change behaviour with empty hash in where clause) | Guillermo Iguaran | 2013-02-08 | 3 | -12/+3 | |
| | | | | | | | ||||||
* | | | | | | | We don't need a CHANGELOG entry for an issue of something that was not ↵ | Santiago Pastorino | 2013-02-08 | 1 | -5/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | released yet | |||||
* | | | | | | | Merge pull request #9196 from AndreyChernyh/fix-cookies-with-null-session | Santiago Pastorino | 2013-02-08 | 4 | -5/+49 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | |||||
| * | | | | | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | Andrey Chernih | 2013-02-08 | 4 | -5/+49 | |
| | | | | | | | | ||||||
* | | | | | | | | Bump rack dependency to 1.5.2 | Santiago Pastorino | 2013-02-08 | 1 | -1/+1 | |
| | | | | | | | | ||||||
* | | | | | | | | Reverting 16f6f25 (Change behaviour with empty array in where clause) | Guillermo Iguaran | 2013-02-08 | 6 | -14/+13 | |
|/ / / / / / / | ||||||
* | | | | | | | Improve changelog entries in AR | Carlos Antonio da Silva | 2013-02-08 | 1 | -5/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Describe better the changes related to raising errors with empty array/hash values in where clauses. [ci skip] | |||||
* | | | | | | | Merge pull request #9216 from robertomiranda/where-with-empty-array | Guillermo Iguaran | 2013-02-08 | 6 | -13/+14 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Activer Record: Change behaviour with empty array in where clause | |||||
| * | | | | | | | Change behaviour with empty array in where clause | robertomiranda | 2013-02-08 | 6 | -13/+14 | |
|/ / / / / / / | ||||||
* | | | | | | | Merge pull request #9220 from robertomiranda/where-with-empty-hash | Michael Koziarski | 2013-02-07 | 3 | -3/+11 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Active Record: Change behaviour with empty hash in where clause |