| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Bump i18n to 1.0
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Don't overwrite config/master.key even on --force
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
See https://github.com/rails/rails/pull/31957#issuecomment-364817423
The purpose of `--force` is not to have any prompt whether a file should
be kept or overwritten. In general, all existing files should be overwritten.
However, `config/master.key` is special because it is git-ignored, and
overwriting it will cause the app not to run (since there won't be a way
to decrypt the credentials).
As a result, it's probably better to keep the existing config/master.key.
|
|\ \
| | |
| | | |
Add ActiveStorage::Blob.unattached scope
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Incompatible settings are included in the settings set by `load_defaults`.
So, I think that target version should be updated by a user when becomes
available, and should not be updated with `app:update`.
|
| | |
| | |
| | |
| | |
| | |
| | | |
[ci skip]
Closes #31967
|
|\ \ \
| | | |
| | | | |
Change structure in the AS core extensions guide [ci skip]
|
|/ / / |
|
|/ / |
|
|\ \
| | |
| | | |
ActiveStorage: use full class names when including concerns to avoid collisions
|
|/ / |
|
|\ \
| | |
| | | |
Improve wording in getting started guide
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
Missing parentheses [ci skip]
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Respect --force option for config/master.key
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is similar to #30700 which ensures the `--quiet` option of `rails new`
is respected by the `MasterKeyGenerator` (missing from #30067).
Before this commit, running `rails new app --force` would still prompt the
user what to do with the conflict in `config/master.key`:
```
…
identical config/locales/en.yml
conflict config/master.key
Overwrite /Users/claudiob/Desktop/pizza/config/master.key? (enter "h" for help) [Ynaqdh]
```
After this commit, `config/master.key` is overwritten:
```
…
identical config/locales/en.yml
force config/master.key
append .gitignore
```
The newly added test generates an app and then generates it again with
`--force`. Without this commit, the test would just wait forever for user
input.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
mohsen-alizadeh/sanitize_empty_and_nil_parameters_passed_to_select
sanitize empty and nil parameters to select #31059
|
| | | | |
|
| | | | |
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Remove warning from 4 years ago [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`config/initializers/assets.rb` has been a part of Rails apps since
Rails 4.2 (30b56084). This comment is probably unnecessary by now.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Before, if the application defined after an engine this method would not
recognize the route since it was not defined insdie the engine.
|
| | | |
| | | |
| | | | |
* Add Relation#pick as short-hand for single-value plucks
|
|\ \ \ \
| | | | |
| | | | | |
Document :combine_options
|
| | | | |
| | | | |
| | | | |
| | | | | |
Turns out this is still undocumented functionality.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Use heredoc with credentials template
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
* Use heredoc with credentials template.
* Fix indentation for aws config
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Fix marshaling of models with `has_many :through` associations
|
| | |/ / /
| |/| | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
bogdanvlviv/fix-test_counter_cache_with_touch_and_lock_version
Fix `test_counter_cache_with_touch_and_lock_version` failure
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
https://travis-ci.org/rails/rails/jobs/338338927#L1043
Related to daf15f58b943d85d8fb726590ae94f77ca0a5d5f
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix grammar bug in security guide [ci skip]
|
| | |/ / /
| |/| | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Without this require, an error occurs when executing only `duration_test.rb`.
Ref: https://travis-ci.org/rails/rails/jobs/338817558#L2205-L2210
|
| | | | |
| | | | |
| | | | | |
Fixes #31917
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix `blob.service_url` for supports string type `:filename` option
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Make sure `blob.service_url` present a `ActiveStorage::Filename` type to `serivce.url`.
- Add `ActiveStorage::Filename.wrap` method.
before:
```rb
blob.service_url(filename: ActiveStorage::Filename.new("new.txt"))
blob.service_url(filename: "new.txt")
=> NoMethodError: undefined method `parameters' for "new.txt":String
params = {}
blob.service_url(filename: params[:filename])
=> NoMethodError: undefined method `parameters' for nil:NilClass
```
after:
```rb
blob.service_url(filename: "new.txt")
blob.service_url(filename: nil)
```
|
|\ \ \ \
| | | | |
| | | | | |
Fix yaml deserialization of ActiveSupport::Duration
|