aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | Don't sanitize_sql where it doesn't make sense.Emilio Tagua2009-08-191-2/+2
| |
* | Remove old method and comment.Emilio Tagua2009-08-191-14/+0
| |
* | Remove useless InnerJoinDependency, inner joins are performed throughEmilio Tagua2009-08-192-22/+5
| | | | | | | | Arel::InnerJoin.
* | Merge commit 'rails/master'Emilio Tagua2009-08-1914-109/+376
|\|
| * Added save! which raises ResourceInvalid unless valid?taryn2009-08-193-2/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similar to Active Record - it will raise ActiveResouce::ResourceInvalid if the resource is not valid (ie if <tt>valid?</tt> returns false) However - does not raise ActiveResource::ResourceNotFound if the callbacks fail (callbacks have not yet been implemented) - it will just try to save and raise if the callbacks all fail. This is not ideal behaviour - but will do until we decide to change the behaviour of save_with_validations to actually raise (rather than catch) the ResourceInvalid exception. Signed-off-by: Joshua Peek <josh@joshpeek.com>
| * Swallow ResourceNotFound error on find_everytaryn2009-08-192-10/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Record does not explode with RecordNotFound if you go looking for a collection of objects - it just returns nil. Thus Active Resource should also not explode. After all - finding no objects that match a set of conditions is not exceptional behaviour - unlike looking for a specific object with a given id (which you'd expect to exist). I've also added documentation to +find+ to reflect this. Signed-off-by: Joshua Peek <josh@joshpeek.com>
| * Pulled find-based tests into their own test case. This matches Active ↵taryn2009-08-192-76/+182
| | | | | | | | | | | | Record, and allows us to have one places where all find-tests are located, which will help when adding dynamic finders later. Signed-off-by: Joshua Peek <josh@joshpeek.com>
| * Moved all test cases into a new test/cases directory to match Active Record ↵taryn2009-08-199-0/+0
| | | | | | | | | | | | test directory structure. Signed-off-by: Joshua Peek <josh@joshpeek.com>
| * Added validations to ActiveResource. Added a smoke test to see if we can add ↵taryn2009-08-193-15/+123
| | | | | | | | | | | | a validation and use it, and add a validates callback and use it. Signed-off-by: Joshua Peek <josh@joshpeek.com>
| * Remove sqlite2 build from CI recipe [#3066 state:resolved]Mike Gunderloy2009-08-181-8/+0
| | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* | Remove whitespace.Emilio Tagua2009-08-192-2/+3
| |
* | Remove unused quoted_record_ids, now ARel does this using ARel::In.Emilio Tagua2009-08-181-9/+0
| |
* | has_many nullify associations keys using ARel.Emilio Tagua2009-08-181-9/+9
| |
* | Remove now unused quote_table_name, ARel does that quoting now.Emilio Tagua2009-08-181-7/+0
| |
* | habtm insertion with ARel integration.Emilio Tagua2009-08-181-8/+5
| |
* | habtm delete method integrated with ARel.Emilio Tagua2009-08-181-4/+5
| |
* | Call to_sql method on ActiveRecord::Relation instance not it's relationEmilio Tagua2009-08-181-1/+1
| | | | | | | | attribute.'
* | Override respond_to? in ActiveRecord::Relation to go withEmilio Tagua2009-08-182-0/+16
| | | | | | | | method_missing.
* | Cache arel_table when possible, use class method arel_table insteadEmilio Tagua2009-08-182-12/+13
| | | | | | | | instance method.
* | Cache #arel_able when possible.Emilio Tagua2009-08-181-2/+5
| |
* | Inline initializer setup.Emilio Tagua2009-08-181-2/+1
| |
* | Use immutable relation objects to generate queries.Emilio Tagua2009-08-186-92/+87
| |
* | Use explicit method definition instead of metaprogramming.Emilio Tagua2009-08-181-11/+16
| |
* | Relation#joins! should know what to join instead of delegating toEmilio Tagua2009-08-181-7/+13
| | | | | | | | construct_join.
* | Fix typo in test classname.Emilio Tagua2009-08-181-1/+1
| |
* | Use finder options as relation method names to provide more familiarEmilio Tagua2009-08-187-68/+81
| | | | | | | | | | naming. Use bang methods convention in methods that alter the relation.
* | Clean up relation joins when finding records with included associations.Emilio Tagua2009-08-171-12/+12
| |
* | Merge commit 'rails/master'Emilio Tagua2009-08-1723-246/+158
|\|
| * Remove support for SQLite 2.Pratik Naik2009-08-179-107/+19
| | | | | | | | If you're still using it, please install the plugin from git://github.com/rails/sqlite2_adapter.git
| * k, thats really slow, lets notJoshua Peek2009-08-161-8/+0
| |
| * Cleanup route reloading in tests. Prefer with_routing over using ↵Joshua Peek2009-08-1614-139/+147
| | | | | | | | ActionController::Routing::Routes directly
* | Merge commit 'rails/master'Emilio Tagua2009-08-1741-1143/+619
|\| | | | | | | | | Conflicts: activerecord/lib/active_record/calculations.rb
| * Fixes ActionMailer regression [#3059 state:resolved]Yehuda Katz2009-08-151-1/+1
| |
| * Missing fixture template -- fixes AP testsYehuda Katz2009-08-151-0/+1
| |
| * Fix test_has_many_through_polymorphic_has_one on sqlite2 [#3054 state:resolved]Jay Pignata2009-08-151-1/+1
| | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Fix calculation tests on sqlite2 [#3053 state:resolved]Jay Pignata2009-08-151-1/+1
| | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Bump pg gem requirement to 0.8.0. Build psql db with UTF8 encoding.Jeremy Kemper2009-08-152-3/+3
| |
| * Adding a call to logger from params_parser to give detailed debug ↵Jay Pignata2009-08-153-5/+46
| | | | | | | | | | | | | | | | information when invalid xml or json is posted [#2481 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
| * Axe "best fit" generation supportJoshua Peek2009-08-152-39/+2
| |
| * Normalize route generation order: associations, yield block, then own routes.Jeremy Kemper2009-08-151-9/+9
| |
| * Got tests to pass with some more changes.Yehuda Katz2009-08-1520-127/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * request.formats is much simpler now * For XHRs or Accept headers with a single item, we use the Accept header * For other requests, we use params[:format] or fallback to HTML * This is primarily to work around the fact that browsers provide completely broken Accept headers, so we have to whitelist the few cases we can specifically isolate and treat other requests as coming from the browser * For APIs, we can support single-item Accept headers, which disambiguates from the browsers * Requests to an action that only has an XML template from the browser will no longer find the template. This worked previously because most browsers provide a catch-all */*, but this was mostly accidental behavior. If you want to serve XML, either use the :xml format in links, or explicitly specify the XML template: render "template.xml".
| * Caches and cache clearing seems to actually work, but the actual ↵Yehuda Katz2009-08-155-57/+144
| | | | | | | | architecture is kind of messy. Next: CLEAN UP.
| * More cleanup of ActionView and reduction in need for blocks in some cases:Yehuda Katz2009-08-159-42/+14
| | | | | | | | | | | | | | | | * only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine
| * Clean up ActionView some:Yehuda Katz2009-08-156-75/+56
| | | | | | | | | | | | | | | | | | | | * Call _evaluate_assigns_and_ivars at the two entry points so we don't have to do a check at every render. * Make template.render viable without having to go through a wrapper method * Remove old TemplateHandler#render(template, local_assigns) path so we don't have to set self.template every time we render a template. * Move Template rescuing code to Template#render so it gets caught every time. * Pull in some tests from Pratik that test render @object in ActionView
| * Fix ActiveResource load test for 64bit machines [#3051 state:resolved]Jatinder Singh2009-08-151-3/+3
| | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Skip isolation test tests when using MiniTestJeremy Kemper2009-08-151-2/+4
| |
| * Attempt to rewrite most of the highly coupled router segments testsJoshua Peek2009-08-141-741/+221
| |
| * Kill routing timed testsJoshua Peek2009-08-141-50/+3
| |
* | Remove group when building the relation, it will be added later ifEmilio Tagua2009-08-161-1/+0
| | | | | | | | options[:group] is given.
* | Don't use regular rinder on calculations since scoping order blowsEmilio Tagua2009-08-141-1/+7
| | | | | | | | PostreSQL.