aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #2155 from vijaydev/changelogsSantiago Pastorino2011-07-191-0/+2
|\ | | | | Adding changelog entry for submit helper change which removed object_name_id generation
| * add entry for submit helper change removing object_name_idVijay Dev2011-07-201-0/+2
| |
* | Merge pull request #2154 from vijaydev/better_mapSantiago Pastorino2011-07-191-1/+1
|\ \ | |/ |/| Avoid Symbol#to_proc
| * avoid Symbol#to_procVijay Dev2011-07-201-1/+1
|/
* Merge pull request #2148 from norman/masterSantiago Pastorino2011-07-191-0/+2
|\ | | | | Explicitly require Active Support dependencies (master)
| * Explicitly require Active Support dependenciesNorman Clarke2011-07-191-0/+2
|/ | | | | | | | | | | | This fixes errors when using Active Record outside of Rails. In Rails, these files are required by other classes that are always loaded, so this error does not happen. Without core_ext/module/delegation, a NoMethodError is raised because `delegate` remains undefined. Without core_ext/class/attribute_acessors, an ArgumentError is raised because `delegate` does not receive a value for its :to option.
* Merge pull request #2139 from mcmire/issue_2078_masterSantiago Pastorino2011-07-182-1/+13
|\ | | | | Fix for #2078 (against master)
| * ActiveRecord: Fix eager loading so that giving a blank order clause ↵Elliot Winkler2011-07-182-1/+13
| | | | | | | | generates valid SQL
* | Merge pull request #2141 from joshk/masterXavier Noria2011-07-184-9/+159
|\ \ | |/ |/| Config files to get Rails on Travis-CI
| * This fixes an issue when bundling to a local path (eg. /vendor/bundle).Josh Kalderimis2011-07-171-6/+2
| | | | | | | | | | If you bundle to a local path bundler is not included in it, so calling "gem 'bundler'" will fail.
| * Added a .travis.yml config and travis specific ci script.Josh Kalderimis2011-07-153-3/+157
| | | | | | | | | | | | | | | | Don't install ruby-debug if running the test suite on Travis, linecache19 is the main offender, very very slow. And do not install pg if Travis is bundling the gems, pg will be setup on Travis soon.
* | Merge pull request #2133 from jstorimer/ensure-status-codes-are-logged-properlyJosé Valim2011-07-182-4/+23
|\ \ | | | | | | Ensure that status codes are logged properly
| * | Ensure that status codes are logged properlyJesse Storimer2011-07-182-4/+23
| | | | | | | | | | | | | | | | | | Needed to move AC::Metal::Instrumentation before AM::Metal::Rescue so that status codes rendered from rescue_from blocks are logged properly.
* | | Merge pull request #2116 from guilleiguaran/fix-environment-generator-actionSantiago Pastorino2011-07-182-2/+10
|\ \ \ | |/ / |/| | Fix Rails::Generators::Actions#environment when env is passed
| * | Fix Rails::Generators::Actions#environment when env is passed. Closes #2110Guillermo Iguaran2011-07-182-2/+10
| | |
* | | Merge pull request #195 from bigfix/active_model_include_serializationJosé Valim2011-07-188-241/+343
|\ \ \ | | | | | | | | ActiveModel support for the :include serialization option
| * | | ActiveModel support for the :include serialization optionJohn Firebaugh2011-07-176-90/+190
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit moves support for the :include serialization option for serializing associated objects out of ActiveRecord in into ActiveModel. The following methods support the :include option: * serializable_hash * to_json * to_xml Instances must respond to methods named by the values of the :includes array (or keys of the :includes hash). If an association method returns an object that is_a?(Enumerable) (which AR has_many associations do), it is assumed to be a collection association, and its elements must respond to :serializable_hash. Otherwise it must respond to :serializable_hash itself. While here, fix #858, XmlSerializer should not singularize already singular association names.
| * | | Move to_xml tests to xml_serialization_test.rbJohn Firebaugh2011-07-172-143/+133
| | | | | | | | | | | | | | | | | | | | One duplicate was eliminated: test_to_xml_including_methods/ test_methods_are_called_on_object.
| * | | We already have the record; no need to retrieve it againJohn Firebaugh2011-07-171-2/+2
| | | |
| * | | Replace map+compact with selectJohn Firebaugh2011-07-171-1/+1
| | | |
| * | | Add a testJohn Firebaugh2011-07-171-0/+5
| | | |
| * | | serializable_hash(:only => [], :methods => [:foo]) should workJohn Firebaugh2011-07-172-7/+14
| | | |
* | | | Merge pull request #2075 from lawrencepit/match_attribute_methodJosé Valim2011-07-181-6/+27
|\ \ \ \ | | | | | | | | | | Optimization of ActiveModel's match_attribute_method?
| * | | | Made attribute_method_matchers_cache private + docLawrence Pit2011-07-171-3/+13
| | | | |
| * | | | Issue #2075 Optimization of ActiveModel's match_attribute_method?Lawrence Pit2011-07-161-9/+17
| | | | |
| * | | | Optimization of ActiveModel's match_attribute_method?Lawrence Pit2011-07-151-2/+5
| | |_|/ | |/| |
* | | | Merge pull request #2128 from sikachu/master-dynamic_finderJon Leighton2011-07-184-16/+49
|\ \ \ \ | | | | | | | | | | Raise an ArgumentError if user passing less number of argument in the dynamic finder
| * | | | Refactor test case to use anonymous class - Thank you @tenderlovePrem Sichanugrist2011-07-181-13/+8
| | | | |
| * | | | Refactor the code a bit to reduce the duplicationPrem Sichanugrist2011-07-171-17/+8
| | | | |
| * | | | Raise an ArgumentError if user passing less number of argument in the ↵Prem Sichanugrist2011-07-174-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dynamic finder The previous behavior was unintentional, and some people was relying on it. Now the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.) So if you were doing this and expecting the second argument to be nil: User.find_by_username_and_group("sikachu") You'll now get `ArgumentError: wrong number of arguments (1 for 2).` You'll then have to do this: User.find_by_username_and_group("sikachu", nil)
* | | | | make tzinfo a development dependencyAaron Patterson2011-07-181-1/+2
| | | | |
* | | | | Merge pull request #2124 from arunagw/render_partial_invalid_check_fixSantiago Pastorino2011-07-171-2/+1
|\ \ \ \ \ | | | | | | | | | | | | Checking with to_s. As regexp fail with 1.8.7
| * | | | | Checking with to_s. As regexp fail with 1.8.7Arun Agrawal2011-07-181-2/+1
| |/ / / /
* / / / / Don't do remove_possible_method when delegate is used. Two reasons: 1) ↵Jon Leighton2011-07-182-5/+2
|/ / / / | | | | | | | | | | | | warnings should be shown, and fixed at the source and 2) the code is slow. Fixes #1937.
* | | | Merge pull request #2046 from sikachu/master-test_fixSantiago Pastorino2011-07-171-2/+6
|\ \ \ \ | | | | | | | | | | Fix a wrong assertion on url_helper_test, and add missing `#html_safe?` a
| * | | | Fix a wrong assertion on url_helper_test, and refactor `html_safe` test to ↵Prem Sichanugrist2011-07-171-2/+6
| | |/ / | |/| | | | | | | | | | be in its method
* | | | Merge pull request #2018 from bhus/render_partial_invalid_checkSantiago Pastorino2011-07-173-0/+16
|\ \ \ \ | | | | | | | | | | Render partial invalid check
| * | | | Added view template invalid name check, along with tests. No merges in commit.huskins2011-07-133-0/+16
| | | | |
* | | | | Revert "Fix failure in test_preserves_existing_fixture_data from ↵Jon Leighton2011-07-171-2/+2
| |/ / / |/| | | | | | | | | | | | | | | | | | | test/cases/fixtures_test.rb when UTC and local time occur on different dates." I am pretty sure this was an incorrect fix, and it still failed in certain circumstances anyway. I am now unable to reproduce the original failure I was experiencing so will leave it for now and see if this pops up again. This reverts commit e4479b2f1bc54edf155408d51dd3236955150ce1.
* | | | Merge pull request #2118 from arunagw/fix_plugin_gen_testSantiago Pastorino2011-07-171-1/+1
|\ \ \ \ | |_|_|/ |/| | | As we are adding db folder in it. Required in test also.
| * | | As we are adding db folder in it. Required in test also.Arun Agrawal2011-07-171-1/+1
|/ / /
* | | indeed, if we are going to remove everything in public/assets on ↵Xavier Noria2011-07-171-4/+1
| | | | | | | | | | | | assets:clean, just do that
* | | if we are cleaning all files, we are cleaning all gz filesXavier Noria2011-07-171-1/+0
| | |
* | | Merge pull request #2082 from htanata/rake_routes_formattingSantiago Pastorino2011-07-164-15/+107
|\ \ \ | | | | | | | | Better formatting of rake routes (issue #1991)
| * | | Improve formatting of route to Rack application in rake routes.Hendy Tanata2011-07-172-3/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This route: match 'foo/:id' => RackApp, :id => /[A-Z]\d{5}/ is shown as: /foo/:id(.:format) RackApp {:id=>/[A-Z]\d{5}/}
| * | | Better formatting of route requirements in rake:routes.Hendy Tanata2011-07-164-14/+85
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Previously it was: {:controller=>"photos", :action=>"show", :id=>/[A-Z]\d{5}/} Now it becomes: photos#show {:id=>/[A-Z]\d{5}/}
* | | Merge pull request #2108 from loz/masterSantiago Pastorino2011-07-161-0/+5
|\ \ \ | | | | | | | | Adds gem helper rake tasks to engines generator
| * | | Added gem helper to rake task for engines, as per pull request from ↵Jonathan Lozinski2011-07-161-0/+5
| | | | | | | | | | | | | | | | 3-1-stable, #2103
* | | | Fix the output a bitSantiago Pastorino2011-07-161-2/+2
| | | |
* | | | Merge pull request #2101 from loz/masterJosé Valim2011-07-161-1/+1
|\| | | | | | | | | | | Added db to gemspec so migrations are packaged