Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't use `Column` for type casting in Relation calculations | Sean Griffin | 2014-06-18 | 2 | -17/+8 |
| | |||||
* | Merge pull request #15709 from zuhao/refactor_actionview_compiled_templates_test | Yves Senn | 2014-06-18 | 1 | -8/+1 |
|\ | | | | | Move cleanup into teardown, delete obsolete code. | ||||
| * | Move cleanup into teardown, delete obsolete code. | Zuhao Wan | 2014-06-14 | 1 | -8/+1 |
| | | |||||
* | | Reconnect after possibly enabling hstore | Matthew Draper | 2014-06-18 | 1 | -0/+2 |
| | | |||||
* | | Merge pull request #15782 from sgrif/sg-column-defaults | Matthew Draper | 2014-06-18 | 17 | -68/+60 |
|\ \ | | | | | | | Don't type cast the default on the column | ||||
| * | | Don't type cast the default on the column | Sean Griffin | 2014-06-17 | 17 | -68/+60 |
| | | | | | | | | | | | | | | | | | | | | | If we want to have type decorators mess with the attribute, but not the column, we need to stop type casting on the column. Where possible, we changed the tests to test the value of `column_defaults`, which is public API. `Column#default` is not. | ||||
* | | | Merge pull request #15790 from sgrif/sg-mutable-points | Rafael Mendonça França | 2014-06-17 | 3 | -3/+31 |
|\ \ \ | | | | | | | | | Detect in-place changes on point types | ||||
| * | | | Detect in-place changes on point types | Sean Griffin | 2014-06-17 | 3 | -3/+31 |
| | | | | |||||
* | | | | Deprecate Rails::Rack::LogTailer | Rafael Mendonça França | 2014-06-17 | 2 | -0/+8 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | It was being used by Rails for show the development logs but since Rails 4 it is not being used anymore on the framework. This class seems to be private but it were part of the public API we are deprecating before removing. | ||||
* | | | Merge pull request #15789 from sgrif/sg-enable-hstore | Rafael Mendonça França | 2014-06-17 | 1 | -0/+6 |
|\ \ \ | | | | | | | | | Enable hstore in array tests | ||||
| * | | | Enable hstore in array tests | Sean Griffin | 2014-06-17 | 1 | -0/+6 |
|/ / / | |||||
* | | | Merge pull request #15786 from sgrif/sg-in-place-array-mutation | Rafael Mendonça França | 2014-06-17 | 3 | -12/+41 |
|\ \ \ | | | | | | | | | Detect mutations of arrays and array members | ||||
| * | | | Detect mutations of arrays and array members | Sean Griffin | 2014-06-17 | 3 | -12/+41 |
|/ / / | |||||
* | | | initialize the right variable | Rafael Mendonça França | 2014-06-17 | 1 | -1/+1 |
| | | | |||||
* | | | :scissors: | Rafael Mendonça França | 2014-06-17 | 1 | -8/+8 |
| | | | |||||
* | | | Add a generic --skip-gems options to generator | Rafael Mendonça França | 2014-06-17 | 3 | -10/+19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also remove --skip-turbolinks. This option is useful if users want to remove some gems like jbuilder, turbolinks, coffee-rails, etc that don't have specific options on the generator. rails new my_app --skip-gems turbolinks coffee-rails | ||||
* | | | Merge pull request #15784 from sgrif/sg-delimiter | Rafael Mendonça França | 2014-06-17 | 4 | -7/+54 |
|\ \ \ | | | | | | | | | Ensure `OID::Array#type_cast_for_database` matches PG's quoting behavior | ||||
| * | | | Ensure `OID::Array#type_cast_for_database` matches PG's quoting behavior | Sean Griffin | 2014-06-17 | 4 | -7/+54 |
|/ / / | | | | | | | | | | | | | | | | Also takes a step towards supporting types which use a character other than ',' for the delimiter (`box` is the only built in type for which this is the case) | ||||
* | | | Merge pull request #15778 from sgrif/sg-pg-mutable-arrays | Matthew Draper | 2014-06-18 | 4 | -38/+62 |
|\ \ \ | | | | | | | | | Move pg array database type casting to the Array type | ||||
| * | | | Move array database type casting to the Array type | Sean Griffin | 2014-06-17 | 4 | -38/+62 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The case where we have a column object, but don't have a type cast method involves type casting the default value when changing the schema. We get one of the column definition structs instead. That is a case that I'm trying to remove overall, but in the short term, we can achieve the same behavior without needing to pass the adapter to the array type by creating a fake type that proxies to the adapter. | ||||
* | | | | Merge pull request #15716 from schuetzm/skip-turbolinks | Rafael Mendonça França | 2014-06-17 | 2 | -2/+21 |
|\ \ \ \ | | | | | | | | | | | Add an option to skip installation of Turbolinks | ||||
| * | | | | Add an option to skip installation of Turbolinks | Marc Schütz | 2014-06-14 | 2 | -2/+21 |
| | | | | | |||||
* | | | | | Merge pull request #15727 from aditya-kapoor/add-tests-for-migration | Matthew Draper | 2014-06-18 | 1 | -0/+17 |
|\ \ \ \ \ | |_|_|/ / |/| | | | | Add test cases for Migration#inverse_of | ||||
| * | | | | Add test cases for Migration#inverse_of | Aditya Kapoor | 2014-06-17 | 1 | -0/+17 |
| | | | | | |||||
* | | | | | Fix documentation from #15669 [ci skip] | Zachary Scott | 2014-06-17 | 1 | -3/+5 |
| | | | | | |||||
* | | | | | [ci skip] fix doc for the Hash#assert_valid_keys | Aditya Kapoor | 2014-06-17 | 1 | -3/+3 |
| | | | | | |||||
* | | | | | Merge pull request #15780 from sgrif/sg-dont-always-save-mutable-types | Rafael Mendonça França | 2014-06-17 | 3 | -2/+4 |
|\ \ \ \ \ | | | | | | | | | | | | | Don't assume that Hstore columns have always changed | ||||
| * | | | | | Don't assume that Hstore columns have always changed | Sean Griffin | 2014-06-17 | 3 | -2/+4 |
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HStore columns come back from the database separated by a comma and a space, not just a comma. We need to mirror that behavior since we compare the two values. Also adds a regression test against JSON to ensure we don't have the same bug there. | ||||
* | | | | | Merge pull request #15775 from sgrif/sg-use-column-defaults-in-dirty | Rafael Mendonça França | 2014-06-17 | 1 | -11/+3 |
|\ \ \ \ \ | |/ / / / |/| | | | | Use `column_defaults` in dirty for checking changed defaults | ||||
| * | | | | Use `column_defaults` in dirty for checking changed defaults | Sean Griffin | 2014-06-17 | 1 | -11/+3 |
|/ / / / | | | | | | | | | | | | | | | | | | | | | We no longer need to "init changed attributes" from the initializer, either, as there is no longer a case where a given value would differ from the default, but would not already be marked as changed. | ||||
* | | | | Merge pull request #15771 from sgrif/sg-stop-messing-with-column-defaults | Rafael Mendonça França | 2014-06-17 | 3 | -12/+32 |
|\ \ \ \ | | | | | | | | | | | Don't mess with `column_defaults` when optimistic locking is enabled | ||||
| * | | | | Don't mess with `column_defaults` when optimistic locking is enabled | Sean Griffin | 2014-06-17 | 3 | -12/+32 |
|/ / / / | |||||
* | | | | Merge pull request #15768 from zuhao/refactor_activesupport_concern_test | Yves Senn | 2014-06-17 | 1 | -1/+2 |
|\ \ \ \ | | | | | | | | | | | Move test teardown into `ensure` block. | ||||
| * | | | | Move test teardown into `ensure` block. | Zuhao Wan | 2014-06-17 | 1 | -1/+2 |
|/ / / / | |||||
* | | | | add `bin/rake db:purge` task to empty the current database. | Yves Senn | 2014-06-17 | 4 | -0/+55 |
| | | | | |||||
* | | | | fix typo in test method names. [ci skip] | Yves Senn | 2014-06-17 | 1 | -4/+4 |
| | | | | |||||
* | | | | Merge pull request #15765 from rahul100885/master | Yves Senn | 2014-06-17 | 1 | -3/+3 |
|\ \ \ \ | | | | | | | | | | | [ci skip] doc corrected : ActiveRecord::Base.connections to ActiveRecord::Base.configurations | ||||
| * | | | | [ci skip] doc corrected : ActiveRecord::Base.connections to ↵ | Rahul P. Chaudhari | 2014-06-17 | 1 | -3/+3 |
|/ / / / | | | | | | | | | | | | | ActiveRecord::Base.configurations | ||||
* | | | | Formatting fix in AS changelog [ci skip] | Juanjo Bazán | 2014-06-16 | 1 | -2/+5 |
| | | | | |||||
* | | | | Merge pull request #15760 from sgrif/sg-decorate-matching | Rafael Mendonça França | 2014-06-16 | 6 | -32/+57 |
|\ \ \ \ | | | | | | | | | | | Promote time zone aware attributes to a first class type decorator | ||||
| * | | | | Promote time zone aware attributes to a first class type decorator | Sean Griffin | 2014-06-16 | 6 | -32/+57 |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This refactoring revealed the need for another form of decoration, which takes a proc to select which it applies to (There's a *lot* of cases where this form can be used). To avoid duplication, we can re-implement the old decoration in terms of the proc-based decoration. The reason we're `instance_exec`ing the matcher is for cases such as time zone aware attributes, where a decorator is defined in a parent class, and a method called in the matcher is overridden by a child class. The matcher will close over the parent, and evaluate in its context, which is not the behavior we want. | ||||
* | | | | Merge pull request #15759 from sgrif/sg-extract-type-decorator | Rafael Mendonça França | 2014-06-16 | 1 | -8/+24 |
|\ \ \ \ | | | | | | | | | | | Refactor application of type decorators into an object | ||||
| * | | | | Refactor application of type decorators into an object | Sean Griffin | 2014-06-16 | 1 | -8/+24 |
| | | | | | |||||
* | | | | | Merge pull request #15758 from aditya-kapoor/replace-keyword | Rafael Mendonça França | 2014-06-16 | 2 | -4/+4 |
|\ \ \ \ \ | | | | | | | | | | | | | [ci skip] /javascript/ ~> JavaScript | ||||
| * | | | | | [ci skip] /javascript/ ~> JavaScript | Aditya Kapoor | 2014-06-17 | 2 | -4/+4 |
|/ / / / / | |||||
* | | | | | Merge pull request #15756 from aditya-kapoor/add-api-doc-for-querying | Zachary Scott | 2014-06-16 | 1 | -1/+9 |
|\ \ \ \ \ | |/ / / / |/| | | | | [ci skip] add API doc for AR Group. | ||||
| * | | | | [ci skip] add API doc for AR Group. | Aditya Kapoor | 2014-06-17 | 1 | -1/+9 |
|/ / / / | |||||
* | | | | :scissors: and :nail_care: from d60c405 [ci skip] | Zachary Scott | 2014-06-16 | 1 | -3/+3 |
| | | | | |||||
* | | | | Merge pull request #15751 from aditya-kapoor/correct-serialization-doc | Zachary Scott | 2014-06-16 | 1 | -11/+11 |
|\ \ \ \ | | | | | | | | | | | [ci skip] correct doc for serialization in accordance with API Doc Guide | ||||
| * | | | | [ci skip] correct doc for serialization in accordance with API Doc Guide | Aditya Kapoor | 2014-06-16 | 1 | -11/+11 |
| | | | | |