| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit be1db9946616a4005bb7be45656cc0f84d75d915, reversing
changes made to 6680ee9427ae2639e404cd3b9538f54e136057c6.
Reason: This changed a behavior where numeric attributes when receiving
blank values didn't change its value.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Don't mess with `_before_type_cast` for numeric types
|
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
zuhao/refactor_actionmailer_i18n_with_controller_test
Restore I18n.locale to default after test.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If i18n_with_controller_test.rb were to run first, the I18n.locale will
be changed to :de, and the following tests in base_test.rb will fail:
"subject gets default from I18n"
“default subject can have interpolations”
"translations are scoped properly"
"implicit multipart with default locale"
|
|\ \ \
| |_|/
|/| | |
Restore test deliveries properly in ActionMailer.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`ActionMailer::Base.delivery_method` and
`ActionMailer::Base.perform_deliveries` have leaked states.
"delivery method can be customized per instance" and "delivery method
can be customized in subclasses not changing the parent" in
delivery_methods_test.rb will fail if test_helper_test.rb (in which
TestHelperMailerTest is inherited from ActionMailer::TestCase) runs
before it.
|
|\ \
| | |
| | | |
Add missing test cases for schema dumping defaults
|
| | | |
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before this patch, using `ActiveRecord::Base.primary_key_prefix_type`
with `:table_name_with_underscore` would change the `SchemaMigration` model
to have a primary key. This resulted in broken queries for PG because it tried
to return the inserted PK (which does not exist).
Closes #15051.
Closes #15419.
|
| | | |
|
| | |
| | |
| | |
| | | |
/cc @zuhao
|
|/ /
| |
| |
| |
| |
| |
| | |
This adds a regression test for #14411, which was fixed by #15503.
Closes #14411
Closes #14595
|
|\ \
| | |
| | | |
Bring type casting behavior of hstore/json in line with serialized
|
| | |
| | |
| | |
| | |
| | | |
`@raw_attributes` should not contain the type-cast, mutable version of
the value.
|
|\ \ \
| | | |
| | | | |
Use a frozen Set instance for CGI_VARIABLES.
|
| | | |
| | | |
| | | | |
Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The migration numbers were normalized different ways. This left
the task output in an inconsistent state.
Closes #15538.
|
| | | |
| | | |
| | | |
| | | | |
Closes #15541.
|
|\ \ \ \
| |/ / /
|/| | |
| | | | |
Baseclass becomes! subclass
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove optimization that was required with whiny nils
|
| | | | |
| | | | |
| | | | |
| | | | | |
Whiny nils is no longer a thing, so we no longer need this optimization
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Avoid misuse of underscore argument
|
|/ / / / /
| | | | |
| | | | | |
Per convention, underscore-only argument names should be used for unused parameters.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Reset callbacks after test.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Otherwise the state of callback chain is leaked.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Removed CaptureHelper#flush_output_buffer as it is only used in tests.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
reviewed: @tenderlove
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
document include_blank's usage with a string [ci skip]
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Restore Response.default_headers after test.
|
| | |_|_|/ / / /
| |/| | | | | | |
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Avoid hard-coded value in test setup/teardown.
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Make sure Mime::Type is not altered after tests.
|
| |/ / / / / / |
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Fix BC year handling in postgres
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
BC era year is (astronomical year + 1) and starts from 1 BC.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | | |
zuhao/refactor_actionpack_query_string_parsing_test
Avoid hardcoded value in test setup/teardown.
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Remove deprecated method ActiveRecord::Migrator.proper_table_name
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Fixed `ActiveSupport::TimeWithZone#-` so precision is not unnecessarily lost
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
When working with objects with a nanosecond component, the `-` method may
unnecessarily cause loss of precision.
`ActiveSupport::TimeWithZone#-` should return the same result as if we were
using `Time#-`:
Time.now.end_of_day - Time.now.beginning_of_day #=> 86399.999999999
Before:
Time.zone.now.end_of_day.nsec #=> 999999999
Time.zone.now.end_of_day - Time.zone.now.beginning_of_day #=> 86400.0
After:
Time.zone.now.end_of_day - Time.zone.now.beginning_of_day
#=> 86399.999999999
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Added Two Clarification "Tips" [ci skip]
|
| | | | | | | |
| | | | | | | |
| | | | | | | | |
It's not very clear exactly what the "params" method is and does, as the current description in the guide is somewhat vague and brief. An example is helpful, especially considering this method is referenced over 30 times in this guide. [ci skip]
|
| | |/ / / / /
| |/| | | | |
| | | | | | | |
It may be confusing to a Rails newbie why "Article" is suddenly being referred to with the "A" being capitalized. Thus far in the guide, the "a" has always been in lowercase. I think it is helpful to point out the reason for this change (especially since not using the capital "A" will result in an error). [ci skip]
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix inverse associations test
|