Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | Introduce dynamic scopes for ActiveRecord: you can now use class methods ↵ | Yaroslav Markin | 2008-12-28 | 5 | -1/+72 | |
|/ / / | | | | | | | | | | | | | | | | like scoped_by_user_name(user_name) and scoped_by_user_name_and_password(user_name, password) that will use the scoped method with attributes you supply. [#1648 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | |||||
* | | | Ensure template runner tests don't depend on hash ordering [#1654 ↵ | Mike Gunderloy | 2008-12-28 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | | Request#env['SERVER_NAME'] does not contain port number | Pratik Naik | 2008-12-28 | 3 | -8/+4 | |
| | | | ||||||
* | | | Use SimpleLogger for Rails::TemplateRunner outside of the Generator context ↵ | Aaron Quint | 2008-12-28 | 1 | -0/+10 | |
| | | | | | | | | | | | | | | | | | | [#1618 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | | Adding test coverage and better logging to Rails::TemplateRunner [#1618 ↵ | Aaron Quint | 2008-12-27 | 2 | -66/+243 | |
| | | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | | Fix ActionPack build on Windows: we really should not test anything ↵ | Yaroslav Markin | 2008-12-27 | 1 | -10/+12 | |
| | | | | | | | | | | | | | | | | | | regarding symlinks on Windows. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | | Refactor ActiveRecord::Base#new_record? [#1647 state:committed] | Yaroslav Markin | 2008-12-27 | 1 | -1/+1 | |
| | | | | | | | | | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | |||||
* | | | ActiveRecord::Base#new_record? now returns false for existing records (was ↵ | Yaroslav Markin | 2008-12-27 | 3 | -2/+9 | |
| | | | | | | | | | | | | | | | | | | nil) [#1219 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | |||||
* | | | More optimizations on respond_to after a profile and benching: | Yehuda Katz | 2008-12-27 | 1 | -6/+2 | |
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | App with simple respond_to: def index respond_to do |format| format.html format.xml format.json end end On JRuby (after complete hotspot warmup) -- 8% improvement: 550 requests per second after this commit 510 requests per second with old method_missing technique On MRI (8% improvement): 430 requests per second after this commit 400 requests per second with old method_missing technique | |||||
* | | Merge commit 'fred/pullable' | Pratik Naik | 2008-12-26 | 11 | -27/+101 | |
|\ \ | ||||||
| * | | Preload uses exclusive scope [#643 state:resolved] | Frederick Cheung | 2008-12-26 | 5 | -16/+53 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | With self referential associations, the scope for the the top level should not affect fetching of associations, for example when doing Person.male.find :all, :include => :friends we should load all of the friends for each male, not just the male friends. | |||||
| * | | Association preloading no longer stops if it hits a nil object [#1630 ↵ | Pivotal Labs | 2008-12-26 | 2 | -2/+10 | |
| | | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
| * | | MaKe Hash#slice! return removed values, akin to Array [#971 state:resolved] | trans | 2008-12-26 | 2 | -4/+25 | |
| | | | | | | | | | | | | Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
| * | | Fix assert_select_rjs not checking id for inserts [#540 state:resolved] | Frederick Cheung | 2008-12-26 | 2 | -0/+9 | |
| | | | ||||||
| * | | Fix randomly failing cookie store tests | Frederick Cheung | 2008-12-26 | 1 | -5/+4 | |
| | | | | | | | | | | | | | | | Marshal.dump(Marshal.load(marshaled_hash)) is not guarenteed to be equal to marshaled_hash because of the lack of ordering of hash | |||||
* | | | Remove method missing use in respond_to | Yehuda Katz | 2008-12-26 | 1 | -4/+23 | |
| | | | ||||||
* | | | Merge docrails | Pratik Naik | 2008-12-26 | 3 | -84/+334 | |
| | | | ||||||
* | | | Don't recurse when ActionController#render is called without any arguments | Pratik Naik | 2008-12-26 | 1 | -1/+1 | |
| | | | ||||||
* | | | Make ActionController#render(symbol) behave same as ↵ | Pratik Naik | 2008-12-26 | 3 | -6/+16 | |
| | | | | | | | | | | | | ActionController#render(string) [#1435] | |||||
* | | | Make ActionController#render(string) work as a shortcut for render :action ↵ | Pratik Naik | 2008-12-25 | 3 | -4/+28 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | => string. [#1435] Examples: # Instead of render(:action => 'other_action') render('other_action') Note : Argument must not have any '/' | |||||
* | | | Make ActionController#render(string) work as a shortcut for render :template ↵ | Pratik Naik | 2008-12-25 | 3 | -4/+28 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | => string. [#1435] Examples: # Instead of render(:template => 'controller/action') render('controller/action') Note : Argument must not begin with a '/', but have at least one '/' | |||||
* | | | Make ActionController#render(string) work as a shortcut for render :file => ↵ | Pratik Naik | 2008-12-25 | 3 | -9/+36 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | string. [#1435] Examples: # Instead of render(:file => '/Users/lifo/home.html.erb') render('/Users/lifo/home.html.erb') Note : Filename must begin with a forward slash ('/') | |||||
* | | | Move ActionController::Base#render arguments validation to a separate method | Pratik Naik | 2008-12-25 | 1 | -8/+14 | |
| | | | ||||||
* | | | Make render_test.rb run in isolation | Pratik Naik | 2008-12-25 | 1 | -0/+2 | |
| | | | ||||||
* | | | Undry ActionController::TestCase#<HTTP_METHODS> for better documentation | Pratik Naik | 2008-12-25 | 2 | -14/+26 | |
|/ / | ||||||
* | | Move request parsing related code to ActionController::RequestParser | Pratik Naik | 2008-12-25 | 7 | -460/+512 | |
| | | ||||||
* | | ActionController::VerbPiggybacking middleware | Joshua Peek | 2008-12-23 | 7 | -38/+49 | |
| | | ||||||
* | | Remove duplicate attr_reader :env | Pratik Naik | 2008-12-23 | 1 | -4/+2 | |
| | | ||||||
* | | Unify ActionController::AbstractRequest and ActionController::Request | Pratik Naik | 2008-12-23 | 2 | -110/+81 | |
| | | ||||||
* | | Use Rack::MockRequest for TestRequest | Pratik Naik | 2008-12-23 | 3 | -20/+9 | |
| | | ||||||
* | | Rename RackRequest to Request | Pratik Naik | 2008-12-23 | 6 | -11/+11 | |
| | | ||||||
* | | Remove rack_process.rb | Pratik Naik | 2008-12-23 | 3 | -74/+73 | |
| | | ||||||
* | | Remove deprecated relative_url_root | Pratik Naik | 2008-12-23 | 1 | -7/+0 | |
| | | ||||||
* | | Defining a new method is atomic, no mutex needed. | Joshua Peek | 2008-12-22 | 1 | -8/+2 | |
| | | ||||||
* | | Move default middleware stack to middlewares.rb | Joshua Peek | 2008-12-22 | 2 | -17/+21 | |
| | | ||||||
* | | ActiveRecord::QueryCache middleware | Joshua Peek | 2008-12-22 | 5 | -34/+28 | |
| | | ||||||
* | | Ensure of Model#create support custom updated_at and updated_on attributes ↵ | Luis Hurtado | 2008-12-22 | 2 | -2/+12 | |
| | | | | | | | | | | | | [#1612 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Use I18n for date/time select helpers prompt text [#561 state:resolved] | Sam Oliver | 2008-12-22 | 3 | -6/+20 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Add :allow_nil option to delegate [#1127 state:resolved] | Sergio Gil | 2008-12-21 | 3 | -1/+56 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Ensure Model#last doesn't affects order for another finders inside the same ↵ | Daniel Luz | 2008-12-21 | 2 | -3/+26 | |
| | | | | | | | | | | | | scope [#1499 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Added prompt options to date helpers [#561 state:resolved] | Sam Oliver | 2008-12-21 | 3 | -0/+402 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Ensure the template format is always passed to the template finder. Now we ↵ | Joshua Peek | 2008-12-21 | 9 | -108/+102 | |
| | | | | | | | | can cleanup some nasty stuff. | |||||
* | | Merge commit 'fred/more_pullable' | Pratik Naik | 2008-12-21 | 3 | -4/+38 | |
|\ \ | ||||||
| * | | Allow use of symbols for :type option of ↵ | =?utf-8?q?Adam=20Cig=C3=A1nek?= | 2008-12-21 | 2 | -3/+37 | |
| | | | | | | | | | | | | | | | | | | ActionController::Streaming#send_file/#send_data [#1232 state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
| * | | Fix script/dbconsole not handling numeric password [#1395 state:resolved] | pfagiani | 2008-12-21 | 1 | -1/+1 | |
| | | | | | | | | | | | | Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
* | | | Correct description of tmp:create task [#1607 state:resolved] [Roderick van ↵ | Pratik Naik | 2008-12-21 | 1 | -2/+2 | |
| | | | | | | | | | | | | Domburg] | |||||
* | | | Fix configure_dependency_for_has_many not quoting conditions properly [#1461 ↵ | Frederick Cheung | 2008-12-21 | 3 | -3/+17 | |
| | | | | | | | | | | | | state:resolved] | |||||
* | | | Use explicit order to stop test failing randomly | Frederick Cheung | 2008-12-21 | 1 | -2/+2 | |
| | | | ||||||
* | | | Fix failing cookie store test | Frederick Cheung | 2008-12-21 | 1 | -3/+3 | |
| | | | ||||||
* | | | Remove observe_field :on option as prototype no longer supports it [#1088 ↵ | Frederick Cheung | 2008-12-21 | 1 | -11/+0 | |
| | | | | | | | | | | | | state:resolved] |