| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* master: (122 commits)
Rails.application should be set inside before_configuration hook
remove check for present? from delete_all
Remove useless begin..end
Build the reverse_order on its proper method.
Use connection-specific bytea escaping
Ignore order when doing count.
make enums distinct per class
Remove unused `subclass_controller_with_flash_type_bar` var from flash test.
fix CollectionProxy delete_all documentation
Added OS X specific commands to installation guide [ci skip] Recommended using homebrew for installing MySQL and PostgreSQL
Fix setup of adding _flash_types test.
Use SVG version of travis build status badge [skip ci]
W3C CSP document moved to gihub.io URL [ci skip]
sprockets-rails was released
Fix the test defining the models in the right place
Add CHANGELOG entry for #11650 [ci skip]
Declare the assets dependency
Use sass-rails 4.0.3
Make possible to use sprockets-rails 2.1
add missing parentheses to validates_with documentation [skip ci]
...
|
| |\
| | |
| | | |
Build the reverse_order on its proper method.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The reverse_order method was using a flag to control if the order should
be reversed or not. Instead of using this variable just build the reverse order
inside its proper method.
This implementation was leading to an unexpected behavior when using
reverse_order and then applying reorder(nil).
Example:
Before
Post.order(:name).reverse_order.reorder(nil)
# => SELECT "posts".* FROM "posts" ORDER BY "posts"."id" DESC
After
Post.order(:name).reverse_order.reorder(nil)
# => SELECT "posts".* FROM "posts"
|
| |\ \
| | | |
| | | | |
remove check for present? from delete_all method
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Passing in a blank string is a bug so there's no reason
to check for a blank string.
|
| |/ /
| | |
| | |
| | | |
Fixes #14620
|
| |/ |
|
| |\
| | |
| | | |
Use connection-specific bytea escaping
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In our normal usage, it's rare for this to make a difference... but is
more technically correct.
As well as a spec that proves this is a good idea, let's also add a more
sane-looking one that just covers basic to_sql functionality. There
aren't many places where we actually use escape_bytea, but that's one
that won't be going away.
|
| |\ \
| | | |
| | | | |
Ignore order when doing count.
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
This is necessary because Postgresql doesn't play nice with ORDER BY and
no GROUP BY.
Fixes #14621.
|
| |\ \
| | |/
| |/| |
Make enums distinct per class
|
| | | |
|
| |\ \
| | | |
| | | | |
Remove unused `subclass_controller_with_flash_type_bar` var from flash test.
|
| | | | |
|
| |\ \ \
| | |/ /
| |/| | |
Added OS X specific commands to installation guide [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
Recommended using homebrew for installing MySQL and PostgreSQL
|
| |\ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
eileencodes/fix_incorrect_collection_proxy_delete_all_documentation
fix CollectionProxy delete_all documentation
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This method no longer returns an array of all records that
have been removed. Correct documentation to reflect this change.
See issue 14546
|
| |\ \ \
| | |/ /
| |/| | |
Fix setup of adding _flash_types test.
|
| | |/
| | |
| | |
| | |
| | |
| | |
| | | |
Adding flash types to a controller within any of the tests will result
in a global state change of the controller under test.
This patch will prevent state leaks and allow us to run the test in random order.
|
| |\ \
| | |/
| |/| |
Use SVG version of travis build status badge [ci skip]
|
| |/ |
|
| |\
| | |
| | | |
W3C CSP document moved to gihub.io URL [ci skip]
|
| |/
| |
| | |
The old link https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html is now being soft redirected to this new URL
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
PostgreSQL, remove varchar limit.
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | |
| | | |
This is an illustration of https://github.com/rails/rails/pull/13435#issuecomment-33789752
Removing the limit from the PG and SQLite adapter solves the issue.
MySQL is still affected by the issue.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
& Yves Senn]
There is no reason for the PG adapter to have a default limit of 255 on :string
columns. See this snippet from the PG docs:
Tip: There is no performance difference among these three types, apart
from increased storage space when using the blank-padded type, and a
few extra CPU cycles to check the length when storing into a
length-constrained column. While character(n) has performance
advantages in some other database systems, there is no such advantage
in PostgreSQL; in fact character(n) is usually the slowest of the
three because of its additional storage costs. In most situations text
or character varying should be used instead.
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | | |
| | | |
| | | | |
Renamed private methods _create_record and _update_record
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is to ensure that they are not accidentally called by the app code.
They are renamed to _create_record and _update_record respectively.
Closes #11645
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
CollectionProxy uses the arel of its association's scope.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
CollectionProxy should be able to reuse the behavior (methods) of its parent class,
but with its own state. This change allows CollectionProxy to use the arel object
corresponding to its association's scope.
|
| |\ \ \ \
| | | | | |
| | | | | | |
add missing parentheses to validates_with documentation [skip ci]
|
| |/ / / / |
|
| | | | | |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Active support instead of ActiveSupport::Deprecation.silence we can use assert_deprecated
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
assert_deprecated
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Ensure we supply Kernel#y for 1.9 too
|
| | | |_|_|/
| | |/| | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In 1.9, it doesn't live in its own file, so we'll have to define it
ourselves.
Check RUBY_VERSION, instead of rescuing the require, because we want
this to break if `psych/y` moves in a future Ruby release.
|
| |\ \ \ \ \
| | |/ / / /
| |/| | | | |
Prevent state leak in test.
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
This will allow us to run the tests in random order.
|
| |\ \ \ \
| | | | | |
| | | | | | |
Blacklist ruby keywords for scopes
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add tests to make sure scopes cannot be create with names such as:
private, protected, public.
Make sure enum values don't collide with those methods too.
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix error when using `with_options` with lambda.
Conflicts:
activerecord/CHANGELOG.md
|