| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the host in `default_url_options` is accidentally set with a protocol such as
```
host: "http://example.com"
```
then the generated url will have the protocol twice `http://http://example.com` which is not what the user intended. Likely they wanted to define a host `host: "example.com"` and a `protocol: "http://"` but did not know the convention.
This may not the most common problem, but when it happens it can go undetected for a while. I accidentally added `http://` out of habit recently only to find all the links in my emails were broken after deploying a demo site to production. Rather than allow this accident go undetected, we can fix the problem in line by properly setting the protocol and host.
I was able to find this related question on stack overflow: http://stackoverflow.com/questions/5878329/rails-3-devise-how-do-i-make-the-email-confirmation-links-use-secure-https-n where the answer was highly upvoted.
This is based off of work in #7415 cc/ @pixeltrix
ATP Action Mailer and Action Pack
|
|\
| |
| | |
Fixed the repair_validations helper method.
|
|/
|
|
|
|
| |
it only cleared the validations that created :validate callbacks. This
didn't include the validates created by validates_with, so I've added a
method to clear all validations.
|
|\
| |
| | |
Fix warning: mismatched indentatmmismatched indentations at 'end' with 'def'
|
|/ |
|
|\
| |
| | |
drop an unused hash; change slang to SPECIAL
|
|/ |
|
|
|
|
| |
Check 862389c9537dbb6f65fd26c4325e07607ed437b5 for more background.
|
|
|
|
| |
Check pull request #9789 for more information.
|
|
|
|
|
|
|
|
|
|
| |
vipulnsward/change_from_blank_to_empty_on_string"
This reverts commit 9c4c05fc82e997b722dec4068c3aa27eaee69eb8, reversing
changes made to 4620bdcefd0c88905a005f191496df887877b8f3.
Reason: They're not completely interchangeable, since blank? will also
check for strings containing spaces.
|
|\
| |
| | |
Change from blank? to empty? on obvious string values to save extra calls
|
| |
| |
| |
| | |
calls
|
| |
| |
| |
| | |
Introduced in 5dc2e3531babcbdc165884d1a47cbcd13455522d.
|
| |
| |
| |
| | |
This reverts commit c24528fbc94dea9946a563be3bed9559583bdc57.
|
|\ \
| | |
| | | |
Change from each to each_value;drop assignment in habtm
|
| |/
| |
| |
| | |
2. drop assignment of value to sum in test
|
| | |
|
|\ \
| | |
| | | |
Digest auth should not 500 when given a basic header.
|
|/ / |
|
|\ \
| | |
| | | |
fix typos in AR. lots of them.
|
| |/ |
|
|\ \
| | |
| | | |
More helpful message when starting server
|
|/ /
| |
| |
| | |
v2 of pull request based on feedback from @rafaelfranca, @schneems, and @carlosantoniodasilva
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* master-sec:
fix protocol checking in sanitization [CVE-2013-1857]
JDOM XXE Protection [CVE-2013-1856]
fix incorrect ^$ usage leading to XSS in sanitize_css [CVE-2013-1855]
stop calling to_sym when building arel nodes [CVE-2013-1854]
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
config.ru uses the effective Rack app
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We used to pass the Rails::Application subclass to #run.
The Rails server then called #to_app to convert that class to the
actual Rack application.
if you surround `#run` with a call to `#map` the server no longer
convertes the class to the instance and we end up with unnecessary
delegation calls on every request.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
senny/9772_reraise_no_method_error_in_proper_context
`TimeWithZone` raises `NoMethodError` in proper context.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #9772.
`TimeWithZone` delegates everything to the wrapped `Time` object
using `method_missing`. The result is that `NoMethodError` error
will be raised in the context of `Time` which leads to a misleading
debug output.
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
i18n locale fallback for localized views
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix repeat of test; remove unused variable by use of each_key
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove ancient TODOs [ci skip]
|
| | |_|/ / /
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix some typos found in activemodel
|
| |/ / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Move tests out from base_test.rb to inheritance_test.rb
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
These tests should be in inheritance_test.rb since its testing a
feature which is implemented in inheritance.rb
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SQLite3 3.6.8+ supports nested transactions [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
http://www.sqlite.org/lang_savepoint.html
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L130-L132
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
refer to the contributing guide on how to create issues.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
`rake db:create` does not change permissions of root user.
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Closes #8079.
I had to rework some of the tests because the mock allowed any arguments
for `connection.exeucte`. I think this is very dangerous as there could
anything be executed without the tests noticing it.
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
"utf8mb4"
Please, see rationale in the included CHANGELOG patch.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix rake test warnings in actionpack
|