aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Correct comment [ci skip]George Claghorn2018-01-101-1/+1
|
* Extract Analyzable and Representable concernsGeorge Claghorn2018-01-108-150/+158
|
* Fix `stale_state` for nested `has_many :through` associationsRyuta Kamizono2018-01-103-22/+41
| | | | Need reloading when through record has replaced.
* Merge pull request #31667 from bogdanvlviv/clean-up-railties-testsYuji Yaginuma2018-01-102-19/+0
|\ | | | | Clean up railties tests
| * Clean up railties testsbogdanvlviv2018-01-102-19/+0
| | | | | | | | | | | | | | | | | | | | Remove `AppGeneratorTest#test_active_storage_install`. The test is added by 67db41aa7f17c2d34eb5a914ac7a6b2574930ff4, since #31534 this test doesn't test anything. Remove redundant assertions in `SharedGeneratorTests`. These assertions is added by 4a835aa3236eedb135ccf8b59ed3c03e040b8b01. Follows 67db41aa7f17c2d34eb5a914ac7a6b2574930ff4, #31534.
* | Merge pull request #16314 from ↵Ryuta Kamizono2018-01-104-1/+76
|\ \ | |/ |/| | | | | | | zoltankiss/allow-nested-has-many-associations-on-unpersisted-parent-instances fix nested `has many :through` associations on unpersisted parent instances
| * Fix nested `has many :through` associations on unpersisted instancesZoltan Kiss2015-03-264-1/+70
| | | | | | | | Fixes: #16313
* | Fix "the the " [ci skip]Ryuta Kamizono2018-01-103-3/+3
| |
* | Bring back passing single record support for `Preloader`Ryuta Kamizono2018-01-101-1/+1
| | | | | | | | | | | | | | | | | | | | I removed redundant `Array.wrap(records)` since `Preloader` is nodoc class and Active Record always pass `records` as an array to `Preloader`. But if users relies on that behavior, it is not worth dropping its behavior. Fixes #31661.
* | Merge pull request #29685 from ayanko/fix-slow-name-error-missing-nameRyuta Kamizono2018-01-101-0/+5
|\ \ | | | | | | Fix performance issue with NameError#missing_name on ruby >= v2.3.0.
| * | Fix performance issue with NameError#missing_name on ruby >= v2.3.0.Andriy Yanko2017-07-101-0/+5
| | | | | | | | | | | | | | | Since ruby v2.3.0 `did_you_mean` gem shipped and ENABLED by default. It patches NameError#message with spell corrections which are SLOW.
* | | Merge pull request #27597 from brchristian/first_last_parityRyuta Kamizono2018-01-103-1/+31
|\ \ \ | | | | | | | | Consistency between first() and last() with limit
| * | | resolve inconsistencies between first and to_a.first with limitBrian Christian2018-01-093-1/+31
| | | |
* | | | Merge pull request #31534 from claudiob/kaspth-approachKasper Timm Hansen2018-01-097-16/+37
|\ \ \ \ | |/ / / |/| | | Don't include Active Storage migrations in new apps
| * | | Help if Active Storage tables are missingClaudio B2017-12-213-0/+35
| | | | | | | | | | | | | | | | | | | | | | | | When a user tries to create a new attachment or blog and the matching table is missing from the database (`active_storage_attachments` and `active_storage_blobs` by default), an informative error is displayed that invites users to run the `active_storage:install` task.
| * | | Don't run rails active_storage:install in new appsclaudiob2017-12-144-16/+2
| | | | | | | | | | | | | | | | See #31315 for full discussion
* | | | Merge pull request #31652 from kami-zh/activestorage-callbacksGeorge Claghorn2018-01-092-2/+8
|\ \ \ \ | | | | | | | | | | Change Active Storage destroy callbacks
| * | | | Change Active Storage destroy callbackskami-zh2018-01-092-2/+8
|/ / / / | | | | | | | | | | | | | | | | There is concern that only blob are deleted depending on the `before_destroy` definition order which throws abort.
* | | | Add 'Referrer-Policy' header to default headers setGuillermo Iguaran2018-01-083-3/+10
| | | |
* | | | Rebuild activestorage.jsJavan Makhmali2018-01-081-1/+1
| | | | | | | | | | | | | | | | To pick up 21417e02e906f6b64f013aafefdc0cb8ea8b5e74
* | | | Work around Firefox's refusal to dispatch events on disabled elements. Fixes ↵Javan Makhmali2018-01-081-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | #31393 Brought to you by a 12 year old Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=329509
* | | | Fix attaching blobs to optimistically-locked recordsGeorge Claghorn2018-01-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Explicitly declare inverse associations so ActiveStorage::Attachment touches the original record instance. Closes #31542.
* | | | Merge pull request #31650 from rosa/masterGeorge Claghorn2018-01-082-4/+15
|\ \ \ \ | | | | | | | | | | Allow overriding filename in `Blob#service_url`
| * | | | Allow overriding filename in `Blob#service_url`Rosa Gutierrez2018-01-082-4/+15
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | This is useful when we have several representations for the same underlying file, each one with a different name, and we need to provide a custom download URL based on that name and not that of the underlying file.
* | | | Merge pull request #31648 from dixitp012/rubocop_active_support_testRyuta Kamizono2018-01-081-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | Fix rubocop space before comma
| * | | | Fix rubocop space before commaDixit Patel2018-01-081-1/+1
|/ / / /
* | | | Remove meaningless checkyuuji.yaginuma2018-01-081-1/+1
| | | | | | | | | | | | | | | | `ActiveSupport::OrderedOptions` responds to any message.
* | | | Merge pull request #31547 from ↵Yuji Yaginuma2018-01-083-8/+34
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | eugeneius/use_authenticated_message_encryption_new_framework_defaults Allow use_authenticated_message_encryption to be set in new_framework_defaults_5_2.rb
| * | | | Allow use_authenticated_message_encryption to be set in ↵Eugene Kenny2018-01-073-8/+34
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | new_framework_defaults_5_2.rb Enabling this option in new_framework_defaults_5_2.rb didn't work before, as railtie initializers run before application initializers. Using `respond_to?` to decide whether to set the option wasn't working either, as `ActiveSupport::OrderedOptions` responds to any message.
* | | | Fix the desc for image_alt change [ci skip]Prathamesh Sonpatki2018-01-071-1/+1
| | | |
* | | | Added deprecation and removal notes for Action View [ci skip]Prathamesh Sonpatki2018-01-071-2/+5
| | | |
* | | | Added deprecations and removals notes for Action Pack [ci skip]Prathamesh Sonpatki2018-01-072-3/+6
| | | |
* | | | Added release notes for Action Cable [ci skip]Prathamesh Sonpatki2018-01-071-1/+10
| | | |
* | | | Merge pull request #31610 from ↵Eileen M. Uchitelle2018-01-073-3/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/improve-deprecation-msg-pr-29358 Improve the deprecation message for using subclass of Rails::Application to start the Rails server
| * | | | Improve the deprecation message for using subclass of Rails::Application to ↵Prathamesh Sonpatki2018-01-073-3/+3
| | | | | | | | | | | | | | | | | | | | start the Rails server
* | | | | Fix deleting through records when using has_many through with `source_type`Ryuta Kamizono2018-01-082-20/+29
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently deleting through records doesn't respect `source_type`. It should not be ignored in that case. Related #23209. Fixes #24116.
* | | | Document automatic width-height swapping [ci skip]George Claghorn2018-01-071-0/+2
| | | |
* | | | Remove redundant sentences [ci skip]George Claghorn2018-01-072-4/+2
| | | |
* | | | Simply use `scope.delete_all` instead of constructing delete managerRyuta Kamizono2018-01-071-8/+1
| | | |
* | | | Tweak engine for readabilityGeorge Claghorn2018-01-071-11/+13
| | | |
* | | | Make `find_nth_from_last` more performant when using reversible orderRyuta Kamizono2018-01-071-6/+5
| | | | | | | | | | | | | | | | | | | | We can use `relation.last(index)[-index]` instead of loading all records when using reversible order because `last` will call `reverse_order`.
* | | | Fix `last` with `offset` to behave consistently with loaded relationRyuta Kamizono2018-01-072-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | Currently `last` with `offset` behaves incorrectly because `offset` can not be reversed like `limit`. Therefore, `offset` should also be handled like `limit`.
* | | | Fix `pluck` with eager loading to respect `offset`Ryuta Kamizono2018-01-072-1/+6
| | | |
* | | | Revert commit 4ec5b0d6b4d8a57e034b1014942356e95caf47aa in favor of #28379Ryuta Kamizono2018-01-072-9/+4
| | | | | | | | | | | | | | | | | | | | Commit 4ec5b0d was for fixing the regression #18787, but #28379 fixes #18787 as well. So 4ec5b0d is no longer necessary.
* | | | Merge pull request #31639 from rosa/masterGeorge Claghorn2018-01-055-2/+36
|\ \ \ \ | | | | | | | | | | Force :attachment as content disposition for some content types
| * | | | Force content disposition to attachment for specific content typesRosa Gutierrez2018-01-055-2/+36
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In this way we avoid HTML, XML, SVG and other files that can be rendered by the browser to be served inline by default. Depending on the origin from where these files are served, this might lead to XSS vulnerabilities, and in the best case, to more realistic phishing attacks and open redirects. We force it rather than falling back to it when other disposition is not provided. Otherwise it would be possible for someone to force inline just by passing `disposition=inline` in the URL. The list of content types to be served as attachments is configurable.
* | | | Consolidate `queue_adapter=` and `interpret_adapter`Ryuta Kamizono2018-01-051-18/+12
| | | | | | | | | | | | | | | | | | | | Since #25037, `queue_adapter=` simply delegates to `interpret_adapter` only.
* | | | Merge pull request #31637 from wagenet/patch-1George Claghorn2018-01-041-0/+1
|\ \ \ \ | | | | | | | | | | Add missing require for `strip_heredoc`
| * | | | Add missing require for `strip_heredoc`Peter Wagenet2018-01-041-0/+1
|/ / / /
* | | | Remove passing argument to singular and collection association readersRyuta Kamizono2018-01-051-2/+2
| | | | | | | | | | | | | | | | Follow up of 09cac8c67afdc4b2a1c6ae07931ddc082629b277.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 02:54:28 +0000