| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
|
| |/ / /
|/| | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since https://github.com/puma/puma/pull/1700, the default host is
correctly used. So `localhost` is used instead of `0.0.0.0`.
As a result, the log output on restart is changed, and the restart test
fails on Puma 3.12.1.
https://travis-ci.org/rails/rails/jobs/509239592#L2303-L2305
Specify binding explicitly to avoid being affected by Puma changes.
|
| | |
| | |
| | |
| | |
| | | |
* Show options as list.
* Fix incorrect quoting.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Document option forwarding in ActiveRecord::Base.attribute
|
| |/ /
| | |
| | |
| | |
| | | |
This has been supported for a while but we didn't have documentation
for it.
|
|\ \ \
| | | |
| | | | |
Bulk Insert: Reuse indexes for unique_by
|
| | | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I found `:unique_by` with `:columns` and `:where` inside it tough to
grasp. The documentation only mentioned indexes and partial indexes.
So why duplicate a model's indexes in an insert_all/upsert_all call
when we can just look it up?
This has the added benefit of raising if no index is found, such that
people can't insert thousands of records without relying on an index
of some form.
|
|\ \ \
| |/ /
|/| | |
Validate types assigned to LookupContext#formats=
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This is a developer quality of life improvement, to ensure that unknown
formats aren't assigned (which it would previously accept, but wouldn't
work 100% correctly due to caching).
|
| | |
| | |
| | |
| | |
| | | |
Having a format listed twice had no effect. This is mostly helpful to
avoid an extra format when assigning [:html, "*/*"]
|
| | |
| | |
| | |
| | |
| | | |
This also removes the mutation we were performing on the values being
passed in.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
bogdanvlviv/mention-process_middleware.action_dispatch-in-the-guide
Add mention about `process_middleware.action_dispatch` in the guide [ci skip]
|
| | |/
| |/|
| | |
| | |
| | | |
We added ActiveSupport::Notifications instrumentation of the processing of each middleware in the stack,
See 04ae0b0b5e594e0bb99c5cd608921745977bcdcd.
|
|\ \ \
| |/ /
|/| | |
Make aliases of `database` option in generators work
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Thor automatically adds `-` if aliases do not start with `-`.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L53
But Thor follows a convention of one-dash-one-letter options.
So, even if `-` is added to `db`, it does not work.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L4
Follow up #34021.
|
|\ \
| | |
| | | |
Don't override @set_cookies on CookieJar#update_cookies_from_jar'
|
| | |
| | |
| | |
| | |
| | |
| | | |
When building the cookie_jar for the current test request.
It was possible for this method to override keys currently being set on the test itself.
In situations such as when making two requests mixing creating the cookie on the test and the controller.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
shioyama/generated_attribute_methods_namespaced_constant
Give GeneratedAttributeMethods module a name
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently GeneratedAttributeMethods is a module builder class, an
instance of which is included in every AR class. OTOH,
GeneratedAssociatedMethods is assigned to a constant under the model
namespace. This is inconsistent and looks strange in the list of
ancestors.
There is no particular reason *not* to assign a constant for this (very
important) module under the model namespace, so that's what this commit
does.
Previous to this change, ancestors for an AR class looked like this:
```
=> [User (call 'User.connection' to establish a connection),
User::GeneratedAssociationMethods,
#<ActiveRecord::AttributeMethods::GeneratedAttributeMethods:0x000055ace0f05b08>,
ApplicationRecord(abstract),
ApplicationRecord::GeneratedAssociationMethods,
#<ActiveRecord::AttributeMethods::GeneratedAttributeMethods:0x000055ace093c460>,
ActiveRecord::Base,
...
```
With this change, they look like this:
```
=> [User (call 'User.connection' to establish a connection),
User::GeneratedAssociationMethods,
User::GeneratedAttributeMethods,
ApplicationRecord(abstract),
ApplicationRecord::GeneratedAssociationMethods,
ApplicationRecord::GeneratedAttributeMethods,
ActiveRecord::Base,
...
```
The previously named `GeneratedAttributeMethods` module builder class is
renamed `GeneratedAttributeMethodsBuilder` to emphasize that this is not
a module but a class.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
larouxn/revert-35656-revert-34277-remove-javascripts-javascripts_engine-options-for-generators
Revert "Revert "Remove `javascripts` and `javascript_engine` options for generators""
|
|/ / / /
| | | |
| | | |
| | | | |
generators""
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This test was trying to set the exception_app in the wrapper proxy
instead in the middleware itself.
|
|\ \ \ \
| | | | |
| | | | | |
Re-add Template#updated_at as deprecated
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
larouxn/revert-34277-remove-javascripts-javascripts_engine-options-for-generators
Revert "Remove `javascripts` and `javascript_engine` options for generators"
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove roflscaling
|
| | | | | | |
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
roflscaling (using frozen string constants instead of literal
strings) was added in 2012, before frozen string literals were
added in Ruby 2.3. Now that Rails no longer supports Ruby <2.3,
and all of these files use frozen string literals, there is
no reason to keep the roflscaling.
This does not delete or deprecate the related constants. Such
a change can be made in a later commit.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove virtual_path from fallback templates
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Extract `sanitize_as_sql_comment` from SQL visitor into connection
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
Probably that is useful for any other feature as well.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update regular expression for checking valid MIME type
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
MIME Type validation regular expression does not allow for MIME types initialized with strings that contain parameters after the MIME type name.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Adds ActiveSupport::Notifications instrumentation of the processing of
each middleware in the stack.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add documentation for the resource(s) :param option
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* update_at/on note for ActiveRecord::Relation.update_all
* Verbatim updated_at/on
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Raise exception when building invalid mime type
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This allows mime types in the form text/html, text/*, or */*
This required a few minor test/code changes where previously nil was
used as a mime string.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix for migration active_storage migration
|