| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| | |
| | | |
add `queue_classic` to list of provide `provider_job_id` [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
add headers to payload list [ci skip]
|
| | |
| | |
| | |
| | | |
Follow up to #24115.
|
|\ \ \
| | | |
| | | | |
silence deprecation message for dynamic controller and actions on Action View test
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
View test
Follow up to #23980.
|
|\ \ \
| | | |
| | | | |
Add explanation about accepts_nested_attributes_for keys in the strong parameters docs
|
| |/ /
| | |
| | |
| | | |
parameters documentation [skip ci]
|
|\ \ \
| |/ /
|/| | |
Fix `warning: method redefined; discarding old female`
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
```
$ ARCONN=mysql2 be ruby -w -Itest test/cases/scoping/default_scoping_test.rb
Using mysql2
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: method redefined; discarding old female
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: previous definition of female was here
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: method redefined; discarding old male
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: previous definition of male was here
```
|
|\ \
| | |
| | | |
Fix Gemfile.lock
|
|/ /
| |
| |
| |
| | |
- Resque version was locked to < 1.26 in 92f869a0c85268 but
Gemfile.lock was not updated.
|
|\ \
| | |
| | | |
regenerate application_mailer.rb if it is missing
|
| | | |
|
|/ / |
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
kamipo/case_sensitive_comparison_for_non_string_column
The BINARY Operator is only needed for string columns
|
| | |
| | |
| | |
| | | |
Follow up to #13040.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Right now referencing the constant `AbstractController::Rendering`
causes `ActionView::Base` to be loaded, and thus the load hooks for
action_view are run. If that load hook references any part of action
view that then references action controller (such as
`ActionView::TestCase`), the constant `AbstractController::Rendering`
will attempt to be autoloaded and blow up.
With this change, `ActionView::LoadPaths` no longer requires
`ActionView::Base` (which it had no reason to require). There was a
needed class from `AbstractController::Base` in the Rendering module,
which I've moved into its own file so we don't need to load
all of `AbstractController::Base` there.
This commit fixes
https://github.com/rails/rails-controller-testing/issues/21
|
|\ \ \
| | | |
| | | | |
Clarify has_many :dependent option docs [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Clarifies the documentation here to mean all options are for when the
relation is destroyed; also now reflects the documentation on this same
option found in the has_one section.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There was some subtle breakage caused by #18774, when we removed
`#original_exception` in favor of `#cause`. However, `#cause` is
automatically set by Ruby when raising an exception from a rescue block.
With this change, we will use whichever handler has the highest priority
(whichever call to `rescue_from` came last). In cases where the outer
has lower precidence than the cause, but the outer is what should be
handled, cause will need to be explicitly unset.
Fixes #23925
|
| | | |
| | | |
| | | |
| | | | |
I'm unsure how this passed CI in the pull request.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Default rendering behavior if respond_to collector doesn't have a block.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When a `respond_to` collector doesn't have a response, then a
`:no_content` response should be rendered. This brings the default
rendering behavior introduced by
https://github.com/rails/rails/issues/19036 to controller methods
employing `respond_to`
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Prevent `Marshal.load` from looping infinitely
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix a bug in `Marshal.load` that caused it to loop indefinitely when
trying to autoload a constant that resolved to a different name.
This could occur when marshalling an ActiveRecord 4.0 object (e.g. into
memcached) and then trying to unmarshal it with Rails 4.2. The
marshalled payload contains a reference to
`ActiveRecord::ConnectionAdapters::Mysql2Adapter::Column`, which in
Rails 4.2 resolves to
`ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter::Column`.
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Fix `thread_mattr_accessor` thread-local variable naming
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The current implentation of `thread_mattr_accessor` is setting
differently-named thread variables when defining class and
instance writer methods, so the method isn't working as documented:
Account.user = "DHH"
Account.user # => "DHH"
Account.new.user # => nil
a = Account.new
a.user = "ABC" # => "ABC"
a.class.user # => "DHH"
At this point `:attr_Account_user` and `:attr_Class_user` thread-local
variables have been created. Modify the reader and writer methods to use
the class name instead of 'Class'.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Extract `default_primary_key?` to refactor `column_spec_for_primary_key`
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Dump `bigint` instead of `integer` with `limit: 8` for schema dumper
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Before:
```ruby
create_table "big_numbers", force: :cascade do |t|
t.integer "bigint_column", limit: 8
end
```
After:
```ruby
create_table "big_numbers", force: :cascade do |t|
t.bigint "bigint_column"
end
```
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Passing `table_name` to `Column#initialize` to avoid `instance_variable_set`
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
working
Currently the results of `column.serial?` is not correct. For
`column.serial?` correctly working, initialize `column.table_name`
immediately.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
use `ActiveSupport::Reloader.to_prepare` instead of deprecated `ActionDispatch::Reloader.to_prepare` [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
`ActionDispatch::Reloader.to_prepare` [ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix bigserial appears with limit 8 for schema dumper
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Before:
```ruby
create_table "postgresql_big_serials", force: :cascade do |t|
t.bigserial "seq", limit: 8, null: false
end
```
After:
```ruby
create_table "postgresql_big_serials", force: :cascade do |t|
t.bigserial "seq", null: false
end
```
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Rename dependencies.rake to cache_digests.rake
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
As the tasks are related to cache_digests and
as they are already namespaced under cache_digests,
renaming to cache_digests.rake makes it to know
where to find these tasks.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove unused try require in ActiveSupport::TimeZone
|
| | | | | | | | |
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If we're gonna do this right, it will look mighty different from this anyway.
(Looking at you, Rails 5.1).
It isn't being used in any code as of now, so yanking is the best option.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Version 3.1.11 works on Windows again
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This undoes https://github.com/rails/rails/commit/7241498e51120b9847a8bc16cf48551db0f3e216
https://github.com/codahale/bcrypt-ruby/issues/128 is fixed and closed.
|