Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | include_in_memory? should check against @target list in case of new records. ↵ | Aaron Patterson | 2011-01-12 | 2 | -2/+9 |
| | | | | [#6257 state:resolved] | ||||
* | fixing whitespace errors | Aaron Patterson | 2011-01-12 | 1 | -1/+1 |
| | |||||
* | button_tag should escape it content | Santiago Pastorino | 2011-01-12 | 2 | -1/+8 |
| | |||||
* | Allow generators nested in more than one level | Santiago Pastorino | 2011-01-12 | 2 | -1/+9 |
| | |||||
* | turn off deprecation silencing | Aaron Patterson | 2011-01-12 | 1 | -1/+8 |
| | |||||
* | use array maths rather than *args | Aaron Patterson | 2011-01-12 | 1 | -2/+4 |
| | |||||
* | just use return value of load_target | Aaron Patterson | 2011-01-12 | 1 | -2/+1 |
| | |||||
* | just call methods on return value of `load_target` | Aaron Patterson | 2011-01-12 | 1 | -8/+3 |
| | |||||
* | default return value is nil | Aaron Patterson | 2011-01-12 | 1 | -1/+0 |
| | |||||
* | @loaded is defined in initialize, so we should not need this | Aaron Patterson | 2011-01-12 | 1 | -2/+0 |
| | |||||
* | just use respond_to? and super rather than aliasing around methods | Aaron Patterson | 2011-01-12 | 2 | -5/+4 |
| | |||||
* | fixes a comment in the generated app Gemfile | Xavier Noria | 2011-01-12 | 1 | -1/+1 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | Xavier Noria | 2011-01-12 | 55 | -303/+522 |
|\ | |||||
| * | remove locales external to the system before assertion | Aaron Patterson | 2011-01-12 | 1 | -5/+5 |
| | | |||||
| * | use raise to create exceptions and to set the backtrace | Aaron Patterson | 2011-01-12 | 2 | -2/+2 |
| | | |||||
| * | reraising should be in the rescue block | Aaron Patterson | 2011-01-12 | 1 | -1/+1 |
| | | |||||
| * | Reuse the view_context from the controller, this make the test environment ↵ | Santiago Pastorino | 2011-01-12 | 1 | -4/+1 |
| | | | | | | | | more similar to the code applications uses | ||||
| * | sorry, the CI cannot lie to us anymore | Aaron Patterson | 2011-01-12 | 1 | -1/+1 |
| | | |||||
| * | Fixed various isolated test missing requires within AS. | Josh Kalderimis | 2011-01-12 | 3 | -2/+6 |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | In AS, only inflector/methods is need in proxy_wrappers.rb, as well as date, ↵ | Josh Kalderimis | 2011-01-12 | 4 | -4/+4 |
| | | | | | | | | | | | | date_time, and time conversions.rb. This fixes an issue when requiring json and AS saying that i18n is also required. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | CI should run isolated tests | Santiago Pastorino | 2011-01-12 | 1 | -9/+9 |
| | | |||||
| * | Allow view in AV::TestCase to access it's controller helpers methods | Santiago Pastorino | 2011-01-12 | 2 | -0/+22 |
| | | |||||
| * | adding a test for no method error | Aaron Patterson | 2011-01-11 | 2 | -11/+57 |
| | | |||||
| * | use underlying _read_attribute method rather than causing NoMethodErrors | Aaron Patterson | 2011-01-11 | 2 | -2/+2 |
| | | |||||
| * | kill unused variable warnings | Aaron Patterson | 2011-01-11 | 1 | -1/+1 |
| | | |||||
| * | lazily instantiate AR objects in order to avoid NoMethodErrors | Aaron Patterson | 2011-01-11 | 2 | -17/+24 |
| | | |||||
| * | test_with_polymorphic_and_condition works without the conditions methods in ↵ | Jon Leighton | 2011-01-11 | 1 | -5/+0 |
| | | | | | | | | BelongsToPolymorphicAssociation because the conditions are added straight to the association_scope as of a few days ago | ||||
| * | Support for create_association! for has_one associations | Jon Leighton | 2011-01-11 | 3 | -1/+23 |
| | | |||||
| * | Refactor the code for singular association constructors. This will allow me ↵ | Jon Leighton | 2011-01-11 | 1 | -8/+13 |
| | | | | | | | | to define a create_association! method in a minute. | ||||
| * | It's not necessary to pass the association proxy class around now | Jon Leighton | 2011-01-11 | 1 | -22/+15 |
| | | |||||
| * | Get rid of set_association_target and association_loaded? as the parts of ↵ | Jon Leighton | 2011-01-11 | 5 | -21/+18 |
| | | | | | | | | the code that need that can now just use association_proxy(:name).loaded?/target= | ||||
| * | We can use the association_proxy method directly in HasOneThroughAssociation now | Jon Leighton | 2011-01-11 | 2 | -20/+20 |
| | | |||||
| * | DRY up the code which instantiates the association proxy | Jon Leighton | 2011-01-11 | 5 | -48/+60 |
| | | |||||
| * | find_target can be inherited | Jon Leighton | 2011-01-11 | 1 | -4/+0 |
| | | |||||
| * | Document the recent changes to association assignment | Jon Leighton | 2011-01-11 | 1 | -4/+9 |
| | | |||||
| * | Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵ | Jon Leighton | 2011-01-11 | 2 | -1/+18 |
| | | | | | | | | replaced | ||||
| * | When assigning a has_one, if anything fails, the assignment should be rolled ↵ | Jon Leighton | 2011-01-11 | 2 | -21/+28 |
| | | | | | | | | back entirely | ||||
| * | In a number of places in the tests, we only need to turn off transactional ↵ | Jon Leighton | 2011-01-11 | 9 | -43/+51 |
| | | | | | | | | fixtures when the DB does not support savepoints. This speeds the test run up by about 8-9% on my computer, when running rake test_sqlite3_mem :) | ||||
| * | SQLite3 has supported savepoints since version 3.6.8, we should use this! | Jon Leighton | 2011-01-11 | 2 | -2/+18 |
| | | |||||
| * | When assigning a has_one, if the new record fails to save, raise an error | Jon Leighton | 2011-01-11 | 3 | -19/+19 |
| | | |||||
| * | When assigning a has_one, if the existing record fails to be removed from ↵ | Jon Leighton | 2011-01-11 | 2 | -5/+23 |
| | | | | | | | | the association, raise an error | ||||
| * | Have a separate test connection directory for sqlite3 in-memory so that the ↵ | Jon Leighton | 2011-01-11 | 2 | -1/+1 |
| | | | | | | | | tests can be run without having to specifically rename the connection file (which then causes git to pick up the changes) | ||||
| * | Enable the sqlite3 in-memory test connection to work | Jon Leighton | 2011-01-11 | 5 | -17/+25 |
| | | |||||
| * | has_one should always remove the old record (properly), even if not saving ↵ | Jon Leighton | 2011-01-11 | 4 | -11/+31 |
| | | | | | | | | the new record, so we don't get the database into a pickle | ||||
| * | Return value is irrelevant here as the RHS of the assignment is always ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+0 |
| | | | | | | | | returned by methods ending in '=' | ||||
| * | Remove incorrect documentation about build_assoc on has_one. This is proven, ↵ | Jon Leighton | 2011-01-11 | 1 | -2/+1 |
| | | | | | | | | for example, by test_successful_build_association in has_one_associations_test.rb | ||||
| * | For a singular association, it should be build_association, rather than ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+1 |
| | | | | | | | | association.build (as association may be nil) | ||||
| * | Correctly indent the bullet points under 'One-to-one associations', so that ↵ | Jon Leighton | 2011-01-11 | 1 | -10/+10 |
| | | | | | | | | the lines are not broken in the generated rdoc html | ||||
| * | avoid splatting arrays by using concat | Aaron Patterson | 2011-01-11 | 1 | -3/+3 |
| | | |||||
| * | html_safe.to_str makes no sense | Santiago Pastorino | 2011-01-11 | 1 | -1/+1 |
| | |