Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge remote-tracking branch 'origin/master' | Aaron Patterson | 2013-10-27 | 5 | -12/+21 |
|\ | | | | | | | | | | | | | | | * origin/master: Removal of javascript related gems when creating an app Conflicts: railties/lib/rails/generators/app_base.rb | ||||
| * | Merge pull request #12657 from robin850/skip-javascript | Guillermo Iguaran | 2013-10-27 | 5 | -14/+21 |
| |\ | | | | | | | Removal of javascript related files when creating an app | ||||
| | * | Removal of javascript related gems when creating an app | Robin Dupret | 2013-10-27 | 5 | -14/+21 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 0417bc8 add the coffee-rails and javascript runtime gems even when passing the --skip-javascript option but this is not the desired behavior. Also remove all javascript related stuff in the generated application such as the vendor/assets/javascripts folder. | ||||
* | | | add an option to skip jbuilder | Aaron Patterson | 2013-10-27 | 1 | -0/+4 |
| | | | |||||
* | | | fix variable name | Aaron Patterson | 2013-10-27 | 2 | -3/+3 |
| | | | |||||
* | | | add jbuilder web-console and sdoc to the GemEntry list | Aaron Patterson | 2013-10-27 | 3 | -29/+33 |
| | | | |||||
* | | | fix the class name | Aaron Patterson | 2013-10-27 | 1 | -17/+17 |
| | | | |||||
* | | | refactor Gemfile template | Aaron Patterson | 2013-10-27 | 1 | -8/+6 |
| | | | |||||
* | | | use the GemfileGem object for more entries | Aaron Patterson | 2013-10-27 | 3 | -56/+53 |
| | | | |||||
* | | | add the database gem | Aaron Patterson | 2013-10-27 | 3 | -9/+8 |
| | | | |||||
* | | | get a list of gems when filling out the gemfile | Aaron Patterson | 2013-10-27 | 3 | -13/+42 |
|/ / | |||||
* | | set accessors in the set_accessors! method | Aaron Patterson | 2013-10-27 | 2 | -2/+2 |
| | | |||||
* | | Merge pull request #12661 from robin850/patch-10 | Rafael Mendonça França | 2013-10-27 | 1 | -0/+8 |
|\ \ | | | | | | | Add a changelog entry for #12656 [ci skip] | ||||
| * | | Add a changelog entry for #12656 [ci skip] | Robin Dupret | 2013-10-27 | 1 | -0/+8 |
| | | | |||||
* | | | Add a note about ensuring the version is right for the adapter (since you ↵ | David Heinemeier Hansson | 2013-10-27 | 1 | -1/+1 |
|/ / | | | | | | | might well have specified the right gem, but locked it to too low of a version) | ||||
* | | Merge pull request #12656 from dougcole/fix_strong_parameters_fetch | Guillermo Iguaran | 2013-10-26 | 2 | -1/+14 |
|\ \ | | | | | | | don't let StrongParameters mutate the hash with fetch | ||||
| * | | don't mutate hash with fetch | Doug Cole | 2013-10-26 | 2 | -1/+14 |
|/ / | |||||
* | | Merge pull request #12655 from ↵ | Santiago Pastorino | 2013-10-26 | 1 | -2/+5 |
|\ \ | | | | | | | | | | | | | rails/ps-remove-surprise-if-in-show-exception-middleware Remove surprise if from show_exception middleware | ||||
| * | | Remove surprise if from show_exception middleware | Prem Sichanugrist | 2013-10-27 | 1 | -2/+5 |
|/ / | | | | | This increase the readability within the rescue block. | ||||
* | | Merge pull request #12648 from chrisledet/patch-1 | Rafael Mendonça França | 2013-10-25 | 1 | -2/+2 |
|\ \ | | | | | | | Fixed typo with after_commit docs | ||||
| * | | Fixed typo with after_commit docs | Chris Ledet | 2013-10-25 | 1 | -2/+2 |
|/ / | | | | | Fixed syntax error on `after_commit` docs | ||||
* | | Merge pull request #12643 from severin/pg_cast_json_on_write | Yves Senn | 2013-10-25 | 3 | -0/+26 |
|\ \ | | | | | | | cast json values on write to be consistent with reading from the db. | ||||
| * | | cast json values on write to be consistent with reading from the db. | Severin Schoepke | 2013-10-25 | 3 | -0/+26 |
| | | | | | | | | | | | | See also commit 5ac2341fab689344991b2a4817bd2bc8b3edac9d | ||||
* | | | prevent `time_zone_aware_attributes` test leak. follow-up to #12633. | Yves Senn | 2013-10-25 | 1 | -21/+21 |
| | | | |||||
* | | | only warn on leaked time zone state instead of rasing an error. | Yves Senn | 2013-10-25 | 1 | -3/+6 |
| | | | | | | | | | | | | | | | | | | Raising `RuntimeErrors` skips important cleanup code and leads to a lot of subsequent errors. This clutters the test output with a lot of noise. | ||||
* | | | Merge pull request #12633 from senny/no_more_time_zone_leaks | Yves Senn | 2013-10-25 | 12 | -214/+223 |
|\ \ \ | |/ / |/| | | prevent global timezone state from leaking out of test cases. | ||||
| * | | prevent global timezone state from leaking out of test cases. | Yves Senn | 2013-10-25 | 12 | -214/+223 |
| | | | |||||
* | | | Merge pull request #12642 from ka8725/fix_usage_for_model_generators | Rafael Mendonça França | 2013-10-25 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Improve usage example for model generator decimal field | ||||
| * | | | Improve usage example for model generator | Andrey Koleshko | 2013-10-25 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #12641 from ↵ | Rafael Mendonça França | 2013-10-25 | 1 | -2/+2 |
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | jetthoughts/12640_updated_migrations_doc_to_use_remove_column Fix migration docs to use new remove_column semantics | ||||
| * | | | Fix migration docs to use new remove_column semantics | Paul Nikitochkin | 2013-10-25 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | Fixes: #12640 | ||||
* | | | | Merge pull request #12490 from senny/store_accessor_hstore_bug | Yves Senn | 2013-10-24 | 8 | -14/+127 |
|\ \ \ \ | | | | | | | | | | | ActiveRecord Store works with PG `hstore` columns | ||||
| * | | | | `ActiveRecord::Store` works together with PG `hstore` columns. | Yves Senn | 2013-10-25 | 6 | -14/+88 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is necessary because as of 5ac2341 `hstore` columns are always stored as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to be an instance of `HashWithIndifferentAccess`, which led to the bug. | ||||
| * | | | | `stored_attributes` need to be specific to a subclass. | Yves Senn | 2013-10-25 | 3 | -0/+21 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently they are all stored globally in the same `Hash`. This commit forces the creation of a per-class variable if necessary. The behavior was exposed through the following test-case: ``` 1) Failure: StoreTest#test_all_stored_attributes_are_returned [/Users/senny/Projects/rails/activerecord/test/cases/store_test.rb:151]: --- expected +++ actual @@ -1 +1 @@ -[:color, :homepage, :favorite_food] +[:resolution, :color, :homepage, :favorite_food] ``` | ||||
| * | | | | test to verify the `ActiveRecord::Store` behavior with PG's json type | Yves Senn | 2013-10-25 | 1 | -0/+18 |
|/ / / / | |||||
* | | | | Merge pull request #12621 from ↵ | Rafael Mendonça França | 2013-10-24 | 3 | -1/+24 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | laurocaetano/fix_has_one_association_with_primary_key_set Save association when primary key is manually set Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | | Save association when primary key is manually set | laurocaetano | 2013-10-24 | 3 | -1/+24 |
| | | | | | |||||
* | | | | | Merge pull request #12636 from kongregate/dont_rescue_Exceptions | Rafael Mendonça França | 2013-10-24 | 1 | -2/+2 |
|\ \ \ \ \ | | | | | | | | | | | | | Avoid unnecessary catching of Exception instead of StandardError (conver... | ||||
| * | | | | | Avoid unnecessary catching of Exception instead of StandardError (converting ↵ | stopdropandrew | 2013-10-24 | 1 | -2/+2 |
| | |_|/ / | |/| | | | | | | | | | | | | | Exceptions into StandardErrors) | ||||
* | | | | | Improve the test code for #8422 | Rafael Mendonça França | 2013-10-24 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Remove unneeded comments. * Use key? instead of keys.include?. | ||||
* | | | | | Merge pull request #8491 from igagnidz/master | Rafael Mendonça França | 2013-10-24 | 1 | -0/+10 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | Issue #8442 | ||||
| * | | | | | Added test to ensure that DescendantsTracker does not leak memory on ↵ | Iuri Gagnidze | 2012-12-09 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | singleton classes | ||||
* | | | | | | Merge pull request #12632 from al2o3cr/fix_race_for_attribute_methods | Aaron Patterson | 2013-10-24 | 1 | -6/+3 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Always check to see if methods exist after calling define_attribute_methods | ||||
| * | | | | | | always check to see if methods exist after calling define_attribute_methods | Matt Jones | 2013-10-24 | 1 | -6/+3 |
| | |/ / / / | |/| | | | | |||||
* | | | | | | Add CHANGELOG entry for #12635 [ci skip] | Rafael Mendonça França | 2013-10-24 | 1 | -0/+4 |
| | | | | | | |||||
* | | | | | | Merge pull request #12635 from mperham/4-0-stable | Guillermo Iguaran | 2013-10-24 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | Allow any version of BCrypt | ||||
* | | | | | | Merge pull request #10471 from andyw8/button_to_params | Rafael Mendonça França | 2013-10-24 | 3 | -0/+19 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add params option for button_to Conflicts: actionpack/CHANGELOG.md | ||||
| * | | | | | | Add params option for button_to | Andy Waite | 2013-09-18 | 3 | -0/+19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The parameters are rendered as hidden form fields within the generated form. This is useful for when a record has multiple buttons associated with it, each of which target the same controller method, but which need to submit different attributes. | ||||
* | | | | | | | Merge pull request #12611 from antonio/slice_bang_honor_default_proc | Rafael Mendonça França | 2013-10-24 | 3 | -0/+24 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Make slice! honor default hash value/proc | ||||
| * | | | | | | | slice! should not remove default hash value/proc | Antonio Santos | 2013-10-24 | 3 | -0/+24 |
| | |_|_|_|/ / | |/| | | | | |