| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
We are using compare_without_coercion.
|
|\
| |
| |
| | |
extension synonyms yml and yaml
|
| | |
|
|\ \
| | |
| | | |
Generate `cable.js` file if does not exist when generating channel
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Before this, while generating a channel, we were not creating
`cable.js` if it does not already exist.
- We have similar code for application mailer here -
https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4.
- Based on the comment -
https://github.com/rails/rails/issues/24418#issuecomment-205421995.
|
|\ \ \
| | | |
| | | | |
prevent 'attribute_changed?' from returning nil
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Lesser '.' objects for number helpers
|
| | | |
| | | |
| | | |
| | | | |
do the same string manipulation. This was we avoid the duplicate strings with freeze and append modifies existing string
|
| | | |
| | | |
| | | |
| | | | |
iteration of calling the helper. Eases on some memory bloat
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Note that the fact that mtimes in the future are ignore was documented
just a few lines above. Since we know this has to be done, and the code
is quite clear due to variable naming, I think we can get rid of the
comment in the middle of the loop and shorten it even further.
|
|\ \ \ \
| | | | |
| | | | | |
Guides changelog pass [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
https://github.com/rails/rails/pull/23176
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Made all sentences to end properly
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Handle max_time edge cases for epoch times and add test
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In 04ac5655be91f49cd4dfe2838df96213502fb274 I assumed that we would
never want to pass the "table_name.column_name" form to where with a
symbol. However, in Ruby 2.2 and later, you can quote symbols using the
new hash syntax, so it's a semi-reasonable thing to do if we want to
support the dot notation (which I'd rather deprecate, but that would be
too painful of a migration).
Instead we've changed the definition of "this is a table name with a
dot" to when the value associated is a hash. It would make very little
sense to write `where("table_name.column_name": { foo: :bar })` in any
scenario (other than equality for a JSON column which we don't support
through `where` in this way).
Close #24514.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | |
| | | | | |
BlakeMesdag/activesupport-fileupdate-checker-mtime-optimization
Use a single loop in ActiveSupport:FileUpdateChecker#max_mtime
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
ActiveSupport::FileUpdateChecker#max_mtime
|
|\ \ \ \
| | | | |
| | | | | |
Railties CHANGELOG Pass [ci skip]
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Added missing config to complete config names
- Fixed route generators changelog grammar.
- rake:stats => rake stats
- Fixed grammar of assert_file change
- Make sure we end all sentences
[ci skip]
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
prathamesh-sonpatki/add-config-to-deprecation-warning
Add `config` to the deprecation warnings of deprecated config options
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
speed up ActiveModel::Dirty#attribute_changed?
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Benchmark results:
Warming up --------------------------------------
old code 32.176k i/100ms
new code 34.837k i/100ms
Calculating -------------------------------------
old code 1.595M (± 3.5%) i/s - 7.947M
new code 1.942M (± 3.9%) i/s - 9.685M
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Encourage best practice in the HTTP Token authentication example code
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`authenticate` method, to use the `secure_compare` method with two constant-length strings. This defends against timing attacks, and is best practice. Using `==` for sensitive actions is not recommended, and this was the source of a CVE fixed in October 2015: https://github.com/rails/rails/commit/17e6f1507b7f2c2a883c180f4f9548445d6dfbda
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Clean up all Rails 5 warnings. Revert auto-added periods.
|
| | |_|_|/ / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- we are ending sentences properly
- fixing of space issues
- fixed continuity issues in some sentences.
Reverts https://github.com/rails/rails/commit/8fc97d198ef31c1d7a4b9b849b96fc08a667fb02 .
This change reverts making sure we add '.' at end of deprecation sentences.
This is to keep sentences within Rails itself consistent and with a '.' at the end.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Improved ActionView flows.rb documention [ci skip]
|
|/ / / / / / / |
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The pass touches a few minor things.
One important aspect is that the wording treats "railtie" as a
regular noun. This is so because Railtie is a constant and
generally the text refers to "classes that act as railties",
which is different.
Railties are so fundamental in Rails that deserve a noun,
like engine, class, array, application, etc. They have a
meaning per se, beyond constants.
Also, make clear an extension's railtie does not need to
be called "Railtie" or have "Railtie" in their class name.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Idiomatically trailing hashes in method calls do not use
explicit curlies.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
prathamesh-sonpatki/protected_database_env_message
Cleanup message shown while running destructive action against protected database
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
database.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Pass over AM changelog [ci skip]
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Fixed statement about setting `config.action_mailer.default_url_options = {protocol: 'https'}` . We are just setting the protocol key to 'https', not replacing/initializing the complete config.
- Fixed grammar in assert_emails changlog
- Added sentence separator for code ":"
[ci skip]
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | | |
Rake includes (an extended version of) FileUtils in tasks.
It is more idiomatic that they use this provided interface.
|
| |_|_|/ /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
With the exception of what is loaded in active_support/rails,
each file is responsible for its own dependencies. You cannot
rely on runtime order of execution.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Update ActionMailer Mailer Models and Views documentation [ci skip]
|
| | |/ /
| |/| | |
|
|\ \ \ \
| |_|/ /
|/| | | |
do not create unnecessary directory
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
This was added in a4c358f, but `config.assets` has been removed in 5172d93.
Also, do not use env path to `Sprockets::Cache::FileStore` even `sprockets-rails`.
ref: https://github.com/rails/sprockets-rails/blob/master/lib/sprockets/railtie.rb#L129
|
|\ \ \
| | | |
| | | | |
fix typo in file path [ci skip]
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
Check for protected environments before trying to load structure.sql file
|