Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Move CHANGELOG.md entry from Active Support to Action Pack | Jon Moss | 2017-04-11 | 2 | -13/+13 |
| | | | | | | | Was looking through #28402, and realized the CHANGELOG.md entry is in the wrong place. Sorry we didn't catch this during code review :cry: [ci skip] | ||||
* | :scissors: | Rafael Mendonça França | 2017-04-11 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | Merge pull request #28731 from y-yagi/fix_rubocop_violations | Rafael França | 2017-04-11 | 2 | -2/+2 |
|\ | | | | | Fix rubocop violations | ||||
| * | Fix rubocop violations | yuuji.yaginuma | 2017-04-12 | 2 | -2/+2 |
|/ | |||||
* | Merge pull request #28402 from jules2689/action-controller-api-base-hooks | Rafael França | 2017-04-11 | 4 | -1/+127 |
|\ | | | | | Add `action_controller_base` and `action_controller_api` hooks to mitigate differences between them. Also document Active Support on_load hooks | ||||
| * | Add Documentation for Active Support On Load Hooks | Julian Nadeau | 2017-04-10 | 1 | -0/+112 |
| | | |||||
| * | Add action_controller_api, action_controller_base on_load hook | Julian Nadeau | 2017-04-10 | 3 | -1/+15 |
| | | |||||
* | | Merge pull request #28729 from matthewd/dont-freeze-inputs | Matthew Draper | 2017-04-12 | 2 | -3/+17 |
|\ \ | | | | | | | Don't freeze input strings | ||||
| * | | Don't freeze input strings | Matthew Draper | 2017-04-12 | 2 | -3/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | See 34321e4a433bb7eef48fd743286601403f8f7d82 for background on ImmutableString vs String. Our String type cannot delegate typecasting to ImmutableString, because the latter freezes its input: duplicating the value after that gives us an unfrozen result, but still mutates the originally passed object. | ||||
* | | | Merge pull request #28722 from DmytroVasin/rails-ujs-default-url | Rafael França | 2017-04-11 | 2 | -22/+46 |
|\ \ \ | | | | | | | | | rails-ujs: missing default url for ajax requests. | ||||
| * | | | Set current page as default for ajax requests | Dmytro Vasin | 2017-04-11 | 2 | -22/+46 |
| | | | | |||||
* | | | | Merge pull request #28728 from dskecse/update-documentation-on-routing | Rafael França | 2017-04-11 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | Update routing doc on the `get` `to:` option [ci skip] | ||||
| * | | | | Update routing doc on the `get` `to:` option [ci skip] | Dzianis Dashkevich | 2017-04-11 | 1 | -2/+2 |
| | |_|/ | |/| | | |||||
* | | | | Merge pull request #28721 from koic/oracle_does_not_support_limit_clause | Rafael França | 2017-04-11 | 1 | -1/+1 |
|\ \ \ \ | |/ / / |/| | | | Fix an AR test of relations_test when using Oracle | ||||
| * | | | Fix an AR test of relations_test when using Oracle | Koichi ITO | 2017-04-11 | 1 | -1/+1 |
| | | | | |||||
* | | | | Remove link to rack.github.io | Jon Moss | 2017-04-10 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | We mention the "resources" section of the guide in the next paragraph, and the link is listed there. IMHO we shouldn't list it twice. [ci skip] | ||||
* | | | | Small grammar fixes | Jon Moss | 2017-04-10 | 1 | -3/+6 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | Pluralize callback | Jon Moss | 2017-04-10 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | Users could have more than one `before_destroy` callback in their models. [ci skip] | ||||
* | | | | Merge pull request #28680 from vishalzambre/callback_doc_update | Jon Moss | 2017-04-10 | 1 | -0/+2 |
|\ \ \ \ | |_|/ / |/| | | | Documented issue related before_destroy with dependent: :destroy | ||||
| * | | | [ci skip] documented issue related before_destroy | vishalzambre | 2017-04-10 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | Updated text | ||||
* | | | | Implement `fetch_values` for HashWithIndifferentAccess (#28316) | Josh Pencheon | 2017-04-10 | 3 | -0/+31 |
| |_|/ |/| | | | | | | | | | | | | | | | | | `fetch_values` was added to Hash in Ruby 2.3.0: https://bugs.ruby-lang.org/issues/10017 This patch adds an implemention for instances of HWAI, in line with the existing definitions of `fetch` and `values_at`. | ||||
* | | | exclude ORDER BY clause for exists? (#28699) | Boris Slobodin | 2017-04-10 | 2 | -1/+6 |
| |/ |/| | |||||
* | | Merge pull request #28713 from kamipo/expose_queries_for_association_queries | Matthew Draper | 2017-04-10 | 2 | -48/+44 |
|\ \ | | | | | | | Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue` | ||||
| * | | Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue` | Ryuta Kamizono | 2017-04-09 | 2 | -21/+25 |
| | | | |||||
| * | | Avoid to handle polymorphic association for `AssociationQueryHandler` | Ryuta Kamizono | 2017-03-28 | 2 | -29/+21 |
| | | | | | | | | | | | | It should be handled by `PolymorphicArrayHandler` if polymorphic association. | ||||
* | | | delegate_missing_to should fall back to super | Matthew Draper | 2017-04-09 | 2 | -1/+23 |
| | | | |||||
* | | | delegate_to_missing doesn't delegate private methods | Matthew Draper | 2017-04-09 | 2 | -1/+14 |
| | | | | | | | | | | | | So we shouldn't claim they're there, even when asked explicitly. | ||||
* | | | Merge pull request #28697 from ↵ | Kasper Timm Hansen | 2017-04-09 | 1 | -1/+0 |
|\ \ \ | | | | | | | | | | | | | | | | | y-yagi/remove_duplicated_delivery_method_definition Remove duplicated `delivery_method` definition | ||||
| * | | | Remove duplicated `delivery_method` definition | yuuji.yaginuma | 2017-04-07 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | `ActionMailer::Base.delivery_method` is already defined in https://github.com/rails/rails/blob/master/actionmailer/test/parameterized_test.rb#L13 | ||||
* | | | | Add text to "Upgrading to Rails 5.1" | Jon Moss | 2017-04-08 | 1 | -1/+8 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | Add scaffolding for different sections in 5.1 release notes | Jon Moss | 2017-04-08 | 1 | -0/+48 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | Merge pull request #28678 from hedgesky/use_formatted_number_as_schema_version | Rafael França | 2017-04-08 | 1 | -1/+9 |
|\ \ \ \ | | | | | | | | | | | use formatted number as schema version | ||||
| * | | | | use formatted number as schema version | Anton Chuchkalov | 2017-04-05 | 1 | -1/+9 |
| | | | | | |||||
* | | | | | Merge pull request #28705 from kamipo/extract_construct_relation_for_exists | Rafael França | 2017-04-08 | 2 | -17/+33 |
|\ \ \ \ \ | | | | | | | | | | | | | Extract `construct_relation_for_exists` in `FinderMethods` | ||||
| * | | | | | Extract `construct_relation_for_exists` in `FinderMethods` | Ryuta Kamizono | 2017-04-09 | 1 | -12/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | To ease to customize a relation for `exists?`. | ||||
| * | | | | | More exercise `exists?` tests | Ryuta Kamizono | 2017-04-08 | 1 | -5/+18 |
| | | | | | | |||||
* | | | | | | Drop the "Sanity Check" contributing step | Matthew Draper | 2017-04-09 | 1 | -10/+0 |
| | | | | | | |||||
* | | | | | | Remove mentions and instructions for docrails | Matthew Draper | 2017-04-09 | 2 | -18/+2 |
|/ / / / / | | | | | | | | | | | | | | | | It's been retired; all contributions now come in via PRs. | ||||
* | | | | | Merge pull request #28692 from kmcphillips/master | Rafael França | 2017-04-07 | 3 | -4/+49 |
|\ \ \ \ \ | | | | | | | | | | | | | Calling fixture accessor method with no arguments returns all fixtures rather than empty array | ||||
| * | | | | | Passing in no arguments to the dynamic fixture accessor method returns all ↵ | Kevin McPhillips | 2017-04-07 | 3 | -4/+49 |
| | | | | | | | | | | | | | | | | | | | | | | | | fixtures, not an empty array. | ||||
* | | | | | | Spaces | Rafael Mendonça França | 2017-04-07 | 1 | -0/+1 |
| | | | | | | |||||
* | | | | | | More :scissors: | Rafael Mendonça França | 2017-04-07 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | :scissors: | Rafael França | 2017-04-07 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Fix Guides to include #23138 [ci skip] | claudiob | 2017-04-07 | 1 | -8/+1 |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A long-standing bug has been fixed in Rails 5.1 by @pixeltrix See https://github.com/rails/rails/blame/5-1-stable/actionpack/CHANGELOG.md#L52-L64 This PR updates the guides accordingly. Before: <img width="799" alt="before" src="https://cloud.githubusercontent.com/assets/10076/24809105/4ec7066c-1b73-11e7-98c6-c709c3465306.png"> After: <img width="799" alt="after" src="https://cloud.githubusercontent.com/assets/10076/24809109/50b21188-1b73-11e7-8a1a-32c3d0ed512a.png"> | ||||
* | | | | | Merge pull request #28670 from aledalgrande/activerecord-docs-fix | Rafael França | 2017-04-07 | 1 | -1/+5 |
|\ \ \ \ \ | | | | | | | | | | | | | Fix edge guides for Active Record callbacks | ||||
| * | | | | | Fix edge guides for Active Record callbacks | Alessandro Dal Grande | 2017-04-04 | 1 | -1/+5 |
| | | | | | | |||||
* | | | | | | Merge pull request #28632 from ↵ | Rafael França | 2017-04-07 | 1 | -4/+4 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_warning_extra_states_are_no_longer_copied Fix `warning: extra states are no longer copied` | ||||
| * | | | | | | Fix `warning: extra states are no longer copied` | Ryuta Kamizono | 2017-04-01 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `messages` has `default_proc` so calling `reject` causes the warning. https://github.com/ruby/ruby/blob/v2_4_1/hash.c#L1335-L1337 | ||||
* | | | | | | | Merge pull request #28687 from kamipo/fix_warning_already_initialized_constant | Rafael França | 2017-04-06 | 1 | -1/+0 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Fix `warning: already initialized constant HashWithIndifferentAccessTest::HashWithIndifferentAccess` | ||||
| * | | | | | | | Fix `warning: already initialized constant ↵ | Ryuta Kamizono | 2017-04-07 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HashWithIndifferentAccessTest::HashWithIndifferentAccess` Caused since #28607. |