aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | Simplify building options hash in rename column method for mysqlCarlos Antonio da Silva2014-05-041-5/+6
| | | | | | | |
* | | | | | | | Get rid of conditional since column_for handles raising nowCarlos Antonio da Silva2014-05-041-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | column_for will raise in case column is not found for the given table, so there is no need to handle that here.
* | | | | | | | Simplify unless conditional with ORCarlos Antonio da Silva2014-05-041-4/+2
| | | | | | | |
* | | | | | | | Convert column name to string only onceCarlos Antonio da Silva2014-05-041-1/+2
| | | | | | | |
* | | | | | | | Rails One Click is not maintained anymore [ci skip]Robin Dupret2014-05-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Let's tell people that they should rely on Tokaido instead of Rails One Click. Fixes #14960.
* | | | | | | | Merge pull request #14923 from gaurish/document-testcase-processYves Senn2014-05-041-0/+27
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Document ActionController::TestCase::Behavior#process [ci skip]
| * | | | | | | | Document ActionController::TestCase::Behavior#processGaurish Sharma2014-05-041-0/+27
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | refactor, move `column_for` to `AbstractAdapter` for better reuse.Yves Senn2014-05-044-17/+11
| | | | | | | |
* | | | | | | | Merge pull request #14966 from ↵Yves Senn2014-05-045-21/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tgxworld/remove_unnecessary_setting_of_controller_name Remove tests method for test cases when controller can be inferred.
| * | | | | | | | Remove tests method for test cases when controller can be inferred.Guo Xiang2014-05-035-21/+1
| | | | | | | | |
* | | | | | | | | Merge pull request #14959 from akshay-vishnoi/doc_changesRobin Dupret2014-05-041-4/+5
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Typo, grammar and textual changes [ci skip]
| * | | | | | | | Typo, grammar and textual changes [ci skip]Akshay Vishnoi2014-05-031-4/+5
| | | | | | | | |
* | | | | | | | | Revert "Merge pull request #14940 from arunagw/hbakhtiyor-test-db-namespaces-ar"Yves Senn2014-05-034-114/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit fe9859600824268ff614cb3eb48b62c7165a1fbd, reversing changes made to add9560643ef79830febf47fa1228752d1df3502.
* | | | | | | | | Merge pull request #14940 from arunagw/hbakhtiyor-test-db-namespaces-arYves Senn2014-05-034-102/+114
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | Reorganize ActiveRecord's rake tasks
| * | | | | | | | Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]Arun Agrawal2014-05-034-102/+114
| | | | | | | | |
* | | | | | | | | Remove duplicated fixture additionCarlos Antonio da Silva2014-05-031-1/+1
| | | | | | | | |
* | | | | | | | | Refactor test to not care about the specific result of valid?Carlos Antonio da Silva2014-05-031-3/+4
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only care about its truthiness rather than asserting specific true/false values. If we need to check for the return value in particular, there will be a test for that.
* | | | | | | | Merge pull request #14952 from gregmolnar/schema_loadYves Senn2014-05-031-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | make `db:structure:load` listed with `rake -T`
| * | | | | | | | make `db:structure:load` listed with `rake -T`Greg Molnar2014-05-021-1/+1
| | | | | | | | |
* | | | | | | | | docs, restructure newly added part to `includes`. [ci skip]Yves Senn2014-05-031-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to #14139. /cc @carlosantoniodasilva
* | | | | | | | | Merge pull request #14924 from eric-chahin/issue_13854Matthew Draper2014-05-035-1/+31
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed custom validation context bug for child associations
| * | | | | | | | | Fixed custom validation context bug where childEric Chahin2014-05-015-1/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | associations were not being saved. Fixes #13854. [Eric Chahin, Aaron Nelson, & Kevin Casey]
* | | | | | | | | | Merge pull request #14956 from akshay-vishnoi/refactorAaron Patterson2014-05-021-1/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Use #include? instead of #any?, make it simpler
| * | | | | | | | | | Use #include? instead of #any?, make it simplerAkshay Vishnoi2014-05-031-1/+1
| | |_|/ / / / / / / | |/| | | | | | | |
* | | | | | | | | | Merge pull request #14957 from akshay-vishnoi/test-casesRafael Mendonça França2014-05-031-1/+1
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | Test typecasting on instance rather than class itself
| * | | | | | | | | Test typecasting on instance rather than class itselfAkshay Vishnoi2014-05-031-1/+1
|/ / / / / / / / /
* | | | | | | | | Add missing require to fix test :bomb:Carlos Antonio da Silva2014-05-021-0/+1
| | | | | | | | |
* | | | | | | | | Add branch to arel on Gemfile to allow local bundle config [ci skip]Carlos Antonio da Silva2014-05-021-1/+1
| | | | | | | | |
* | | | | | | | | Move dup destroyed test to specific file that tests dup logicCarlos Antonio da Silva2014-05-022-9/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also change other related test to use existing record rather than creating new one.
* | | | | | | | | passing a nil in the polymorphic array is not supported. remove nils before ↵Aaron Patterson2014-05-022-4/+8
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | you call the method
* | | | | | | | push up bind params on "simple" subquery calculationsAaron Patterson2014-05-022-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bind parameters we not being propogated to simple subquery calculation calls. This fixes it
* | | | | | | | passing a nil should always raise an ArgumentErrorAaron Patterson2014-05-022-1/+25
| | | | | | | |
* | | | | | | | eliminate repetition in guide links for past releases [ci skip]Vijay Dev2014-05-021-10/+1
| | | | | | | |
* | | | | | | | Merge pull request #14943 from ↵Rafael Mendonça França2014-05-023-6/+28
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | arunagw/hbakhtiyor-i18n-validation-message-singular-and-plural Add singular and plural form for some validation messages
| * | | | | | | Add singular and plural form for some validation messagesAbd ar-Rahman Hamidi2014-05-023-6/+28
| | | | | | | |
* | | | | | | | Merge pull request #14942 from JuanitoFatas/patch/cc-by-sa-4-0Rafael Mendonça França2014-05-021-1/+1
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | [ci skip] Update guides license to CC BY-SA 4.0 International.
| * | | | | | | [ci skip] Update guides license to CC BY-SA 4.0 International.Juanito Fatas2014-05-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Benefits: https://creativecommons.org/version4
* | | | | | | | Merge pull request #14941 from ↵Rafael Mendonça França2014-05-025-3/+65
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | arunagw/hbakhtiyor-new-plugin-command-advanced-config Plugin gemspec
| * | | | | | | | skip-git should not hit git commands plugin generatorsArun Agrawal2014-05-023-14/+38
| | | | | | | | |
| * | | | | | | | Works correctly if git not installedRoman Shmatov2014-05-022-8/+30
| | | | | | | | |
| * | | | | | | | Automaticly add username and email if configured in git-scm, as bundle gemAbd ar-Rahman Hamidi2014-05-023-3/+19
| | |/ / / / / / | |/| | | | | |
* / | | | | | | Tiny follow up to #14915 [ci skip]Robin Dupret2014-05-021-19/+18
|/ / / / / / /
* / / / / / / Added link for 4.1 guides on edge guide [ci skip]Arun Agrawal2014-05-021-0/+3
|/ / / / / /
* | | | | | Follow up to 38ad5438 [ci skip]Robin Dupret2014-05-021-27/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds new lines between titles, paragraphs and code blocks for an easier reading. Moreover, in order to be consistent with the other guides, let's remove the sharps on the right side of the different titles. The "Running a Single Test" part was also explained after the "Testing Active Record" one which shows how to run a single test under the scope of a specific adapter. Finally, let's explain the `-n` option to run a specific test method.
* | | | | | Enhance a bit a few changelog entries [ci skip]Robin Dupret2014-05-023-9/+10
| | | | | |
* | | | | | Merge pull request #14939 from jonatack/patch-8Damien Mathieu2014-05-021-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Form_tag_helper grammar fix [skip ci]
| * | | | | | Form_tag_helper grammar fix [skip ci]Jon Atack2014-05-021-1/+1
|/ / / / / /
* | | | | | only add the optiosn if they are not emptyAaron Patterson2014-05-011-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think this is wrong, but it gets the build passing for now. We should always add options, but we need to make more guarantees about how the underlying url helper is called
* | | | | | always pass options to the _url methodAaron Patterson2014-05-012-6/+14
| | | | | |
* | | | | | never merge url options in to the first data hashAaron Patterson2014-05-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if you want options, don't mix them with the first hash, just pass them all in with the second hash