| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
warning: `*' interpreted as argument prefix
|
| |\
| |
| | |
Editorial pass over generated Gemfile
|
| |/
|
|
|
|
| |
* When run with default options, no repeated blank lines
* Every gem has a comment, perhaps a generic one, but a comment nonetheless
* Most comments used to start with "Use", some with "To use" => made consistent
|
| |\
| |
| |
| |
| |
| |
| | |
Statement cache
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
|
| |\ \
| | |
| | | |
Simple improvements
|
| | | | |
|
| | | | |
|
| | | | |
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 9bf1a0db4acbbf9e8e6f707250269185224e7efe, reversing
changes made to fed97091b9546d369a240d10b184793d49247dd3.
Conflicts:
activerecord/test/cases/transaction_callbacks_test.rb
Reason: This fix introduces another issue described at #8937, so we are
reverting it to restore the behavior of 3-2-stable.
We will fix both issues when we come out with a better solution
|
| |\ \
| | |
| | | |
While merging relations preserve context for joins
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes #3002. Also see #5494.
```
class Comment < ActiveRecord::Base
belongs_to :post
end
class Author < ActiveRecord::Base
has_many :posts
end
class Post < ActiveRecord::Base
belongs_to :author
has_many :comments
end
```
`Comment.joins(:post).merge(Post.joins(:author).merge(Author.where(:name => "Joe Blogs"))).all` would
fail with `ActiveRecord::ConfigurationError: Association named 'author' was not found on Comment`.
It is failing because `all` is being called on relation which looks like this after all the merging:
`{:joins=>[:post, :author], :where=>[#<Arel::Nodes::Equality: ....}`. In this relation all the context that
`Post` was joined with `Author` is lost and hence the error that `author` was not found on `Comment`.
Ths solution is to build JoinAssociation when two relations with join information are being merged. And later
while building the arel use the previously built `JoinAssociation` record in `JoinDependency#graft` to
build the right from clause.
Thanks to Jared Armstrong (https://github.com/armstrjare) for most of the work. I ported it to make it
compatible with new code base.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit fa3ef8e82ab2f96cf15ef9bc885b2468fad77621, reversing
changes made to e0af93dd3a5eeee2e2a67b05f34afb66cc80c00b.
Reason: Routes, Active Record and the rendering stack should not depend
on the default locale
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Searching for rails executable correctly
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Current logic of finding Rails executable in parent directory is
not returning full path of executable if it is found in one of the
parent directories
* To compensate for this, we have to call exec_app_rails recursively
until the executable is found or we cant do 'chdir' anymore
* This solution finds the correct executable path from parent
directory(s) recursively
|
| |\ \ \
| |/ /
|/| | |
Using public send instead of send for the PerThreadRegistry module.
|
| |/ /
| |
| |
| | |
Prevents you from accidentally calling a protected method.
|
| |\ \
| | |
| | | |
Removed unused setup
|
| |/ / |
|
| |\ \
| | |
| | | |
Fixed typo
|
| |/ / |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
If a request has unknown format (eg. /foo.bar), the renderer
fallbacks to default format.
This patch reverts Rails 3.2 behavior after c2267db commit.
Fixes issue #9654.
|
| | | |
|
| |\ \
| | |
| | | |
Fix inflector to respect default locale.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The inflector was made aware of locales in 7db0b073fec6bc3e6f213b58c76e7f43fcc2ab97,
but it defaulted to :en. That should actually be our default
locale instead.
Fixes #10125
|
| |\ \ \
| |/ /
|/| | |
Grouping thread locals in ActiveRecord
|
| | | |
| | |
| | |
| | | |
PerThreadRegistry module.
|
| | | | |
|
| |/ /
| |
| |
| | |
thread local variables.
|
| | | |
|
| |\ \
| | |
| | | |
Use camelize instead of capitalize on template error screen
|
| | | | |
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
senny/get_action_mailer_guide_ready_for_prime_time
Get Action Mailer guide ready for prime time [ci skip]
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Rails 4 prints help for "rails new" when running "rails console"
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Removed unused setup
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Delegating the value getter and setters in the ScopeRegistry
|
| | | | | |
| | | | |
| | | | |
| | | | | |
current ScopeRegister object.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
changed variable name active_record => base_klass
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Current code stores the klass name in active_record and this
is used throughout. While reviewing the code time and again
I had the mental picture of active_record being an instance of
a klass. However here the actual klass is being stored in
@active_record.
Secondly at two different places while referring to @active_record
the comment refers to it as base klass. All this points to
active_record being not the best variable name.
So I thought it is better to replace active_record with base_klass.
This change is confined to JoinDependency, JoinBase, JoinPart and
JoinAssociation - all joining related work.
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Add TEST_DIRS enviroment for constrain test directories in rakefile
|
