| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix indentation on template errors to consider line number character count.
For instance, when an error is shown, if the related source code snippet has line numbers from, lets say, 8-12, the lines are left aligned, which means the code indent is wrong:
8: foo
9: bar
10: raise
11: baz
12: ...
This changes it to right align the source code snippet, so that the indentation is correct:
8: foo
9: bar
10: raise
11: baz
12: ...
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Change Relation#update_all with blank argument to raise an ArgumentError
instead of trying an update with empty fields.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
in a prioritized order
|
| | | | | |
| | | | |
| | | | |
| | | | | |
development box
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
No longer require AS::TestCase
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This was only needed due to
https://github.com/rails/rails/blob/6591a10b1f6eccc91bc01ab708050884058e9665/railties/lib/rails/console_app.rb#L6
We don't need that on master.
Fixes #6907.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
to_xml dasherize option should be passed to included associations
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
https://github.com/rails/rails/issues/6958
- Enable propagation of :skip_types, :dasherize and :camelize on included models by default
- Adding the option to override this propagation on a per-include basis (:include => { :model => { :dasherize => false } }
- Enough tests to prove it works
- Updated activemodel CHANGELOG.md
Squashed my commits
|
| |/ / / / / |
|
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
|
| | | | | | |
|
| | | | | | |
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This pattern was introduced as a plugin by @dhh.
The original implementation can be found in
https://github.com/rails/routing_concerns
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
their own header object
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Let Rake control the cache directories. If the directory already
exists, rake will skip creating it (vs the previous task which would
always try to mkdir_p)
|
| |\ \ \ \
| | | | |
| | | | | |
Add start_hour and end_hour options for select_hour helper
|
| |/ / / /
| | | |
| | | |
| | | | |
Updated documentation to demonstrate start_hour and end_hour options
|
| |\ \ \ \
| | | | |
| | | | | |
Evented notifications should take priority over Timed
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In cases where a notification subscriber includes methods to support
both Evented and Timed events, Evented should take priority over Timed.
This allows subscribers to be backwards compatible (older Rails only
allows Timed events) while defaulting to newer behavior.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Grammar fix in ActionView Form Tag Helper docs/comments
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Missing closing tag
|
| |/ / / / / |
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
Restore state on create when ActiveRecord::RecordInvalid is raised
|
| |/ / / /
| | | |
| | | |
| | | | |
This fixes issue #3217.
|
| | | | |
| | | |
| | | |
| | | | |
We can avoid creating extra hashes with #merge, and use #merge! instead.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Further simplify the option_html_attributes method after the changes
introduced in dacbcbe55745aa9e5484b10b11f65ccca7db1c54 to not escape the
html options here (since they're going to be escaped down the chain in
content tag).
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Under a "private" call, class methods are not real private methods,
they're public just like any other method.
Make model_name_from_record_or_class a private class method, and nodoc it.
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
morgoth/changelog-for-engine-table-name-prefix-generator-fix
Added changelog entry for table name prefix fix [ci skip]
|
| |/ / / / |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Closes #6290
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Always merge I18n format values, namespaced or not, over the default
ones, to ensure I18n format defaults will have precedence over our
namespaced values.
Precedence should happen like this:
default :format
default :namespace :format
i18n :format
i18n :namespace :format
Because we cannot allow our namespaced default to override a I18n
:format config - ie precision in I18n :format should always have higher
precedence than our default precision for a particular :namespace.
Also simplify default format options logic.
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Action Pack already comes with a default locale fine for :en, that is
always loaded. We can just fallback to this locale for defaults, if
values for the current locale cannot be found.
Closes #4420, #2802, #2890.
|
| | | | |
| | | |
| | | |
| | | | |
Removed in 0228a73b1094a3e19ad291d2ce4789890c09578a, pull request #7310.
|
| |\ \ \ \
| | | | |
| | | | | |
Check for Blank Record in form_for
|
| | | | | |
| | | | |
| | | | |
| | | | | |
if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Move AD default_headers configurations to railtie
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add documentation for config.action_dispatch.default_headers to
Rails Configuring guide.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
ActionDispatch railtie is a better place for
config.action_dispatch.default_headers settings, users can continue
overriding those settings in their configuration files if needed.
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Return the conditions from the keep_if call, and ignore the value
argument since it's not being used.
|
| | | | | | |
|
