| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Simplify parse arguments in `ConsoleTest`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If need a parse result of arguments, can obtain it by creating
an instance of the command.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
bogdanvlviv/express-change_column_comment-as-public-api
Express #change_column_comment as public api
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Implemented by #22911
Related to #30677
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use released `sidekiq` instead of master version
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The sidekiq 5.0.5 includes redis-rb 4.0 support.
Ref: https://github.com/mperham/sidekiq/blob/90db3b84208cbb73a50d1a77a1dea97d3490ce70/Changes.md#505
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
parent relation's aliases
Building association scope in join dependency should respect the parent
relation's aliases to avoid using the same alias name more than once.
Fixes #30681.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
test cases
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use `form_with` instead of `form_for` in engine guide [ci skip]
|
| | |/ / / /
| |/| | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I don't think this is a good abstraction because the internal method is
used only if the relation need to be applied join dependency.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
yhirano55/fix_rails_routes_log_in_getting_started_guide
Fix the result of `rails routes` in Guide [ci skip]
|
| |/ / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`relation.exists?` should reference correct aliases while joining tables
of has_many through associations.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Seems the branch has rebased. cc @jeremy
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix typo in loading error message
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
s/Action Record/Active Record/
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
redis-rb 4.0 support
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* Use `gem 'redis', '~> 4.0'` for new app Gemfiles
* Loosen Action Cable redis-rb dep to `>= 3.3, < 5`
* Bump redis-namespace for looser Redis version dep
* Avoid using the underlying `redis.client` directly
* Use `Redis.new` instead of `Redis.connect`
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Adapters bubble up gem version mismatches for their dependencies
|
| | |_|_|_|/ /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* When the adapter is missing, raise an exception that points out config
typos and missing Gemfile entries. (We can assume that a non-builtin
adapter was used since these are always available.)
* When loading an adapter raises a LoadError, prefix its error message
to indicate that the adapter is likely missing an optional dependency.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Fixes ActiveSupport::Cache::FileStore#cleanup bug which prevented it from removing expired entries
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
cleaning up the expired cache keys
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Break long variant filenames into path chunks
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If a variant has a large set of options associated with it, the generated
filename will be too long, causing Errno::ENAMETOOLONG to be raised. This
change replaces those potentially long filenames with a much more compact
SHA256 hash. Fixes #30662.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Exception message for SystemTestCase#get etc..
|
| | | | | | | | |
|
| |_|_|_|_|/ /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This is preparation to respect parent relation's alias tracking for
fixing #30681.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix radio_button_tag comment
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Colons, periods, etc. can also be included in id.
The sanitize_to_id method does not remove them.
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
Fix default of `String#to_time` [ci skip]
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
The default of `String#to_time` is `:local` since b79adc4.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
[ci skip] Fix typo
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
yhirano55/update_instrumentation_guide_for_active_storage
Update Instrumentation guide for Active Storage [ci skip]
|
| | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \
| |/ / / / / / / /
|/| | | | | | | | |
Remove needless setup from `InfoTest`
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
The `abstract_unit` loads `rails/all`. Therefore, `Rails` is definitely defined.
Also, since `Info` is autoloaded, do not need to explicitly load the file.
https://github.com/rails/rails/blob/3ede539357acc91e377611cea9dd5f30678e7b2a/railties/lib/rails.rb#L29
|
|\ \ \ \ \ \ \ \ \
| |_|/ / / / / / /
|/| | | | | | | | |
Add v5.1 to earlier releases list in guide [ci skip]
|
|/ / / / / / / / |
|
|\ \ \ \ \ \ \ \
| |_|_|/ / / / /
|/| | | | | | | |
Missing backquotes in the guides
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
link tags shouldn't depend on the request
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use __callee__ to pass alias instead of original method name
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Before
```
> Article.left_joins
ArgumentError: The method .left_outer_joins() must contain arguments.
```
After
```
> Article.left_joins
ArgumentError: The method .left_joins() must contain arguments.
```
|
| |/ / / /
|/| | | | |
|