Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | | | | | | | No need to check for puma | Rafael Mendonça França | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rack::Server already does it work for us if the server is installed. | |||||
| * | | | | | | | | | | | Fix test now that cable is in there by default too | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Quiet warnings | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+2 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Avoid Action Cable stubs on --skip-action-cable | David Heinemeier Hansson | 2015-12-16 | 3 | -3/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Still missing the stuff in app/ – we need to basically switch from a * match to specifically picking out what we need. | |||||
| * | | | | | | | | | | | No longer needed now that we prefill with app/models/application_record.rb | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+0 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Clarify | David Heinemeier Hansson | 2015-12-16 | 1 | -3/+3 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Generate all the ApplicationCable stubs by default, like all other ↵ | David Heinemeier Hansson | 2015-12-16 | 8 | -38/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Application* stubs | |||||
| * | | | | | | | | | | | Saner increments | David Heinemeier Hansson | 2015-12-16 | 1 | -3/+3 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Use puma as the default development server, if available | David Heinemeier Hansson | 2015-12-16 | 2 | -4/+4 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Comment out the user handling so default setup connects directly | David Heinemeier Hansson | 2015-12-16 | 1 | -18/+18 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Eager loading is required for Action Cable and we should use the logging too | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+4 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Only mount the ActionCable server if ApplicationCable has been defined | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | By default, mount Action Cable on the router | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+3 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Add default redis config for Action Cable | David Heinemeier Hansson | 2015-12-16 | 2 | -0/+9 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Cargo cult fix to make Celluloid behave | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+3 | |
| | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | Merge branch 'master' into merge-action-cable | Rafael Mendonça França | 2015-12-16 | 54 | -407/+485 | |
| |\ \ \ \ \ \ \ \ \ \ \ | ||||||
| * | | | | | | | | | | | | Only include action cable meta tags if it is not skipped | Rafael Mendonça França | 2015-12-16 | 1 | -0/+2 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Needless whitespace | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+0 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Include the action cable URL meta tag by default | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+3 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Require tree | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Simpler directory structure | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+2 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Note that changes to the cable setup requires restarting the server | David Heinemeier Hansson | 2015-12-16 | 3 | -0/+3 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | @App could have been set elsewhere | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Another stab at only mounting redis if the config is there | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+2 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Assume that the cable server is running in-process by default, offer option ↵ | David Heinemeier Hansson | 2015-12-16 | 2 | -0/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to change that in config/environments/production.rb | |||||
| * | | | | | | | | | | | | Fix parent class | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Fix the engine reference | Rafael Mendonça França | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Doh, should have read ff370ee61754b00f864f3ddd0af62be4dfa0de67 | David Heinemeier Hansson | 2015-12-16 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Indeed we need this to be an engine for the internal assets to work | |||||
| * | | | | | | | | | | | | Only initialize redis if the config file is there | David Heinemeier Hansson | 2015-12-16 | 1 | -5/+5 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Another bad reference to engine instead of railtie | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Include changes made to the engine | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+5 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Move Cable to ActionCable for client-side constant to avoid conflicts | David Heinemeier Hansson | 2015-12-16 | 8 | -49/+49 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | We are using railtie, not engine | David Heinemeier Hansson | 2015-12-16 | 3 | -37/+2 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Basic channel generator | David Heinemeier Hansson | 2015-12-15 | 7 | -0/+101 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Move the require to the right place | Rafael Mendonça França | 2015-12-15 | 2 | -2/+1 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Remove the default logger | Rafael Mendonça França | 2015-12-15 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It should be configured through the railtie | |||||
| * | | | | | | | | | | | | Configure the Action Cable's redis in the engine | Rafael Mendonça França | 2015-12-15 | 3 | -23/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will decouple Action Cable from Rails. | |||||
| * | | | | | | | | | | | | Accept a Pathname in Application#config_for | Rafael Mendonça França | 2015-12-15 | 2 | -1/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That would make possible to use it with action cable configuration. | |||||
| * | | | | | | | | | | | | Add Action Cable to README.md of Rails | claudiob | 2015-12-15 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Link to actioncable/README.md for more details | |||||
| * | | | | | | | | | | | | Remove rails/actioncable Travis badge | claudiob | 2015-12-15 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Since Action Cable is getting integrated into rails/rails, the Travis badge for rails/actioncable is not needed anymore. Also following the standard of every other README to have `--` rather than `-` to separating the name of the library from its description. | |||||
| * | | | | | | | | | | | | Merge remote-tracking branch 'origin/master' into merge-action-cable | Rafael Mendonça França | 2015-12-15 | 75 | -165/+419 | |
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | |_|/ / / / / / / / / | | |/| | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Action Cable need to be a engine | Rafael Mendonça França | 2015-12-15 | 2 | -1/+31 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise assets will not work | |||||
| * | | | | | | | | | | | | Merge pull request #22600 from javan/update-action-cable | David Heinemeier Hansson | 2015-12-15 | 2 | -4/+15 | |
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring latest changes over from actioncable/master | |||||
| | * | | | | | | | | | | | | Bring latest changes over from actioncable/master | Javan Makhmali | 2015-12-15 | 2 | -4/+15 | |
| |/ / / / / / / / / / / / | ||||||
| * | | | | | | | | | | | | Switch from engine to railtie | David Heinemeier Hansson | 2015-12-15 | 2 | -6/+6 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Use a bind param for `LIMIT` and `OFFSET` | Sean Griffin | 2015-12-15 | 5 | -13/+47 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We currently generate an unbounded number of prepared statements when `limit` or `offset` are called with a dynamic argument. This changes `LIMIT` and `OFFSET` to use bind params, eliminating the problem. `Type::Value#hash` needed to be implemented, as it turns out we busted the query cache if the type object used wasn't exactly the same object. This drops support for passing an `Arel::Nodes::SqlLiteral` to `limit`. Doing this relied on AR internals, and was never officially supported usage. Fixes #22250. | |||||
| * | | | | | | | | | | | | Deprecate limit strings with commas | Sean Griffin | 2015-12-15 | 2 | -3/+13 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some backends allow `LIMIT 1,2` as a shorthand for `LIMIT 1 OFFSET 2`. Supporting this in Active Record massively complicates using bind parameters for limit and offset, and it's trivially easy to build an invalid SQL query by also calling `offset` on the same `Relation`. This is a niche syntax that is only supported by a few adapters, and can be trivially worked around by calling offset explicitly. | |||||
| * | | | | | | | | | | | | Add specific bug reporting guidelines to contributing.md. [ci skip] | Tim | 2015-12-15 | 1 | -7/+33 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add boldface and bullets to make more readable. Make sentences declarative. Remove "you"s. | |||||
| * | | | | | | | | | | | | Add option to skip Action Cable | Rafael Mendonça França | 2015-12-14 | 3 | -2/+10 | |
| | | | | | | | | | | | | | ||||||
| * | | | | | | | | | | | | Do not run action cable tests in isolation | Rafael Mendonça França | 2015-12-14 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't have isolation tests for it yet. |