| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |/ / / / |
|
| |\ \ \ \
| |/ / /
|/| | | |
Fix `warning: ambiguous first argument`
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
```
test/cases/adapters/postgresql/case_insensitive_test.rb:12: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/cases/adapters/postgresql/case_insensitive_test.rb:16: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/cases/adapters/postgresql/case_insensitive_test.rb:20: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/cases/adapters/postgresql/case_insensitive_test.rb:24: warning: ambiguous first argument; put parentheses or a space even after `/' operator
```
|
| |\ \ \
| | | |
| | | | |
Set target ruby version for rubocop to 2.2 instead 2.3.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This change will help to catch ruby 2.3+ syntax in code base. Right now, minimal ruby version set to 2.2.2 in gemspecs.
Rubocop output before:
$ rubocop
Inspecting 2133 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................CC.........................................................................................................................................................................................................................................................
Offenses:
activerecord/test/cases/schema_dumper_test.rb:454:32: C: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
output = dump_table_schema('infinity_defaults')
^^^^^^^^^^^^^^^^^^^
guides/bug_report_templates/active_record_migrations_gem.rb:65:4: C: Final newline missing.
end
guides/bug_report_templates/active_record_migrations_master.rb:64:4: C: Final newline missing.
end
2133 files inspected, 3 offenses detected
$
After:
$ rubocop
Inspecting 2133 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................CC.........................................................................................................................................................................................................................................................
Offenses:
activerecord/test/cases/schema_dumper_test.rb:454:32: C: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
output = dump_table_schema('infinity_defaults')
^^^^^^^^^^^^^^^^^^^
guides/bug_report_templates/active_record_migrations_gem.rb:65:4: C: Final newline missing.
end
guides/bug_report_templates/active_record_migrations_master.rb:64:4: C: Final newline missing.
end
2133 files inspected, 3 offenses detected
$
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* ActionController::Parameters#deep_dup
* Tests for ActionController::Parameters#deep_dup
* Fix test for ActionController::Parameters#deep_dup
* More tests for ActionController::Parameters#deep_dup
[Rafael Mendonça França + Pavel Evstigneev]
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
WebSocket always defers the decision to the server, because it didn't
have to deal with legacy compatibility... but the same-origin policy is
still a reasonable default.
Origin checks do not protect against a directly connecting attacker --
they can lie about their host, but can also lie about their origin.
Origin checks protect against a connection from 3rd-party controlled
script in a context where a victim browser's cookies will be passed
along. And if an attacker has breached that protection, they've already
compromised the HTTP session, so treating the WebSocket connection in
the same way seems reasonable.
In case this logic proves incorrect (or anyone just wants to be more
paranoid), we retain a config option to disable it.
|
| |\ \ \
| | | |
| | | |
| | | | |
Optionally allow ActionCable requests from the same host as origin
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When the `allow_same_origin_as_host` is set to `true`, the request
forgery protection permits `HTTP_ORIGIN` values starting with the
corresponding `proto://` prefix followed by `HTTP_HOST`. This way
it is not required to specify the list of allowed URLs.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Fix case insensitive check for text column in pg
|
| | | | | |
| | | | |
| | | | |
| | | | | |
There's no 'text to text' casting in the cast table so the feature detection fails.
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Extract `format_colspec` to format column spec
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove unused require `benchmark`
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`Benchmark` was removed at 4215e9a
|
| |\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Add top level license
|
| | | | | | | | |
|
| | | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Add top level license file so that github auto detects the license type
- and displays it in the repository overview section
- More info at https://github.com/blog/2252-license-now-displayed-on-repository-overview
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove deprecations in Active Model, Action View and Active Job
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`.
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix table comment dumping
|
| |/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Follow up to #26735.
If `table_options` returns `{ comment: nil }`, `create_table` line is
broken.
Example:
```ruby
create_table "accounts", force: :cascade, do |t|
```
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
`name` is not a column option
|
| | |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
`migration_keys` includes `name` but `name` is not a column option.
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Add missing @, fix indents. [ci skip]
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Undeprecate plural positional argument
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
```ruby
pluralize people.count, 'person', 'people'
```
reads more naturally than
```ruby
pluralize people.count, 'person', plural: 'people'
```
so let's not deprecate it.
We could label both, but that's a mouthful:
```ruby
pluralize people.count, singular: 'person', plural: 'people'
```
(The `plural:` kwarg shipped in 5.0.0, so we're keeping it.)
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove all deprecations from Action Pack
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`ActionDispatch::IntegrationTest`,
`#process`, `#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head`.
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`ActionDispatch::Routing::Mapper#match`
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`ActionDispatch::Routing::Mapper#match`
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`ActionDispatch::Static#initialize`
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
ActionDispatch::ParamsParser class was removed in favor of
ActionDispatch::Http::Parameters so it is better to move the error
constant to the new class.
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
