aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | | Handle `RangeError` from casting in `find_by` and `find_by!` on RelationSean Griffin2014-11-022-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should not behave differently just because a class has a default scope.
| * | | | | | | | | | | Revert deprecation of `sanitize_sql_hash_for_assignment`Sean Griffin2014-11-022-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method is still used by `update_all`
| * | | | | | | | | | | Deprecate `sanitize_sql_hash_` methods on ActiveRecordSean Griffin2014-11-022-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These appear to be implementation relics of times past. They duplicate the logic in Relation, and are no longer used internally.
| * | | | | | | | | | | Pass the `SelectManager`, rather than the AST when querying w/ RelationSean Griffin2014-11-021-1/+1
| | |_|_|_|_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Arel specifically handles `SelectManager`, with the same logic we're currently performing. The AST is `Enumerable`, which Arel looks for separately now.
| * | | | | | | | | | Tiny documentation styling fixes [ci skip]Robin Dupret2014-11-023-18/+24
| | | | | | | | | | |
| * | | | | | | | | | Merge pull request #17469 from rishijain/update_docs_2Zachary Scott2014-11-022-2/+4
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | added punctuations, and role of queue_adapter module [ci skip]
| | * | | | | | | | | | placed description at correct place [ci skip]Rishi Jain2014-11-011-2/+2
| | | | | | | | | | | |
| | * | | | | | | | | | added punctuations, and role of queue_adapter module [ci skip]Rishi Jain2014-11-012-2/+4
| | | | | | | | | | | |
| * | | | | | | | | | | Merge pull request #17483 from pabloh/optimize_gsub_callsSean Griffin2014-11-015-5/+5
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Call gsub with a Regexp instead of a String for better performance
| | * | | | | | | | | | | Call gsub with a Regexp instead of a String for better performancePablo Herrero2014-11-015-5/+5
| | | | | | | | | | | | |
| * | | | | | | | | | | | Don't duplicate predicate building logic in Relation findersSean Griffin2014-11-011-5/+2
| | | | | | | | | | | | |
| * | | | | | | | | | | | Add a test case for range type castingSean Griffin2014-11-011-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We support this behavior, but have no tests which assert that type casting actually occurs.
| * | | | | | | | | | | | Use a bound parameter for the "id = " portion of update statementsSean Griffin2014-11-012-5/+14
| |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to re-order the bind parameters since the AST returned by the relation will have the where statement as the first bp, which breaks on PG.
| * | | | | | | | | | | Correctly cast calculation results on PGSean Griffin2014-11-014-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MySQL reports the column name as `"MAX(developer_id)"`. PG will report it as `"max"`
| * | | | | | | | | | | Merge pull request #17482 from djpowers/patch-1Zachary Scott2014-11-011-0/+1
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Add link to API Documentation Guidelines [ci skip]
| | * | | | | | | | | | | Add link to API Documentation GuidelinesDave Powers2014-11-011-0/+1
| |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Link to the "English" section to specify American English be used for the Guides [ci skip]
| * | | | | | | | | | | [ci skip] `Relation#bind` is not public APISean Griffin2014-11-011-1/+1
| | | | | | | | | | | |
| * | | | | | | | | | | Fix test which failed in isolationSean Griffin2014-11-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was transitively relying on the vertex model being loaded
| * | | | | | | | | | | Use bind values for joined tables in where statementsSean Griffin2014-11-018-1/+43
| | |_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In practical terms, this allows serialized columns and tz aware columns to be used in wheres that go through joins, where they previously would not behave correctly. Internally, this removes 1/3 of the cases where we rely on Arel to perform type casting for us. There were two non-obvious changes required for this. `update_all` on relation was merging its bind values with arel's in the wrong order. Additionally, through associations were assuming there would be no bind parameters in the preloader (presumably because the where would always be part of a join) [Melanie Gilman & Sean Griffin]
| * | | | | | | | | | Merge pull request #17463 from mrgilman/remove-index-from-substitute-atSean Griffin2014-11-013-7/+6
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Remove redundant substitute index when constructing bind values
| | * | | | | | | | | | Remove redundant substitute index when constructing bind valuesMelanie Gilman2014-10-313-7/+6
| | |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We end up re-ordering them either way when we construct the Arel AST (in order to deal with rewhere, etc), so we shouldn't bother giving it a number in the first place beforehand.
| * | | | | | | | | | Merge pull request #17477 from Adam89/ma-remove-redundant-requireRichard Schneeman2014-11-011-1/+0
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Remove redundant require of file
| | * | | | | | | | | | Remove redundant require of fileAdam892014-11-011-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This file was required inside 'test/validators/namespace/email_validator.rb' that's already required here. Therefore I removed the redundant required.
| * | | | | | | | | | | Don't needlessly alphabetize columns for insert/updateSean Griffin2014-11-011-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This slightly simplifies the code, and reduces the number of times we need to iterate over the attributes by one.
| * | | | | | | | | | | Tiny documentation fixes and styling improvementsRobin Dupret2014-11-012-12/+17
| |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| * | | | | | | | | | Merge pull request #17474 from kuldeepaggarwal/fix-indentaionRafael Mendonça França2014-11-011-1/+1
| |\ \ \ \ \ \ \ \ \ \ | | |_|_|_|/ / / / / / | |/| | | | | | | | | add missing space.[ci skip]
| | * | | | | | | | | add missing space.[ci skip]Kuldeep Aggarwal2014-11-011-1/+1
| |/ / / / / / / / /
| * | | | | | | | | Merge pull request #17470 from keikun17/masterZachary Scott2014-10-311-2/+1
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | [ci skip] Fix line break on asset pipeline guide
| | * | | | | | | | | Fix break on generated htmlCakey | Buddy Magsipoc2014-11-011-2/+1
| |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes this : ![http://i.imgur.com/86scI3a.png](http://i.imgur.com/86scI3a.png))
| * | | | | | | | | remove unused and untested APIAaron Patterson2014-10-311-6/+2
| | | | | | | | | |
| * | | | | | | | | fix set_pk_sequence and add a test for it.Aaron Patterson2014-10-312-1/+9
| | | | | | | | | |
| * | | | | | | | | Added region sequencing of primary keys for Postgres.Joe Rafaniello2014-10-311-0/+21
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Skip setting sequence on a table create if the value is 0 since it will start the first value at 1 anyway. This fixes the PG error 'setval: value 0 is out of bounds for sequence vms_id_seq...' encountered when migrating a new DB. BugzID: 15452,9772,13475,16850
| * | | | | | | | Don't attempt to load the schema file in tests if none existsSean Griffin2014-10-312-3/+18
| | | | | | | | |
| * | | | | | | | Don't modify the columns hash to set defaults from the attributes APISean Griffin2014-10-313-14/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nothing is directly using the columns for the default values anymore. This step helps us get closer not not mutating the columns hash.
| * | | | | | | | Load test schema even if there are no migrationsSean Griffin2014-10-312-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #17170
| * | | | | | | | Merge pull request #17040 from clyfe/patch-1Rafael Mendonça França2014-10-311-2/+4
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Explicit route test class
| | * | | | | | | | Explicit route test classClaudius Nicolae2014-09-241-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | shows the class that the test must extend in order to have the assert_routing method available
| * | | | | | | | | Merge pull request #17305 from ↵Rafael Mendonça França2014-10-312-1/+90
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ziggythehamster/activerecord-connectionhandling-RAILS_ENV-without-rails If Rails is not defined, check ENV["RAILS_ENV"] and ENV["RACK_ENV"] in ActiveRecord::ConnectionHandling
| | * | | | | | | | | If Rails is not defined, check ENV["RAILS_ENV"] and ENV["RACK_ENV"].Keith Gable2014-10-212-1/+90
| | | |_|_|_|_|_|_|/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression introduced by 6cc03675d30b58e28f585720dad14e947a57ff5b. ActiveRecord, if used without Rails, always checks the "default_env" environment. This would be OK, except that Sinatra also supports environments, and it runs with {RACK|RAILS}_ENV=production. This patch adds a fallback to RAILS_ENV and RACK_ENV (and ultimately default_env) if Rails.env doesn't exist.
| * | | | | | | | | Merge pull request #17462 from vipulnsward/actionmailer-doc-fixRafael Mendonça França2014-10-311-2/+7
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | AM README fixes [ci skip]
| | * | | | | | | | | - Changed redundant user of `deliver` to `deliver_now`Vipul A M2014-11-011-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Wrapped text in setting defaults section. Also added break, to a sentence. [ci skip]
| * | | | | | | | | | Use the correct values for int max and minSean Griffin2014-10-313-56/+119
| | |_|_|_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We had accidentally gone one power of two too far. In addition, we need to handle minimum values as well as the maximum.
| * | | | | | | | | Tiny documentation improvements [ci skip]Robin Dupret2014-10-313-11/+8
| | | | | | | | | |
| * | | | | | | | | Merge branch 'tags-public-send'Rafael Mendonça França2014-10-312-1/+15
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #14180 Fixes #17461
| | * | | | | | | | | Improve test of private properties of objects in form tagsRafael Mendonça França2014-10-311-28/+9
| | | | | | | | | | |
| | * | | | | | | | | Use public_send for form tagsagius2014-10-311-0/+27
| | | | | | | | | | |
| | * | | | | | | | | Honor public/private in ActionView::Helpers::Tags::Base#valueTobias Pfeiffer2014-10-312-1/+7
| |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * use public_send instead of send to avoid calling private methods in form helpers
| * | | | | | | | | Merge pull request #17459 from sgrif/sg-find-by-large-numbersSean Griffin2014-10-319-18/+56
| |\ \ \ \ \ \ \ \ \ | | |/ / / / / / / / | |/| | | | | | | | Treat strings greater than int max value as out of range
| | * | | | | | | | Treat strings greater than int max value as out of rangeSean Griffin2014-10-319-18/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sufficiently large integers cause `find` and `find_by` to raise `StatementInvalid` instead of `RecordNotFound` or just returning `nil`. Given that we can't cast to `nil` for `Integer` like we would with junk data for other types, we raise a `RangeError` instead, and rescue in places where it would be highly unexpected to get an exception from casting. Fixes #17380
| * | | | | | | | | Merge pull request #17460 from hbriggs/masterAbdelkader Boudih2014-10-311-4/+7
| |\ \ \ \ \ \ \ \ \ | | |/ / / / / / / / | |/| | | | | | | | Masked authenticity token section, finder options details, misc typos [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 06:06:57 +0000