Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Refactor Active Record test connection setup. Please see the ↵ | Jon Leighton | 2011-06-04 | 166 | -571/+360 |
| | | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. | ||||
* | Force RAILS_ENV=development in rackup_test.rb. This fixes a problem on the ↵ | Jon Leighton | 2011-06-04 | 1 | -0/+6 |
| | | | | CI server. For some reason the RAILS_ENV on the CI server is production, which means that the ActionDispatch::Static middleware is not used, and so the request in 'config.ru can be racked up' returns a 404 rather than a 200. | ||||
* | adds Vijay Dev to the new Rails Guides Reviewers team | Xavier Noria | 2011-06-05 | 2 | -8/+12 |
| | | | | See http://weblog.rubyonrails.org/2011/6/2/news-from-the-documentation-front | ||||
* | move Ryan up, since the list is ordered by surname | Xavier Noria | 2011-06-04 | 1 | -4/+4 |
| | |||||
* | adds Ryan Bigg to the credits page of the guides, he is the author of the ↵ | Xavier Noria | 2011-06-04 | 2 | -0/+4 |
| | | | | new configuring guide | ||||
* | specify image dimensions for pictures in the guides credits page | Xavier Noria | 2011-06-04 | 1 | -1/+1 |
| | |||||
* | Add missing require for cookies middleware | Andrew White | 2011-06-04 | 1 | -0/+1 |
| | |||||
* | Refactor ActionController::TestCase cookies | Andrew White | 2011-06-04 | 8 | -65/+60 |
| | | | | | | | | | | | | | | | | | | Assigning cookies for test cases should now use cookies[], e.g: cookies[:email] = 'user@example.com' get :index assert_equal 'user@example.com', cookies[:email] To clear the cookies, use clear, e.g: cookies.clear get :index assert_nil cookies[:email] We now no longer write out HTTP_COOKIE and the cookie jar is persistent between requests so if you need to manipulate the environment for your test you need to do it before the cookie jar is created. | ||||
* | Merge pull request #1468 from castlerock/fix_issue_1467 | José Valim | 2011-06-03 | 0 | -0/+0 |
|\ | | | | | Double assignment of attributes on a collection association occurs fixed #1467 | ||||
| * | Double assignment of attributes on a collection association occurs fixed for ↵ | Raghunadh | 2011-06-03 | 1 | -1/+0 |
| | | | | | | | | the issue issue #1467 | ||||
* | | Don't double assign attributes - closes #1467. | Andrew White | 2011-06-03 | 1 | -1/+0 |
|/ | |||||
* | Fix broken test. You know, the merge button will be the end of us... | Jon Leighton | 2011-06-01 | 1 | -3/+3 |
| | |||||
* | Merge pull request #1447 from dmathieu/empty_route | Piotr Sarnacki | 2011-06-01 | 2 | -1/+9 |
|\ | | | | | Fix creating an empty route on 1.8. Closes #1210 | ||||
| * | fix creating an empty route on 1.8. Closes #1210 | Damien Mathieu | 2011-06-01 | 2 | -1/+9 |
| | | |||||
* | | Merge pull request #1385 from smartinez87/drop | Aaron Patterson | 2011-06-01 | 1 | -1/+1 |
|\ \ | | | | | | | #drop_table accepts no options now. | ||||
| * | | #drop_table accepts no options now. | Sebastian Martinez | 2011-05-28 | 1 | -1/+1 |
| | | | |||||
* | | | Adding comment | Arun Agrawal | 2011-06-01 | 1 | -0/+1 |
| | | | |||||
* | | | AttributeMethodTest test fix #jruby | Vishnu Atrai | 2011-06-01 | 1 | -1/+5 |
| | | | |||||
* | | | Fix issue #1272 | Brian Mathiyakom | 2011-06-01 | 4 | -10/+24 |
| | | | | | | | | | | | | | | | Set reverse_order_value when asked to reverse_order(). Do the actual reversal in build_arel. | ||||
* | | | Merge pull request #1448 from ernie/attr_internal_require | José Valim | 2011-06-01 | 1 | -0/+2 |
|\ \ \ | |_|/ |/| | | Require attr_internal before using in ActionView::Helpers | ||||
| * | | Require attr_internal before using in ActionView::Helpers | Ernie Miller | 2011-06-01 | 1 | -0/+2 |
| | | | |||||
* | | | Merge pull request #1441 from guilleiguaran/no_rb_require | José Valim | 2011-06-01 | 2 | -2/+2 |
|\ \ \ | | | | | | | | | Don't add .rb in requires | ||||
| * | | | Don't add .rb in requires | Guillermo Iguaran | 2011-05-31 | 2 | -2/+2 |
| | | | | |||||
* | | | | Add missing require to fix the CI | Jon Leighton | 2011-06-01 | 1 | -0/+1 |
| | | | | |||||
* | | | | Merge pull request #1439 from sikachu/isolated_pg_test | Aaron Patterson | 2011-05-31 | 2 | -20/+29 |
|\ \ \ \ | |/ / / |/| | | | Isolated PostgreSQL test into PostgreSQL folder | ||||
| * | | | Isolated PostgreSQL test into PostgreSQL folder | Prem Sichanugrist | 2011-05-31 | 2 | -20/+29 |
|/ / / | |||||
* | | | Raise NameError instead of ArgumentError in ActiveSupport::Dependencies | Andrew White | 2011-06-01 | 5 | -3/+11 |
| | | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Dependencies now raises NameError if it finds an existing constant in load_missing_constant. This better reflects the nature of the error which is usually caused by calling constantize on a nested constant. Closes #1423 | ||||
* | | | added an alias for new to build to the AR collection proxy, this corrects an ↵ | Josh Kalderimis | 2011-06-01 | 4 | -10/+27 |
| | | | | | | | | | | | | issue where the collection proxies were not consistent | ||||
* | | | Make MemCacheStore work with Ruby 1.9 and -Ku | Andrew White | 2011-05-31 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #1434 from dmathieu/mass_assignment | José Valim | 2011-05-31 | 1 | -1/+2 |
|\ \ \ | | | | | | | | | Mass assignment | ||||
| * | | | no need for .rb | Damien Mathieu | 2011-05-31 | 1 | -1/+1 |
| | | | | |||||
| * | | | string inflections are needed for running tests in isolation | Damien Mathieu | 2011-05-31 | 1 | -0/+1 |
| | | | | |||||
* | | | | Revert "[activerecord][postgresql] verify if table has a schema(not ↵ | Jon Leighton | 2011-05-31 | 1 | -5/+6 |
|/ / / | | | | | | | | | | | | | | | | public)". This caused a test breakage. See #1410 for details. This reverts commit c44418ea4e09cc81da47edbc9ac5f31c7e32c1b4. | ||||
* | | | standarize documentation (and indirectly code) to use American English as ↵ | Xavier Noria | 2011-05-31 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | discussed in 4f234bf Please do not perform monster patches for this until 3.1 is out. Also, no existing API should be affected by this. New code, local variables, etc. would follow this guideline to have a consistent project tree in this regard. | ||||
* | | | revises commit from pull request 1408 | Xavier Noria | 2011-05-31 | 1 | -4/+7 |
| | | | |||||
* | | | revises commit from pull request 1409 | Xavier Noria | 2011-05-31 | 1 | -4/+8 |
| | | | |||||
* | | | Modified generated text to explain where .js and .coffee files can be ↵ | Noel Gomez | 2011-05-31 | 1 | -3/+5 |
| | | | | | | | | | | | | located and that there shouldn't be blank lines in manifest per this issue http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/effb868290c2c0b8 | ||||
* | | | changed text to be more explicit about where stylesheets can be located | Noel Gomez | 2011-05-31 | 1 | -2/+5 |
| | | | |||||
* | | | Ensure that calculations properly override the select value even if it's set ↵ | Jon Leighton | 2011-05-31 | 2 | -2/+7 |
| | | | | | | | | | | | | in the default scope. Fixes #1395. | ||||
* | | | Failing test for aggregating on default_scope with select | Erik Fonselius | 2011-05-31 | 2 | -0/+9 |
| | | | |||||
* | | | Only save the record once when calling create! on a collection association. ↵ | Jon Leighton | 2011-05-31 | 4 | -25/+45 |
| | | | | | | | | | | | | Fixes #1360. | ||||
* | | | Tests for issue #1360 | Farley Knight | 2011-05-31 | 2 | -0/+24 |
| | | | |||||
* | | | Implementing @dmathieu's cleaner fix from #1425. Unfortunately he deleted ↵ | Jon Leighton | 2011-05-31 | 1 | -8/+5 |
| | | | | | | | | | | | | the branch so I cannot just merge it. | ||||
* | | | Reduce test noise | Jon Leighton | 2011-05-31 | 1 | -20/+14 |
| | | | |||||
* | | | Merge pull request #1417 from arunagw/nested_attributes_fix | Aaron Patterson | 2011-05-31 | 2 | -8/+11 |
|\ \ \ | | | | | | | | | Fix nested attribute for memory record. | ||||
| * | | | Opening class CascadedEagerLoadingTest at once. | Arun Agrawal | 2011-05-31 | 1 | -7/+3 |
| | | | | |||||
| * | | | Adding comment to work with 1.8.7. Nested Attribute fix. | Arun Agrawal | 2011-05-31 | 1 | -0/+3 |
| | | | | |||||
| * | | | Fix nested attribute for memory record. | Arun Agrawal | 2011-05-31 | 1 | -1/+5 |
| | | | | |||||
* | | | | Update CHANGELOG. | José Valim | 2011-05-31 | 1 | -0/+2 |
| | | | | |||||
* | | | | Transform the symbol into a constant lookup. | José Valim | 2011-05-31 | 3 | -29/+32 |
| | | | |