| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- When making a request to a controller that redirects, `follow_redirect!` would not reset the `html_document` ivar, it only resets the `html_document` ivar from the session (not the runner)
- If one was doing something like this;
```ruby
get '/redirect'
assert_select 'you are being redirected'
follow_redirect!
# html_document is memoized and doesn't get reset
```
- To fix the issue we can do the same for any other methods (`get`, `post`...) and define a method in the runner that delegates to the session but clears the html_document_first
- Fixes #29367
|
| |\
| |
| |
| |
| | |
samphippen/samphippen/add-option-to-silence-puma-in-system-test
Add an option to silence puma in system tests.
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
This is motivated by our usage of system test in RSpec. Puma lazily
boots the first time a system test is used, but this causes some
unfortunate output to appear in the middle of the user's green dots. An
example of this can be seen in @derekprior's comment
[here](https://github.com/rspec/rspec-rails/pull/1813#issuecomment-309252314).
There are alternatives in RSpec where we attempt to intercept the puma
boot and prevent the output from being made there, but that would
involve some monkey patching. This seems like a cleaner solution.
|
| |\
| |
| | |
Don't wrap parameters if key already exists
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We shouldn't perform parameter wrapping if it would overwrite one of the
parameters sent with the request, as that would interfere with reading
the parameter directly from the top level `params` hash.
The current implementation has logic for this case, but it doesn't
handle `nil`/`false` values, which means these parameters:
{ "user" => nil }
are transformed into this `params` hash:
{ "user" => { "user" => nil } }
and `params["user"]` no longer returns the original parameter value.
|
| |\ \
| | |
| | |
| | |
| | | |
Edouard-chin/integration-testing-deprecated-methods
Removed reference to unexisting methods:
|
| | |/
| |
| |
| | |
`get/post_via_redirect`, `xhr` and his alias `xml_http_request` were respectively removed in 092033d59f7e2b248f6c6ab6c0b67339c5e9f2df and eb52e5d42fbdc9288925a402dcb3c5664d1125b7
|
| |\ \
| |/
|/|
| |
| | |
ybakos/guides_layouts_and_rendering_minus_leading_underscore
Guides: Clarify partial local variable naming. [ci skip]
|
| |/
|
|
|
| |
Clarify the partial local variable name as being the same as the name
of the partial, minus the _leading_ underscore.
|
| |\
| |
| | |
Fix typo in `AC::UnfilteredParameters` message [ci skip]
|
| |/
|
|
| |
Ref: https://github.com/rails/rails/blob/33b596709388cc48d90ab6d1de99d7bd6e85f916/actionpack/lib/action_controller/metal/strong_parameters.rb#L52..L56
|
| |\
| |
| |
| |
| | |
y-yagi/do_not_use_private_api_in_bug_report_templates
Do not use private API in bug report templates
|
| | |
| |
| |
| |
| |
| |
| |
| | |
`ActiveRecord::Migrator` is private API.
https://github.com/rails/rails/blob/bb9d6eb094f29bb94ef1f26aa44f145f17b973fe/activerecord/lib/active_record/migration.rb#L977
Therefore, it is not good to use it in bug report templates.
Instead, should use the public API `ActiveRecord::Migration#migrate`.
|
| |\ \
| | |
| | | |
Fix hash conditions documentation
|
| | | | |
|
| |\ \ \
| |/ /
|/| | |
Remove unused variable
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
This fixes the following warnings:
```
activerecord/test/cases/relation_test.rb:231: warning: assigned but unused variable - authors_with_commented_posts
```
|
| |\ \
| | |
| | | |
Avoid begin/rescue in fixture quoting
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Scalar values like arrays and hashes can't be inserted
directly into table. Previously, the way to determine if
the value is scalar was to try quoting it. If `quote` raised
with an error than the value has to be converted to YAML.
This flow is not very obvious. Ideally we could have
a `quotable?` method in the connection, but I think
that we can avoid begin/rescue block by simply checking
if the value is Array or Hash.
https://github.com/rails/rails/commit/aa31d21f5f4fc4d679e74a60f9df9706da7de373
|
| |\ \ \
| |/ /
|/| | |
Keep INNER JOIN when merging relations
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Doing `Author.joins(:posts).merge(Post.joins(:comments))` does this
`SELECT ... INNER JOIN posts ON... LEFT OUTER JOIN comments ON...`
instead of doing
`SELECT ... INNER JOIN posts ON... INNER JOIN comments ON...`.
This behavior is unexpected and makes little sense as, basically, doing
`Post.joins(:comments)` means I want posts that have comments. Turning
it to a LEFT JOIN means I want posts and join the comments data, if
any.
We can see this problem directly in the existing tests.
The test_relation_merging_with_merged_joins_as_symbols only does joins
from posts to comments to ratings while the ratings fixture isn't
loaded, but the count is non-zero.
|
| |/ /
| |
| |
| | |
Fixes #29512.
|
| |\ \
| | |
| | | |
Fix ActiveRecord::Persistence#touch with locking
|
| |/ /
| |
| |
| |
| |
| | |
`ActiveRecord::Persistence#touch` does not work well when optimistic
locking enabled and `locking_column`, without default value, is null in
the database.
|
| |\ \
| | |
| | |
| | |
| | | |
bogdanvlviv/fix-destroy-with-locking_column-value-null
Fix destroy with locking_column value null
|
| |/ /
| |
| |
| |
| |
| |
| | |
Fix destroying existing object does not work well when optimistic
locking enabled and `locking column` is null in the database.
Follow 22a822e5813ef7ea9ab6dbbb670a363899a083af, #28914
|
| |\ \
| | |
| | | |
Updates README on rails internal dev tools
|
| | | |
| | |
| | |
| | | |
... and minor typo fix
|
| |\ \ \
| | | |
| | | | |
Use bulk INSERT to insert fixtures
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Improves the performance from O(n) to O(1).
Previously it would require 50 queries to
insert 50 fixtures. Now it takes only one query.
Disabled on sqlite which doesn't support multiple inserts.
|
| | |/ /
|/| | |
|
| |\ \ \
| | | |
| | | | |
Fix current_page? helper issue with engine root path
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
fix
fix
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Add test cases for optimistic locking
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add test to ensure that locking_column cannot be updated explicitly.
Add test to prevent regression on creating new object with
explicit value locking_column.
Related to #28318
|
| | | | | | |
|
| |\ \ \ \ \
| |_|_|/ /
|/| | | | |
prepare for Minitest 6
|
| |/ / / / |
|
| |\ \ \ \
| |_|_|/
|/| | | |
Use of ParameterFilter no longer forces `request.filtered_parameters' class to be Hash
|
| | |\ \ \ |
|
| | |\ \ \ \ |
|
| | |\ \ \ \ \ |
|
| | |\ \ \ \ \ \ |
|
| | | | | | | | | |
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
to be Hash
- Fixes issue described on #27944
- `filtered_query_string` used an Array representation of what
semantically is a key value pair: better suited for a Hash. Without
this change `filtered_params = original_params.class.new` returns an
Array with unintended consequences.
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
nodoc AC::Connection::WebSocket
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Users should never publicly be interacting with an instance of this. The instance that comes along with an `AC::Connection::Base` instance (the only thing a user should be working with) is [itself intended to be private](https://github.com/tjschuck/rails/blob/master/actioncable/lib/action_cable/connection/base.rb#L137-L140).
[ci skip]
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Fix `Relation#exists?` queries with query cache
|
