aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | | | | Missing suffixDavid Heinemeier Hansson2018-09-191-0/+0
| | | | | | |
| | * | | | | Only deliver pending emails to the mailroomDavid Heinemeier Hansson2018-09-183-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes it easier to test without triggering this behavior.
| | * | | | | Inherit from ActiveJob::Base rather than ApplicationJobDavid Heinemeier Hansson2018-09-182-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't want to trigger app-specific behavior here.
| | * | | | | Prefix queue name like we do routesDavid Heinemeier Hansson2018-09-181-1/+1
| | | | | | |
| | * | | | | Make a note for tying inbound email to exceptionDavid Heinemeier Hansson2018-09-181-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Then InboundEmail doesn't need to serialize or track the exception that went with it. The arrow will point the other way.
| | * | | | | Add callbacksDavid Heinemeier Hansson2018-09-183-2/+60
| | | | | | |
| | * | | | | Extract mailbox test suites into feature-specific slicesDavid Heinemeier Hansson2018-09-182-36/+34
| | | | | | |
| | * | | | | More scalable name!David Heinemeier Hansson2018-09-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There'll probably be other concerns we need to do around the processing.
| | * | | | | Proper orderDavid Heinemeier Hansson2018-09-181-1/+1
| | | | | | |
| | * | | | | Process inbound emails with state and exceptionsDavid Heinemeier Hansson2018-09-182-1/+51
| | | | | | |
| | * | | | | Use rails scope by defaultDavid Heinemeier Hansson2018-09-181-1/+1
| | | | | | |
| | * | | | | Add test for unsupported content typeDavid Heinemeier Hansson2018-09-182-0/+9
| | | | | | |
| | * | | | | Remember to add access protectionDavid Heinemeier Hansson2018-09-181-0/+1
| | | | | | |
| | * | | | | Use a test helper to create fixtures rather than rely on them being predefinedDavid Heinemeier Hansson2018-09-183-23/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Too much hassle to manage all the steps compared to just pointing to an .eml fixture and having it setup for you.
| | * | | | | Add basic, unauthenticated inbound emails controllerDavid Heinemeier Hansson2018-09-173-0/+40
| | | | | | |
| | * | | | | Assert the intended email was processedDavid Heinemeier Hansson2018-09-171-2/+2
| | | | | | |
| | * | | | | No byebug history plzDavid Heinemeier Hansson2018-09-171-0/+1
| | | | | | |
| | * | | | | Keep the riff raff outDavid Heinemeier Hansson2018-09-171-0/+3
| | | | | | |
| | * | | | | Save this for a little laterDavid Heinemeier Hansson2018-09-171-1/+1
| | | | | | |
| | * | | | | First end-to-end rickety testDavid Heinemeier Hansson2018-09-178-24/+656
| | | | | | |
| | * | | | | WIP: RouterDavid Heinemeier Hansson2018-09-173-0/+36
| | | | | | |
| | * | | | | Add dummy app for testingDavid Heinemeier Hansson2018-09-1778-2/+7400
| | | | | | |
| | * | | | | Wait on this for laterDavid Heinemeier Hansson2018-09-171-3/+0
| | | | | | |
| | * | | | | Full name for the jobDavid Heinemeier Hansson2018-09-171-1/+1
| | | | | | |
| | * | | | | TOC orderingDavid Heinemeier Hansson2018-09-171-1/+3
| | | | | | |
| | * | | | | Plural table nameDavid Heinemeier Hansson2018-09-171-1/+1
| | | | | | |
| | * | | | | Base -> MailboxDavid Heinemeier Hansson2018-09-173-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Won't need Base and can separate routing from execution 👍
| | * | | | | Action Mailbox -> Action MailroomDavid Heinemeier Hansson2018-09-1712-36/+36
| | | | | | |
| | * | | | | Add inbound emailDavid Heinemeier Hansson2018-09-173-0/+37
| | | | | | |
| | * | | | | Copypasta is delicious!David Heinemeier Hansson2018-09-171-1/+1
| | | | | | |
| | * | | | | SkeletonDavid Heinemeier Hansson2018-09-1711-0/+160
| | / / / /
* | | | | | Merge pull request #34791 from y-yagi/fixes_34787Yuji Yaginuma2018-12-261-0/+221
|\ \ \ \ \ \ | | | | | | | | | | | | | | Generate doc of methods provided by form builders [ci skip]
| * | | | | | Generate doc of methods provided by form builders [ci skip]yuuji.yaginuma2018-12-261-0/+221
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because method arguments are different in the methods provided by form helpers and form builders, I think these are necessary to prevent confusion. Fixes #34787
* / / / / / Specify `hosts` in bug report template.yuuji.yaginuma2018-12-251-0/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Host authentication introduced by #33145 allows only "0.0.0.0/0", "::/0" and "localhost" in the development environment. https://github.com/rails/rails/blob/4298df00ae6219b9b5b7c40f281d4fa4d66f4383/railties/lib/rails/application/configuration.rb#L33 But `rack-test` use `example.org` for default host. https://github.com/rack-test/rack-test/blob/6c07bf53adf4a4082e206561f5b9b43142fdc821/lib/rack/test.rb#L13 Therefore, if `hosts` is not specified, host authentication rejects the request. In Travis CI, this problem does not occur because `test` is specified by default in `RAILS_ENV` and `RACK_ENV`. https://docs.travis-ci.com/user/environment-variables/#default-environment-variables If user actually use it, env may not always be specified. Explicitly specify hosts in the file so that it works in any environment.
* | | | | Merge pull request #34781 from kossnocorp/patch-1Kasper Timm Hansen2018-12-241-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Make Rails Facebook-free
| * | | | | Make Rails Facebook-freeSasha Koss2018-12-241-2/+2
|/ / / / / | | | | | | | | | | If Basecamp is a Facebook-free business, then Rails should be Facebook-free framework.
* | | | | Add missing require for `IPAddr`yuuji.yaginuma2018-12-241-0/+1
| | | | | | | | | | | | | | | | | | | | Ref: https://travis-ci.org/rails/rails/jobs/469956825#L1694
* | | | | Merge pull request #34778 from yahonda/ruby25_frozen_errorKasper Timm Hansen2018-12-239-19/+7
|\ \ \ \ \ | | | | | | | | | | | | No need to handle if FrozenError is available
| * | | | | No need to handle if FrozenError is availableYasuo Honda2018-12-239-19/+7
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails 6 requires Ruby 2.5, which introduces `FrozenError` https://docs.ruby-lang.org/en/2.5.0/NEWS.html Related to #31520
* | | | | Remove unused methodsyuuji.yaginuma2018-12-231-26/+0
| | | | | | | | | | | | | | | | | | | | These were unused since 11af089cee0a0e744e267d32becfe2c66a586d31 and e35b98e6f5c54330245645f2ed40d56c74538902.
* | | | | Merge pull request #34774 from rails/fix-app-boot-for-ruby-2-4Eileen M. Uchitelle2018-12-211-2/+6
|\ \ \ \ \ | | | | | | | | | | | | Fix app boot for Ruby 2.4
| * | | | | Fix app boot for Ruby 2.4Eileen Uchitelle2018-12-211-2/+6
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have a test app that was on Ruby 2.4. When I pulled Rails master the app no longer would boot because of this change and I saw the following error: ``` SyntaxError: /Users/eileencodes/open_source/real_rails/railties/lib/rails/all.rb:18: syntax error, unexpected keyword_rescue, expecting keyword_end rescue LoadError ^ ``` Ruby 2.4 doesn't support removing redundant begins so the real issue is that this app is on Ruby 2.4 and not on Ruby 2.5. But it's super confusing for a user to understand the reason the app is failing to boot is because we need Ruby 2.5. I added this redundant begin back because we need to give a clearer error message.
* | | | | Merge pull request #34753 from ↵Eileen M. Uchitelle2018-12-213-0/+19
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | eileencodes/raise-less-confusing-error-if-handler-doesnt-exist Raise helpful error when role doesn't exist
| * | | | | Raise helpful error when role doesn't existEileen Uchitelle2018-12-213-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you try to call `connected_to` with a role that doesn't have an established connection you used to get an error that said: ``` >> ActiveRecord::Base.connected_to(role: :i_dont_exist) { Home.first } ActiveRecord::ConnectionNotEstablished Exception: No connection pool with 'primary' found. ``` This is confusing because the connection could be established but we spelled the role wrong. I've changed this to raise if the `role` used in `connected_to` doesn't have an associated handler. Users who encounter this should either check that the role is spelled correctly (writin -> writing), establish a connection to that role in the model with connects_to, or use the `database` keyword for the `role`. I think this will provide a less confusing error message for those starting out with multiple databases.
* | | | | | Merge pull request #34771 from utilum/mismatched_indentationRyuta Kamizono2018-12-211-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix Ruby 2.6 `warning: mismatched indentations at 'rescue' with 'def' at 15`.
| * | | | | | Fixes `warning: mismatched indentations at 'rescue' with 'def' at 15`.utilum2018-12-211-2/+2
|/ / / / / / | | | | | | | | | | | | | | | | | | See https://travis-ci.org/rails/rails/jobs/470890129#L2361
* | | | | | Add missing require for `String#to_d`yuuji.yaginuma2018-12-211-0/+1
| | | | | |
* | | | | | Merge pull request #34767 from y-yagi/fix_convert_string_to_bigdecimalYuji Yaginuma2018-12-211-5/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use BigDecimal provided methods to convert String to BigDecimal
| * | | | | | Use BigDecimal provided methods to convert String to BigDecimalyuuji.yaginuma2018-12-211-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `String#to_d` does not raise an exception if an invalid value is specified. So can remove exception handling. ``` $ bundle exec ruby -v -rbigdecimal -rbigdecimal/util -e 'p "123,003".to_d' ruby 2.6.0dev (2018-12-21 trunk 66474) [x86_64-linux] 0.123e3 ```
* | | | | | | Merge pull request #34742 from kamipo/row_format_dynamic_by_defaultRyuta Kamizono2018-12-213-7/+40
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | MySQL: `ROW_FORMAT=DYNAMIC` create table option by default
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-23 15:24:44 +0000