| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* A non-zero exit status allows subsequent shell commands to be chained
together such as: `rake db:reset test:prepare && rspec && cap deploy`
(if you're feeling brave :)
* Any exceptions raised during the `create` and `drop` tasks are caught
in order to print a "pretty" message to the user. Unfortunately doing
so prevents rake from aborting with a non-zero exit status to the shell.
* Therefore we re-raise the exceptions after the "pretty" message and
re-catch them in the task.
* From the task we explicitly exit with a non-zero status. This method
was chosen (rather than just letting rake fail from the exception) so
that the backtrace is suppressed and the output to stderr is
unchanged.
* Update activerecord CHANGELOG
|
| |
|
| |
|
| |
|
|
|
|
| |
Fixes #12489
|
|\
| |
| | |
newline at end of structure.sql file
|
| | |
|
|\ \
| | |
| | | |
`Relation#count` doesn't use options anymore.
|
| | |
| | |
| | |
| | | |
`Relation#maximum`, `Relation#calculate`, `perform_calculation`, `NullRelation#calculate` as they isn't used anymore.
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
jetthoughts/12415_generate_subqueries_for_relation_from_binding_params
Generate subquery for Relation passed as array condition for where
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Instead of executing 2 queries for fetching records filtered by array condition with Relation,
added generation of subquery to current query.
This behaviour will be consistent when passes Relation as hash condition to where
Closes: #12415
|
|\ \ \ \
| | | | |
| | | | | |
Fixed MRI dependent stuff in AR tests
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Every method from MRI's core classes is written in C. This means
Method#arity always returns -1 for methods with a variable number of
arguments. This is not the case with Rubinius, where, for example
Array#slice! is implemented in Ruby and has arity -2, since is
defined as def slice!(start, length = undefined)
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Related to all the other issues regarding message independent assertions
to make Rails compatible with other Ruby implementations other than MRI.
The best way here would be to have a specific error raised when modifying
frozen objects, like FrozenObjectError or something. But since Ruby
doesn't provide such a thing, we must limit the assertion to the lowest
common denominator, which is word "frozen".
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Stubbing ENV[] is not safe outside MRI. At some point after the
stubbing has occurred a backtrace is printed to the ActiveSupport
warning log: there Rubinius accesses ENV['RBX_NOCOLOR'] to determine
if it should print the backtrace with colors or not, causing the
stub to fail. Other implementations might access ENV in a different
way too, we just can't predict it.
The only thing we can do here is to actually set the ENV with what
we want and restore it afterwards.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
jetthoughts/informative_raise_message_for_incorrect_association
Make missed association exception message more informative
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | | |
Add target class name, which should have missed association on preload,
into exception message to simplify detecting problem part.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
schuetzm/stdout-logging-with-implicit-development-env
Make logging to stdout work again with implicit `development` env
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix wrong variable name used in the select_day method documentation
|
| | | | | |
| | | | | |
| | | | | | |
The variable name created in the example is `my_date`, the methods were using `my_time` instead.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Keep code consistent with previous code blocks.
|
| | | | | | |
| | | | | | |
| | | | | | | |
[ci skip]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Change `map` to `map!` to save extra array creation on new array
|
| | |_|_|_|/ /
| |/| | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Drop unused iterator var
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Includes with persistent select, fixes #11773
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
was overwritten.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Some fixes in docs [ci skip]
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Update a link to point to right section in api docs
Fix a typo
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
Fix a writing mistake
|
|/ / / / / / /
| | | | | | |
| | | | | | | |
A small mistake found in the line of ```The default error is "can't be empty"``` for ```:presence``` helper. ```empty``` word changed to ```blank```.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This reverts commit e5f5a838b96a362534d9bb60d02334439ed9784c, reversing
changes made to d7567f3290a50952494e9213556a1f283a6cf3a0.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
flatten and flatten! methods for ActiveSupport::Duration
|
| |/ / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
No need to require rbconfig as we are using Gem.ruby
|
|/ / / / / / / |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
we don't need to walk back up the node's parents when we have the parent
on the stack
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Now that we merge trees from the top down, we don't need to search
through the whole tree for particular nodes, just walk it and merge.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Merge JoinDependency objects as outer joins
|
| | | | | | | |
|
| | | | | | | |
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | | |
Stop writing terrible code Aaron. This is Ruby, not Scheme
|