| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / / / / / / / |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This partially reverts commit ac02df5c7827630a91acd9a6b916db9eda1f38b4.
[ci skip]
|
|\ \ \ \ \ \ \ \
| |_|_|_|/ / / /
|/| | | | | | | |
minor text change [ci skip]
|
| | | | | | | | |
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
repinel/revert-19878-replace_alias_chains_with_prepend
Revert "Replace use of alias chains with prepend at core_ext/date and…
|
| | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
core_ext/time"
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
not require mail file
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
```
it added in this commit (https://github.com/rails/rails/commit/2a25c4ce6da6ea23ebdf44e7eb2d2441dbea20a1), now no warnings occur.
```
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | |
| | | | | |
| | | | | |
| | | | | | |
Update docs for ActiveRecord `serialize`
[ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
For certain column types, using `serialize` is unnecessary, or the user
may get unexpected contents back from the DB adapter (which is handling
some basic deserialization for them). Call this out in the
documentation.
For background, see:
https://gist.github.com/ernie/33f75f2294885b9806f9
https://twitter.com/erniemiller/status/604262907442905090
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Bundler 1.10 should work now!
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 81b42970f02d07ca5007bbce920b489d80172636.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 410d246bc0ddabe47f0bf54116be9087bd3d4bda.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 9ff901bd3e046b0373b28459269146707b5bf8c9.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove unused code.
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
Code was moved into the `assign` method.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix warning about ambiguous first argument
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Replace use of alias chains with prepend at core_ext/date and core_ext/time
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
See https://github.com/bundler/bundler/issues/3681
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Updating the guides for Enumerable#pluck
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
vngrs/remove_already_defined_methods_in_rack_request
Remove already defined methods in super class of ActionDispatch::Request class
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
These methods had defined in 2004 by dhh in initial commit and `ActionDispatch::Request`
class has been inherited from `Rack::Request` class in 2009 by josh.
In 2014 these methods and more of them defined in `Rack::Request` class
so we don't need them anymore in rails codebase.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove use of mocha from Active Model
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Avoid E constant clashing with Minitest defined version.
|
| | |_|_|_|/ / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Minitest sets an E constant to an empty string to save GC time.
This clashes with autoloading tests which define an E constant.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Add Enumerable#pluck.
|
| | |/ / / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | | |
Allows fetching the same values from arrays as from ActiveRecord associations.
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Fix the shadowing warning for `reflection`
|
|/ / / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This is a usability change to fix a quirk from our definition of partial
writes. By default, we only persist changed attributes. When creating a
new record, this is assumed that the default values came from the
database. However, if the user provided a default, it will not be
persisted, since we didn't see it as "changed". Since this is a very
specific case, I wanted to isolate it with the other quirks that come
from user provided default values. The number of edge cases which are
presenting themselves are starting to make me wonder if we should just
remove the ability to assign a default, in favor of overriding
`initialize`. For the time being, this is required for the attributes
API to not have confusing behavior.
We had to delete one test, since this actually changes the meaning of
`.changed?` on Active Record models. It now specifically means
`changed_from_database?`. While I think this will make the attributes
API more ergonomic to use, it is a subtle change in definition (though
not a backwards incompatible one). We should probably figure out the
right place to document this. (Feel free to open a PR doing that if
you're reading this).
/cc @rafaelfranca @kirs @senny
This is an alternate implementation of #19921.
Close #19921.
[Sean Griffin & Kir Shatrov]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This is a variant implementation of the changes proposed in #19914.
Unlike that PR, the change in behavior is isolated in its own class.
This is to prevent wonky behavior if a Proc is assigned outside of the
default, and it is a natural place to place the behavior required by #19921
as well.
Close #19914.
[Sean Griffin & Kir Shatrov]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | | |
config.static_index configures directory Index "index.html" filename
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Set `config.static_index` to serve a static directory index file not
named `index`. For example, to serve `main.html` instead of `index.html`
for directory requests, set `config.static_index` to `"main"`.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove unused package tasks
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
We are using `all:build` now.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
removed erroneous line. Corrected presence validation example.
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Addresses #20343.
Removes erroneous line of code in the sample codeblock.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
[ci skip] Fix block parameter of assert_no_difference
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Deprecate `:nothing` option for render method
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
`head` method works similar to `render` method with `:nothing` option
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Give credit to extra contributor for Base.reload fix
|