| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Allow Pathname for require dependency
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Extract `.next_migration_number` into module for third party generators.
|
|/ / |
|
| | |
|
|\ \
| | |
| | |
| | | |
tamird-fix-ip-spoof-errors
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
marshalling between processes does not work with an in-memory db.
This breaks the `test_sqlite3_mem` run (see stacktrace below).
After that failure most tests start to fail randomly.
```
/Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:512:in `table_structure': Could not find table 'posts' (ActiveRecord::StatementInvalid)
from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:399:in `columns'
from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:93:in `block in prepare_default_proc'
from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:44:in `yield'
from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:44:in `columns'
from /Users/senny/Projects/rails/activerecord/lib/active_record/model_schema.rb:208:in `columns'
from /Users/senny/Projects/rails/activerecord/lib/active_record/model_schema.rb:249:in `column_defaults'
from /Users/senny/Projects/rails/activerecord/lib/active_record/locking/optimistic.rb:171:in `column_defaults'
from /Users/senny/Projects/rails/activerecord/lib/active_record/core.rb:167:in `initialize'
from /Users/senny/Projects/rails/activerecord/lib/active_record/inheritance.rb:27:in `new'
from /Users/senny/Projects/rails/activerecord/lib/active_record/inheritance.rb:27:in `new'
from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1368:in `block in test_marshal_between_processes'
from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1366:in `fork'
from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1366:in `test_marshal_between_processes'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:110:in `block (3 levels) in run'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:208:in `capture_exceptions'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:107:in `block (2 levels) in run'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:260:in `time_it'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:106:in `block in run'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:296:in `on_signal'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:280:in `with_info_handler'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:105:in `run'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:268:in `block (2 levels) in run'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:267:in `each'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:267:in `block in run'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:296:in `on_signal'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:285:in `with_info_handler'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:266:in `run'
from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `block in __run'
from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `map'
from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `__run'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:115:in `run'
from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:46:in `block in autorun'
```
/cc @tenderlove
|
|\ \ \
| | | |
| | | | |
Fixed issue #12327
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
jaredbeck/fixes_guide_re_action_on_unpermitted_parameters
Fixes incorrect spelling of `action_on_unpermitted_parameters` in guide
|
|/ / / /
| | | |
| | | |
| | | | |
See `actionpack/test/controller/parameters/raise_on_unpermitted_params_test.rb`
|
|\ \ \ \
| | | | |
| | | | | |
Closes #12293. Strong parameters should permit nested number as key.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Migrations Guide: Add semicolon to sentences before code block [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Thread safety fixes
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
From now on only the `[]=` method is allowed to modify the internal states hashes.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
TS::Cache#compute_if_absent guarantees that only a single thread will get to execute the provided block for a given key.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
jetthoughts/11376_has_many_assoc_respect_scope_on_build
Removed where_values_hash from AR::NullRelation
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
In order to build associated records for owners which has not been saved
need to get where values to use as default attributes.
But for new record owner uses `ActiveRecord::NullRelation` which
override `where_values_hash` to return empty hash stub.
`where_values_hash` is not used to invoke any sql query, but good to
build others chains (even will be never executed) like:
```ruby
post = Post.new
admin_comment = post.admin_comments.build
assert_equal 'Admin', admin_comment.author
```
Closes #11376, #11676, #11675
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Cleanup identitymap logger from LogSubscriber
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Also renaming ivar @odd_or_even to @odd
|
|\ \ \ \ \ \ \ \ \
| |_|_|/ / / / / /
|/| | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
The documentation is showing the link_to method as just returning
the contents of the url_for method. It should be returning an
"<a>" tag with the correct href set.
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
incorrect url
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
I've found two incorrects urls for adding ':' at the end of the url
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
surplus ':' character in url
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This reverts commit faeb33dc036e4f707491c91a23ee3e990573141b.
Reason: Code changes can't be done on docrails
|
| | | | | | | | | |
|
| | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \
| |_|_|/ / / / / /
|/| | | | | | | | |
Migrations Guide: Fix line length [ci skip]
|
|/ / / / / / / / |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
side of a hm:t association along with preloading.
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
Fixed grammatical typo in configuring.md guide.
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | |_|/ / / /
| |/| | | | | |
Getting Started Guide: Fix code container in Chapter 5.2 [ci-skip]
|