Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | | | Merge pull request #8938 from colinbm/date_select_value | Steve Klabnik | 2013-01-14 | 4 | -4/+57 | |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | Rename :value to :selected for date_select, and add missing tests/docs | |||||
| * | | | | | | Rename :value option to :selected, in line with other select helpers | Colin Burn-Murdoch | 2013-01-14 | 4 | -4/+57 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add tests for time & datetime. Add documentation. | |||||
* | | | | | | | Revert benchmark helper regression. Use a #capture within a #benchmark | Jeremy Kemper | 2013-01-14 | 3 | -39/+3 | |
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | block. Breaks benchmark calls that return non-String values otherwise. Revert "add benchmark helper that works in erb" This reverts commit 904e544cc8f5846de7c31827bb5556c6a238c0de. Conflicts: actionpack/lib/action_view/helpers.rb actionpack/lib/action_view/helpers/benchmark_helper.rb actionpack/test/template/benchmark_helper_test.rb | |||||
* | | | | | | Test to allow Range including DateTime and DateTime::Infinity | gsphanikumar | 2013-01-14 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Closes #8587 | |||||
* | | | | | | Merge pull request #8916 from josemota/collection-with-block | Rafael Mendonça França | 2013-01-13 | 2 | -4/+53 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collection radio buttons and collection check boxes through FormBuilder render the provided block. Closes #8897 | |||||
| * | | | | | | Collection radio buttons and collection check boxes through FormBuilder render | José Mota | 2013-01-12 | 2 | -4/+53 | |
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the provided block. In the case of having a form_for method being called, the block for each collection would not be passed and thus the result expected was always the same. This patch passes the block to the original method like it would be assumed. | |||||
* | | | | | | Add regression test to #8907 | Rafael Mendonça França | 2013-01-14 | 1 | -0/+31 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #8917 from adomokos/adding_more_tests_to_activemodel_model | Rafael Mendonça França | 2013-01-13 | 1 | -0/+6 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Adding tests for ActiveModel::Model | |||||
| * | | | | | | Adding tests for ActiveModel::Model | Attila Domokos | 2013-01-12 | 1 | -0/+6 | |
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Verifying persisted? is false when Model initialized * Passing nil to Model should not blow up * Changing test name to the one suggested in pull request comment | |||||
* | | | | | | Merge pull request #8925 from colinbm/date_select_value | Steve Klabnik | 2013-01-13 | 3 | -1/+26 | |
|\ \ \ \ \ \ | | |/ / / / | |/| | | | | Allow to override the value on date_select | |||||
| * | | | | | Allow value to be set on date_select | Colin Burn-Murdoch | 2013-01-13 | 3 | -1/+26 | |
|/ / / / / | ||||||
* | | | | | Remove WIP from Working With JavaScript Guide. | Steve Klabnik | 2013-01-13 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | | | | | Now that we've fixed the fibs example, this is good to go. | |||||
* | | | | | Associaton -> Association | Steve Klabnik | 2013-01-13 | 1 | -2/+2 | |
|/ / / / | ||||||
* | | | | Fix AR tests due to Mysql constant not being defined | Carlos Antonio da Silva | 2013-01-12 | 3 | -7/+5 | |
| | | | | ||||||
* | | | | Deprecate `Rails::Generators::ActiveModel#update_attributes` | Carlos Antonio da Silva | 2013-01-12 | 2 | -0/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deprecate #update_attributes in favor of `#update`. ORMs that implement `Generators::ActiveModel#update_attributes` should change to `#update`. Scaffold controller generators should change calls like: @orm_instance.update_attributes(...) to: @orm_instance.update(...) This goes along with the addition of `ActiveRecord::Base#update`, introduced in cb2bd4aa619d9329c42aaf6d9f8eacc616ce53f4. | |||||
* | | | | Bring back "database already exists" messages when running rake tasks | Carlos Antonio da Silva | 2013-01-12 | 7 | -20/+47 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running tasks such "rake db:setup", instead of showing messages like "db_development already exists", it was showing a big stack trace and a message "Couldn't create database for ..." with the configuration options, a very confusing message with a big trace. This brings back the functionality present in 3-2, showing the same message. | |||||
* | | | | Merge pull request #8907 from rubys/master | Rafael Mendonça França | 2013-01-11 | 1 | -1/+2 | |
|\ \ \ \ | |/ / / |/| | | | Fix regression introduced in pull 8812 | |||||
| * | | | Fix regression introduced in pull request 8812 | Sam Ruby | 2013-01-11 | 1 | -1/+2 | |
|/ / / | | | | | | | | | | See https://github.com/rails/rails/pull/8812#commitcomment-2416514 | |||||
* | | | Merge pull request #8896 from NARKOZ/patch-5 | Rafael Mendonça França | 2013-01-11 | 1 | -2/+2 | |
|\ \ \ | | | | | | | | | remove_possible_method -> remove_method | |||||
| * | | | remove_possible_method -> remove_method | Nihad Abbasov | 2013-01-11 | 1 | -2/+2 | |
|/ / / | | | | | | | | | | Date#to_time and Date#xmlschema methods defined in Ruby 1.9.3 | |||||
* | | | Add changelog entry for scaffold generator and jbuilder changes | Carlos Antonio da Silva | 2013-01-11 | 1 | -0/+9 | |
| | | | | | | | | | | | | | | | | | | | | | Introduced in 3bfd99defb559af0b017ee920ca714aa1e367fdd. Related to #8840. [ci skip] | |||||
* | | | Merge pull request #8882 from goshakkk/clearer-conditional | Carlos Antonio da Silva | 2013-01-11 | 1 | -3/+3 | |
|\ \ \ | | | | | | | | | Clearer conditional in constraint match check | |||||
| * | | | clearer conditional in constraint match check | Gosha Arinich | 2013-01-10 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | Merge pull request #8866 from adomokos/adding_more_tests_to_errors_test | Carlos Antonio da Silva | 2013-01-11 | 1 | -0/+53 | |
|\ \ \ \ | | | | | | | | | | | Adding tests to cover untested methods in errors_tests.rb | |||||
| * | | | | Covering untested methods for ActiveModel::Errors | Attila Domokos | 2013-01-10 | 1 | -0/+53 | |
| | | | | | ||||||
* | | | | | Merge pull request #8623 from virusman/form_helpers_collectionproxy_fix | Jon Leighton | 2013-01-11 | 2 | -1/+24 | |
|\ \ \ \ \ | | | | | | | | | | | | | Fixed nested fields bug when called with AssociationProxy | |||||
| * | | | | | Test nested fields with AssociationProxy mockup & fix AssociationProxy ↵ | virusman | 2012-12-27 | 2 | -1/+24 | |
| | | | | | | | | | | | | | | | | | | | | | | | | support in form helper | |||||
* | | | | | | Merge pull request #8568 from inossidabile/fix-in_clause_length | Jon Leighton | 2013-01-11 | 3 | -8/+13 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Correct source for in_clause_length for eager loading (Fix for #8474) | |||||
| * | | | | | | Eager loading made to use relation's in_clause_length instead of host's one ↵ | Boris Staal | 2012-12-20 | 3 | -8/+13 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (fixes #8474) | |||||
* | | | | | | | Merge pull request #8855 from dylanahsmith/parse-non-object-json-params | Jeremy Kemper | 2013-01-10 | 3 | -2/+13 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Fix json params parsing regression for non-object JSON content. | |||||
| * | | | | | | | Fix json params parsing regression for non-object JSON content. | Dylan Smith | 2013-01-11 | 3 | -2/+13 | |
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | Fixes #8845. | |||||
* | | | | | | | All green with Ruby 2.0 :green_heart: | Rafael Mendonça França | 2013-01-11 | 1 | -3/+0 | |
| | | | | | | | ||||||
* | | | | | | | Use thor master to make rails work with Ruby 2.0 | Rafael Mendonça França | 2013-01-11 | 1 | -0/+2 | |
| | | | | | | | ||||||
* | | | | | | | thread_safe is a dependency of active_support | Rafael Mendonça França | 2013-01-11 | 1 | -1/+0 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #8887 from rwz/controller-scaffold-codestyle | Rafael Mendonça França | 2013-01-10 | 3 | -4/+4 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Controller scaffold codestyle | |||||
| * | | | | | | | More consistent quotes in scaffold generator | Pavel Pravosud | 2013-01-11 | 2 | -3/+3 | |
| | | | | | | | | ||||||
| * | | | | | | | Changed if ! to unless | Pavel Pravosud | 2013-01-11 | 1 | -1/+1 | |
| | | | | | | | | ||||||
* | | | | | | | | Merge pull request #8886 from rwz/specify-jbuilder-version | Guillermo Iguaran | 2013-01-10 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | Specified jbuilder version | |||||
| * | | | | | | | Specified jbuilder version | Pavel Pravosud | 2013-01-11 | 1 | -1/+1 | |
|/ / / / / / / | ||||||
* | | | | | | | Merge pull request #8884 from mattdbridges/array-access-doc-fixes | Guillermo Iguaran | 2013-01-10 | 1 | -4/+4 | |
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | | Updating Array access docs more consistent | |||||
| * | | | | | | Updating Array access docs more consistent | Matt Bridges | 2013-01-10 | 1 | -4/+4 | |
|/ / / / / / | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | | Merge pull request #8869 from goshakkk/guides-asset-pipeline-tilt | Guillermo Iguaran | 2013-01-10 | 1 | -1/+25 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Add asset pipeline guides section on implementing & registering own engines | |||||
| * | | | | | | add asset pipeline guides section on implementing & registering own engines | Gosha Arinich | 2013-01-10 | 1 | -1/+25 | |
| | | | | | | | ||||||
* | | | | | | | Relax bundler dep until 1.3.0 is actually released. | Jeremy Kemper | 2013-01-10 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "Bump bundler dep to 1.3.0.pre.4+ to introduce 'bundle binstubs <gem>'" This reverts commit e00b8ecf1ad8984b760f12e61247820613aec4ee. Revert "Use bundler --pre for travis builds" This reverts commit 4d240ec20a70122b7e69c790a37d2be14e1ff038. | |||||
* | | | | | | | Include jbuilder by default and rely on its scaffold generator to show json ↵ | David Heinemeier Hansson | 2013-01-10 | 6 | -99/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | API. The default scaffold will now just create HTML if the user actively opts out of jbuilder | |||||
* | | | | | | | Merge pull request #8878 from senny/add_performance_test_extraction_to_guide | Guillermo Iguaran | 2013-01-10 | 1 | -0/+1 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Mention performance test extraction in 4.0 guide | |||||
| * | | | | | | | mention performance test extraction in 4.0 guide | Yves Senn | 2013-01-10 | 1 | -0/+1 | |
|/ / / / / / / | ||||||
* | | | | | | | Merge pull request #8876 from senny/extract_performance_tests | Guillermo Iguaran | 2013-01-10 | 33 | -1640/+20 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Extract ActionDispatch::PerformanceTest | |||||
| * | | | | | | | remove the rails guide on performance testing | Yves Senn | 2013-01-10 | 3 | -692/+0 | |
| | | | | | | | | ||||||
| * | | | | | | | remove performance tests from the default stack | Yves Senn | 2013-01-10 | 10 | -47/+5 | |
| | | | | | | | |