| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
removed already
|
| | | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
`ActionView::Helpers::RecordTagHelper`
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix false positive test related to wrong app root path.
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Without setting root config, `config.paths["config/secrets"]`
located in https://github.com/rails/rails/blob/84eb498f84ebc5d1be0b0db6f7bca9da3d679ca6/railties/lib/rails/application.rb#L390
always returned empty list.
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Match destroyed_by_association for has_one to has_many
|
| | | |_|_|_|_|_|/
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
When a has_many association is destroyed by `dependent: destroy`,
destroyed_by_association is set to the reflection, and this can be
checked in callbacks. This matches that behaviour for has_one
associations.
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Use frozen-string-literal in ActiveRecord
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This fixes the following failures.
https://travis-ci.org/rails/rails/jobs/253990014
|
| | | |_|_|/ / / /
| |/| | | | | | |
|
| | |_|/ / / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This reverts commit b6ad4052d18e4b29b8a092526c2beef013e2bf4f.
This is not something that the majority of Active Record should be
testing or care about. We should look at having fewer places rely on
these details, not make it easier to rely on them.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove log directory in test postprocessing
|
| |/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
The "log" is directory. So it is necessary to use `FileUtils.rm_rf`.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add jQuery to test/ujs/vendor files for testing rails-ujs
|
| | |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
... so that we can run most, if not all, of rails-ujs
tests without necessarily requiring an internet connection.
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Make `rails yarn:install` ignore dev dependencies
|
| | |/ / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add Expiry & Purpose to Message Verifier
|
| |/ / / / / / |
|
| |/ / / / / |
|
| |\ \ \ \ \
| |_|_|_|/
|/| | | | |
Add purpose and expiry to messages encrypted using Message Encryptor
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Fix `warning: circular argument reference`
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This fixes the following warnings:
```
rails/activejob/lib/active_job/test_helper.rb:119: warning: circular argument reference - except
rails/activejob/lib/active_job/test_helper.rb:166: warning: circular argument reference - except
```
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Create `rails@localhost` user on travis ci
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Looks like that latest CI failure is due to missing `rails@localhost`.
Creating the user may solve the issue.
https://travis-ci.org/rails/rails/jobs/254996063#L831
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
[ci skip]Replace jquery-ujs with rails-ujs
|
| |/ / / / |
|
| |\ \ \ \
| |_|_|/
|/| | | |
Make preload query to preparable
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently preload query cannot be prepared statements even if
`prepared_statements: true` due to array handler in predicate builder
doesn't support making bind params. This makes preload query to
preparable by don't passing array value if possible.
|
| |\ \ \ \
| | | | |
| | | | | |
Fix type casting a time for MariaDB
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Context #24542.
Since 8ebe1f2, it has lost stripping date part for a time value. But I
confirmed it is still needed even if MariaDB 10.2.6 GA.
MariaDB 10.2.6, `prepared_statements: true`:
```
% ARCONN=mysql2 be ruby -w -Itest test/cases/time_precision_test.rb -n test_formatting_time_according_to_precision
Using mysql2
Run options: -n test_formatting_time_according_to_precision --seed 37614
F
Failure:
TimePrecisionTest#test_formatting_time_according_to_precision [test/cases/time_precision_test.rb:53]:
Failed assertion, no message given.
bin/rails test test/cases/time_precision_test.rb:46
Finished in 0.040279s, 24.8268 runs/s, 24.8268 assertions/s.
1 runs, 1 assertions, 1 failures, 0 errors, 0 skips
```
|
| |\ \ \ \
| | | | |
| | | | | |
Assign `content_type` only once
|
| | | |/ /
| |/| | |
|
| |\ \ \ \
| | | | |
| | | | | |
Bugfix: unscope(where: [columns]) would not remove the correct binds
|
| | |\ \ \ \
| |/ / / /
|/| | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
cswilliams/rescue_postgres_connection_errors_on_dealloc
Catch postgres connection errors when trying to dealloc
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
connection_active? will sometimes return true when the connection is actually dead/disconnected (see #3392 for a discussion of why this is). When this happens, a query is run on the dead connection which causes various postgres connection errors to be raised. This fix catches any such errors and ignores them.
Closes #29760
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add `except` option for ActiveJob::TestHelper methods
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
kamipo/fix_unscoping_default_scope_with_sti_association
Fix unscoping `default_scope` in STI associations
|
| | | | | | | | | |
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Since 5c71000, it has lost to be able to unscope `default_scope` in STI
associations. This change will use `.empty_scope?` instead of
`.values.empty?` to regard as an empty scope if only have
`type_condition`.
|
| |/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Dates are able to be natively handled by the mysql2 gem. libmysql (and
the wire protocol) represent each portion of the date as an integer,
which is significantly faster to encode and decode. By passing the Ruby
date objects through directly, we can save a good bit of time and
memory.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix typo s/rause/raise/
|
| |/ / / / / / / |
|
| | | | | | | | |
|
| | | | | | | | |
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
This method needs to be protected.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix `JoinDependency` with using a custom table
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Without this fix, `JoinDependency` doesn't use a custom table alias:
```
% ARCONN=sqlite3 be ruby -w -Itest test/cases/relations_test.rb -n test_using_a_custom_table_with_joins_affects_the_wheres
Using sqlite3
Run options: -n test_using_a_custom_table_with_joins_affects_the_wheres --seed 14531
E
Error:RelationTest#test_using_a_custom_table_with_joins_affects_the_wheres:
ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: posts.author_id: SELECT "omg_posts".* FROM "posts" "omg_posts" INNER JOIN "authors" ON "authors"."id" = "posts"."author_id" WHERE "omg_posts"."title" = ? LIMIT ?
```
|
