| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
**before**
```
$ ./bin/rails g g
Could not find generator 'g'. Maybe you meant nil?
Run `rails generate --help` for more options.
```
**after**
```
$ ./bin/rails g g
Could not find generator 'g'.
Run `rails generate --help` for more options.
```
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Ensure that the app generator skips action mailbox when `--skip-active-record` is given
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`--skip-active-record` is given
Related to https://github.com/rails/rails/pull/34816#issuecomment-450378366
Follow up https://github.com/rails/rails/commit/ddaf06779aa51d5d1ca462c21c53f2ed169a0d2f
|
|/ / / / / |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove mention about `receive.action_mailer` from the AS instrumentation guide
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Since e3f832a7433a291a51c5df397dc3dd654c1858cb `ActionMailer::Base.receive` is
deprecated.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up to d082439cf7e577e266bfeb7b443569f323df1673
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
directly
Since `migration_context` has `migrations_paths` itself and provides
methods which returning values from parsed migration files, so there is
no reason to use the `parse_migration_filename` low level API directly.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`connection.assume_migrated_upto_version`
Since #31727, `migrations_paths` in `assume_migrated_upto_version` is no
longer used.
|
| | | | |
| | | | |
| | | | |
| | | | | |
This was introduced at https://github.com/rails/rails/commit/cfa1df4b07bee5b2bbcbf9edd2ac287b4fb23c18#diff-b36b9c41be30b05dc14d09d7f3b192efR436.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since we've addressed the warning "warning: shadowing outer local
variable" frequently.
2c325182b84ea4c75855c777b25de0f15fd218e5
df76eaa4f1619dfbc024235f444c602eb6d6775a
b86c2a6767b939c420687db7df078625c702dc7a
b658743ac2a69d196d283e780816f5ad4a305753
b18f2fe96debdcd0744f99101d1a1e0d42c41eaa
|
|\ \ \ \ \
| | | | | |
| | | | | | |
ActiveStorage: Don’t include an undefined X-CSRF-Token header when creating a blob record
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If there is not a `csrf-token` meta tag in the document, the blob record
XHR was including an `X-CSRF-Token` header set to the string
"undefined." Instead of setting it to undefined, it should not be
included in the absence of a meta tag.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Reuse AR::Association#find_target method
|
| | | | | | |
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up #34795.
See also f1a30d8ad5ae17e6202fd3a126027378773dcaea.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Follow up 34786
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
```
rails/actionmailbox$ bundle exec rake tests
(snip)
...
rails/activerecord/lib/active_record/persistence.rb:48: warning: in `create!':
the last argument was passed as a single Hash
rails/actionmailbox/app/models/action_mailbox/inbound_email/message_id.rb:21:
warning: although a splat keyword arguments here
...
(snip)
```
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Follow up #34786
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Import Action Mailbox
|
| |\ \ \ \ \ |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Rails 6 will require Ruby 2.5 or newer. See rails/rails#34754.
|
| | | | | | | |
|
| | | | | | | |
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | | |
Added logging when Message ID wasn't extracted
|
| | |/ / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Running `./bin/rails generate mailbox application --no-test-framework` generates:
```
class ApplicationMailbox < ApplicationMailbox
def process
end
end
```
which is not correct for the application mailbox. It shouldn't
respond to process but it should contain a routing hint.
Generally generators aren't meant to be used like the previous commit.
The mailbox generator can certainly add in the ApplicationMailbox
if missing, but it shouldn't be called with "application" as an argument.
Also adds back auto inserting an `ingress` config line in
`config/environmnets/production.rb`.
Fixes #13.
[Kasper Timm Hansen, Andrew Babichev]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fits with rails/generators/channel containing:
- channel_generator.rb
- templates/
- USAGE
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Generators only have the public `process` action, so there's nothing
else to generate here.
Skip the needless indirection.
|
| | | | | | | |
|
| | | | | | | |
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | | |
Subtile mention of generator inside README
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Just a small mention that we can use generators inside README.
|
| | |\ \ \ \ \ \
| | | |/ / / / /
| | |/| | | | | |
Set ruby >= 2.4.1 as min required version
|
| | |/ / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
This matches Rails master, and it should make TravisCI green.
|
| | | | | | | |
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix Rails generators
|