aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use require_dependency inside Active StorageEugene Kenny2018-02-142-3/+9
| | | | | | | | | | | | | | | Active Storage is an engine which means its models, jobs and controllers are autoloaded by Rails rather than Ruby. Unfortunately this means it's subject to the same gotchas as applications, including this one: http://guides.rubyonrails.org/v5.1.4/autoloading_and_reloading_constants.html#when-constants-aren-t-missed-qualified-references On Ruby < 2.5, constants nested under classes can't be autoloaded by Rails if a top level constant already exists with the same name. To avoid clashing with constants defined in users' applications or gems, we can use `require_dependency` to ensure that the nested constants are loaded before they're used.
* Merge pull request #30941 from ↵Rafael França2018-02-1416-14/+454
|\ | | | | | | | | toptal/introduce-custom-serializers-to-activejob-arguments Introduce custom serializers to ActiveJob arguments
| * Add CHANGELOG entryRafael Mendonça França2018-02-141-0/+3
| |
| * Add tests to serialize and deserialze individuallyRafael Mendonça França2018-02-141-0/+43
| | | | | | | | | | This will make easier to be backwards compatible when changing the serialization implementation.
| * Simplify the implementation of custom argument serializersRafael Mendonça França2018-02-1413-281/+192
| | | | | | | | | | | | | | | | | | | | | | | | | | We can speed up things for the supported types by keeping the code in the way it was. We can also avoid to loop trough all serializers in the deserialization by trying to access the class already in the Hash. We could also speed up the custom serialization if we define the class that is going to be serialized when registering the serializers, but that will remove the possibility of defining a serialzer for a superclass and have the subclass serialized using it.
| * Improve documentation on custom serializersRafael Mendonça França2018-02-144-79/+47
| |
| * Add configuration to set custom serializersRafael Mendonça França2018-02-142-0/+8
| |
| * No need to require a autoloaded constantRafael Mendonça França2018-02-141-1/+0
| |
| * Add serializers for Time, Date and DateTimeRafael Mendonça França2018-02-147-2/+77
| |
| * Allow serializers to be used either as classes or objectsRafael Mendonça França2018-02-1410-124/+110
| |
| * Add symbol and duration serializersRafael Mendonça França2018-02-144-2/+52
| |
| * Only add one more custom key in the serialized hashRafael Mendonça França2018-02-146-51/+59
| | | | | | | | | | | | | | Now custom serialziers can register itself in the serialized hash using the "_aj_serialized" key that constains the serializer name. This way we can avoid poluting the hash with many reserved keys.
| * Define the interface of a SerializerRafael Mendonça França2018-02-141-0/+18
| |
| * Remove unnecessary qualified constant lookupsRafael Mendonça França2018-02-145-11/+11
| |
| * Simplify the implementation of custom serialziersRafael Mendonça França2018-02-143-41/+37
| | | | | | | | | | Right now it is only possible to define serializers globally so we don't need to use a class attribute in the job class.
| * Remove non-default serializersEvgenii Pecherkin2018-02-1410-163/+72
| |
| * Introduce serializers to ActiveJobEvgenii Pecherkin2018-02-1419-136/+602
| |
* | Merge pull request #31993 from tjschuck/rdoc_formatting_fixRafael França2018-02-141-1/+1
|\ \ | |/ |/| Rdoc formatting fix: <b> instead of MD-style asterisks
| * Rdoc formatting fix: <b> instead of MD-style asterisksT.J. Schuck2018-02-141-1/+1
| | | | | | | | [ci skip]
* | Don't force people to upgrade i18n gemRafael Mendonça França2018-02-142-2/+2
|/
* Update Gemfile.lockRafael Mendonça França2018-02-141-2/+2
|
* Merge pull request #31991 from radar/bump-i18n-to-one-dot-ohRafael França2018-02-141-1/+1
|\ | | | | Bump i18n to 1.0
| * Bump i18n to 1.0Ryan Bigg2018-02-141-1/+1
| |
* | Document MuPDF version requirementGeorge Claghorn2018-02-131-1/+1
| |
* | Merge pull request #31978 from claudiob/don-t-overwrite-master-keyYuji Yaginuma2018-02-132-2/+5
|\ \ | | | | | | Don't overwrite config/master.key even on --force
| * | Don't overwrite config/master.key even on --forceclaudiob2018-02-122-2/+5
|/ / | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/pull/31957#issuecomment-364817423 The purpose of `--force` is not to have any prompt whether a file should be kept or overwritten. In general, all existing files should be overwritten. However, `config/master.key` is special because it is git-ignored, and overwriting it will cause the app not to run (since there won't be a way to decrypt the credentials). As a result, it's probably better to keep the existing config/master.key.
* | Merge pull request #31970 from fatkodima/active_storage-unattached-scopeRafael França2018-02-122-0/+19
|\ \ | | | | | | Add ActiveStorage::Blob.unattached scope
| * | Add ActiveStorage::Blob.unattached scopefatkodima2018-02-122-0/+19
| | |
* | | Do not update `load_defaults` version when running `app:update` (#31951)Yuji Yaginuma2018-02-134-2/+26
| | | | | | | | | | | | | | | Incompatible settings are included in the settings set by `load_defaults`. So, I think that target version should be updated by a user when becomes available, and should not be updated with `app:update`.
* | | Doc: fixes typo `cache:` -> `compress:`Joseph Page2018-02-121-1/+1
| | | | | | | | | | | | | | | | | | [ci skip] Closes #31967
* | | Merge pull request #31971 from ydakuka/patch-1Rafael França2018-02-121-9/+9
|\ \ \ | | | | | | | | Change structure in the AS core extensions guide [ci skip]
| * | | Change structure of AS core extensions [ci skip]Yauheni Dakuka2018-02-121-9/+9
|/ / /
* / / Add test to make sure pick works in a NullRelationRafael Mendonça França2018-02-121-0/+2
|/ /
* | Merge pull request #31968 from wojtodzio/fix-activestorage-blob-includesRafael França2018-02-121-1/+3
|\ \ | | | | | | ActiveStorage: use full class names when including concerns to avoid collisions
| * | Use full class names when including concerns to avoid collisionsWojtek Wrona2018-02-121-1/+3
|/ /
* | Merge pull request #31953 from jameslovejoy/improve-wording-getting-startedEileen M. Uchitelle2018-02-121-13/+13
|\ \ | | | | | | Improve wording in getting started guide
| * | Improve wording in getting started guideJames Lovejoy2018-02-091-13/+13
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #31962 from ydakuka/patch-1Ryuta Kamizono2018-02-121-1/+1
|\ \ \ | | | | | | | | Missing parentheses [ci skip]
| * | | Remove parentheses [ci skip]Yauheni Dakuka2018-02-121-1/+1
|/ / /
* | | Add missing requireGeorge Claghorn2018-02-111-0/+2
| | |
* | | Merge pull request #31957 from claudiob/force-master-keyYuji Yaginuma2018-02-122-1/+7
|\ \ \ | | | | | | | | Respect --force option for config/master.key
| * | | Respect --force option for config/master.keyclaudiob2018-02-112-1/+7
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is similar to #30700 which ensures the `--quiet` option of `rails new` is respected by the `MasterKeyGenerator` (missing from #30067). Before this commit, running `rails new app --force` would still prompt the user what to do with the conflict in `config/master.key`: ``` … identical config/locales/en.yml conflict config/master.key Overwrite /Users/claudiob/Desktop/pizza/config/master.key? (enter "h" for help) [Ynaqdh] ``` After this commit, `config/master.key` is overwritten: ``` … identical config/locales/en.yml force config/master.key append .gitignore ``` The newly added test generates an app and then generates it again with `--force`. Without this commit, the test would just wait forever for user input.
* | | Merge pull request #31133 from ↵Matthew Draper2018-02-112-0/+16
|\ \ \ | | | | | | | | | | | | | | | | mohsen-alizadeh/sanitize_empty_and_nil_parameters_passed_to_select sanitize empty and nil parameters to select #31059
| * | | add test case to relation selectMohsen Alizadeh2017-12-031-0/+15
| | | |
| * | | sanitize empty and nil parameters to selectMohsen Alizadeh2017-11-121-0/+1
| | | |
* | | | Unused core_extAkira Matsuda2018-02-111-1/+0
| |/ / |/| |
* | | Merge pull request #31949 from rails/remove-moveClaudio B2018-02-091-2/+0
|\ \ \ | | | | | | | | Remove warning from 4 years ago [ci skip]
| * | | Remove warning from 4 years ago [ci skip]claudiob2018-02-091-2/+0
| | | | | | | | | | | | | | | | | | | | `config/initializers/assets.rb` has been a part of Rails apps since Rails 4.2 (30b56084). This comment is probably unnecessary by now.
* | | | Fix formatting of `pick` [ci skip]yuuji.yaginuma2018-02-101-1/+1
| | | |
* | | | Make sure assert_recognizes can still find routes mounted after enginesRafael Mendonça França2018-02-092-4/+12
| | | | | | | | | | | | | | | | | | | | Before, if the application defined after an engine this method would not recognize the route since it was not defined insdie the engine.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 18:32:43 +0000