aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #36265 from vishaltelangre/patch-13Xavier Noria2019-05-131-1/+1
|\ | | | | [skip ci] Fix missing punctuation mark and formatting in CHANGELOG
| * [skip ci] Fix missing punctuation mark and formattingVishal Telangre2019-05-131-1/+1
|/
* adds a blank line [ci skip]Xavier Noria2019-05-131-0/+1
|
* warn about non-eager loaded dirs in zeitwerk:checkXavier Noria2019-05-131-19/+53
|
* Merge pull request #36255 from eugeneius/sqlite_savepoint_supportKasper Timm Hansen2019-05-124-7/+5
|\ | | | | Remove SQLite version support caveats [ci skip]
| * Remove SQLite version support caveats [ci skip]Eugene Kenny2019-05-124-7/+5
| | | | | | | | | | | | | | | | | | Since d1a74c1e012ed96f7179e53b9190b7da0a369e11, Active Record requires SQLite version 3.8.0 or greater, so savepoints and partial indexes are always available. That commit also added a runtime version check, so we can remove the minimum version requirement from the internal adapter documentation.
* | Merge pull request #36245 from vishaltelangre/patch-4Vipul A M2019-05-122-4/+5
|\ \ | | | | | | [ci skip] Clarity about embed metadata in signed and encrypted cookie
| * | [ci skip] Clarity about embed metadata in signed and encrypted cookieVishal Telangre2019-05-122-4/+5
| | |
* | | upgrading docs: one file => one constant [ci skip]Xavier Noria2019-05-121-0/+29
| | |
* | | NPM -> npm [ci skip]Xavier Noria2019-05-123-4/+4
| | | | | | | | | | | | According to https://www.npmjs.com/.
* | | Merge pull request #36073 from itsWill/document_update_counters_on_relationRyuta Kamizono2019-05-121-1/+13
|\ \ \ | | | | | | | | document update_counters on relation [ci skip]
| * | | document update_counters on relation [ci skip]Guilherme Mansur2019-05-111-1/+13
| | | |
* | | | Merge pull request #36257 from vipulnsward/sqlite-version-ymlRyuta Kamizono2019-05-122-2/+2
|\ \ \ \ | | | | | | | | | | Update the sqlite db yaml template to match other templates and mention proper supported version
| * | | | Update the sqlite db yaml template to match others and mention proper ↵Vipul A M2019-05-122-2/+2
| | | | | | | | | | | | | | | | | | | | supported version
* | | | | Update the 6.0 load_defaults list [ci skip] (#36258)Vipul A M2019-05-111-0/+2
|/ / / /
* | | / Update Webpacker in Action Text's test dummy appGeorge Claghorn2019-05-1113-564/+443
| |_|/ |/| |
* | | Merge pull request #36160 from sharang-d/update-getting-startedVipul A M2019-05-111-1/+1
|\ \ \ | | | | | | | | compilation -> compression [ci skip]
| * | | compilation -> compression [ci skip]Sharang Dashputre2019-05-021-1/+1
| | | |
* | | | Merge pull request #36251 from vishaltelangre/patch-10Xavier Noria2019-05-111-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] Clarify that the minimum version of a "gem" is bumped
| * | | | [ci skip] Clarify that the minimum version of a "gem" is bumpedVishal Telangre2019-05-121-1/+1
| | |_|/ | |/| | | | | | | | | | The previous sentence does not convey whether the minimum version of SQLite3 is bumped or the minimum version of `sqlite3` gem is bumped.
* | | | Merge pull request #36243 from vishaltelangre/patch-1Xavier Noria2019-05-111-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] Typo: Javascript -> JavaScript
| * | | | [ci skip] Typo: Javascript -> JavaScriptVishal Telangre2019-05-111-1/+1
| |/ / /
* | | | Merge pull request #36246 from vishaltelangre/patch-5Xavier Noria2019-05-111-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] Fix grammar
| * | | | [ci skip] Fix grammarVishal Telangre2019-05-111-1/+1
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ##### Singular `route exists` ##### Plural `routes exist`
* | | | Merge pull request #36252 from vishaltelangre/patch-11Xavier Noria2019-05-111-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] mysql -> MySQL
| * | | | [ci skip] mysql -> MySQLVishal Telangre2019-05-111-1/+1
| | | | |
* | | | | Merge pull request #36247 from vishaltelangre/patch-6Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] ActionView -> Action View
| * | | | | [ci skip] ActionView -> Action ViewVishal Telangre2019-05-111-1/+1
| | |/ / / | |/| | | | | | | | | | | | | | | | | | As per the documentation guides, we use 'Action View' instead of `ActionView` in the general language. Reference: https://github.com/rails/rails/commit/27138386ad8dbda2eb44e622515626f352fd3b22
* | | | | Merge pull request #36248 from vishaltelangre/patch-7Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Mime -> MIME
| * | | | | [ci skip] Mime -> MIMEVishal Telangre2019-05-111-1/+1
| |/ / / / | | | | | | | | | | | | | | | | | | | | The correct word is `MIME` which is an acronym which stands for `Multipurpose Internet Mail Extensions`. Reference: https://en.wikipedia.org/wiki/MIME
* | | | | Merge pull request #36249 from vishaltelangre/patch-8Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Expand JS to JavaScript for clarity
| * | | | | [ci skip] Expand JS to JavaScript for clarityVishal Telangre2019-05-111-1/+1
| |/ / / /
* | | | | Merge pull request #36250 from vishaltelangre/patch-9Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ | |_|/ / / |/| | | | [skip ci] arel -> Arel
| * | | | [skip ci] arel -> ArelVishal Telangre2019-05-111-1/+1
| |/ / / | | | | | | | | As per the documentation guides, we write `Arel` instead of `arel`.
* | | | Merge pull request #36244 from vishaltelangre/patch-3Ryuta Kamizono2019-05-121-3/+3
|\ \ \ \ | |/ / / |/| | | [ci skip] Typo: ActiveSuppport -> ActiveSupport
| * | | [ci skip] Typo: ActiveSuppport -> ActiveSupportVishal Telangre2019-05-111-3/+3
|/ / /
* | | Merge pull request #36241 from ↵Xavier Noria2019-05-111-1/+1
|\ \ \ | | | | | | | | | | | | | | | | vishaltelangre/fix-confusing-sentence-in-upgrade-guide [ci skip] Fix confusing sentence in upgrade guide
| * | | [ci skip] Fix confusing sentence in upgrade guideVishal Telangre2019-05-111-1/+1
| | | |
* | | | Merge pull request #36242 from shekhar-patil/masterVipul A M2019-05-111-1/+1
|\ \ \ \ | |/ / / |/| | | [ci skip] Corrected the sentence in upgrade guide
| * | | Corrected the sentence in upgrade guideshekhar-patil2019-05-111-1/+1
|/ / /
* | | Merge branch 'migration-timestamp-fix'Gannon McGibbon2019-05-104-0/+20
|\ \ \ | | | | | | | | | | | | Closes #28707.
| * | | Add class option timestamps to migration generatorMichael Duchemin2019-02-094-0/+22
| | | | | | | | | | | | | | | | Fixes GH#28706. Now rails g migration create_users and rails g model User have the same behavior for timestamps since they implement the same migration template. The expected behavior is that this create table migration will create the table with timestamps unless you pass --no-timestamps or --skip-timestamps to the generator. The expected migration should match what you get when you use the model generator. Using the migration generator, which doesn't have a class_option for timestamps would cause them to not be added to the migration file. Now the migration behavior of the migration generator, create_table only, is aligned with the migration behavior of the model generator. Also modified relevant example of ActiveRecord Migrations Guide.
* | | | Merge pull request #36184 from vishaltelangre/as-monotonic-timed-subscriberEileen M. Uchitelle2019-05-104-9/+131
|\ \ \ \ | | | | | | | | | | Introduce ActiveSupport::Notifications.monotonic_subscribe
| * | | | Introduce ↵Vishal Telangre2019-05-104-9/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'ActiveSupport::Notifications::Fanout::Subscribers::MonotonicTimed' and 'ActiveSupport::Notifications::monotonic_subscribe' Also, change the signature of ‘ActiveSupport::Notifications::Fanout#subscribe’ to accept optional ‘monotonic’ boolean argument. Then initialize either a ‘Timed’ or ‘MonotonicTimed’ subscriber based on the value of ‘monotonic’ parameter. Introduce ‘ActiveSupport::Notifications::monotonic_subscribe’ method Also, provision ‘ActiveSupport::Notifications::subscribed’ to optionally accept ‘monotonic’ boolean argument. Update documentation for ActiveSupport::Notifications Add tests Update guides documentation under the 'Active Support Instrumentation' chapter Incorporate feedback: use optional keyword argument to specify optional 'monotonic' option to 'subscribed' method Fix a typo
* | | | | Merge pull request #36181 from jamesdabbs/jcd/action-mailbox-forGeorge Claghorn2019-05-095-5/+30
|\ \ \ \ \ | | | | | | | | | | | | Expose `mailbox_for` method
| * | | | | Add CHANGELOG entryJames Dabbs2019-05-091-0/+2
| | | | | |
| * | | | | Delegate to the correct method in `ActionMailbox.mailbox_for`James Dabbs2019-05-051-1/+1
| | | | | |
| * | | | | Rename variable to represent typeJames Dabbs2019-05-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | per comments from CR
| * | | | | Expose `mailbox_for` methodJames Dabbs2019-05-044-5/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the only exposed entry point into the ApplicationMailbox's configured routing system is to call `route`, which performs a lot of work to fully `process` inbound email. It'd be nice to have a way (e.g. in test) of checking which mailbox an email would route to without necessarily processing it yet.
* | | | | | fixes configuration examples [ci skip]Xavier Noria2019-05-091-3/+3
| |/ / / / |/| | | |