Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make filter_binds filter out symbols that are equal to strings | Nat Budin | 2014-05-14 | 5 | -1/+32 |
| | | | | | | | | | | | | | ActiveRecord::Relation::Merger's filter_binds method does not filter out bind variables when one of the attribute nodes has a string name, but the other has a symbol name, even when those names are actually equal. This can result in there being more bind variables than placeholders in the generated SQL. This is particularly an issue for PostgreSQL, where this is treated as an error. This patch changes the filter_binds method to make it convert both attribute names to strings before comparing. | ||||
* | Hash#except is expensive and this is a hotspot, so use a dup + delete | Aaron Patterson | 2014-05-12 | 1 | -1/+2 |
| | |||||
* | test, use `columns_hash[]` in place of `columns.find {}`. | Yves Senn | 2014-05-12 | 8 | -12/+12 |
| | |||||
* | pg, `change_column_default` accepts `[]`. Closes #11586. | Yves Senn | 2014-05-12 | 4 | -3/+18 |
| | |||||
* | pg, map `char` and `name` types as string. [dark-panda & Yves Senn] | Yves Senn | 2014-05-12 | 3 | -0/+33 |
| | | | | Closes #10802. | ||||
* | Merge pull request #13334 from gregolsen/postgresql_infinity | Yves Senn | 2014-05-12 | 3 | -3/+30 |
|\ | | | | | | | | | | | | | | | | | | | pg, fix Infinity and NaN values conversion. Closes #13334. * rebased * removed guard * inlined guard into case statement | ||||
| * | pg, fix Infinity and NaN values conversion. | Innokenty Mihailov | 2014-05-12 | 3 | -3/+30 |
|/ | | | | Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`. | ||||
* | Merge pull request #10505 from patricksrobertson/bigserial_id_not_identifying_pk | Yves Senn | 2014-05-12 | 3 | -1/+33 |
|\ | | | | | | | | | | | | | | | | | Handle other pk types in PostgreSQL gracefully. Closes #10505. - rebased - test slightly modified | ||||
| * | Handle other pk types in PostgreSQL gracefully. | Patrick Robertson | 2014-05-12 | 3 | -1/+33 |
|/ | | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb. | ||||
* | Merge pull request #14999 from yahonda/modify_bind_variable_name | Yves Senn | 2014-05-12 | 1 | -2/+3 |
|\ | | | | | | | | | | | | | Modify assert conditions not to be affected by each database bind variable naming conventions Closes #14999. | ||||
| * | Modify assert conditions not to be affected | Yasuo Honda | 2014-05-12 | 1 | -2/+3 |
| | | | | | | | | by each database bind variable naming conventions | ||||
* | | Merge pull request #15060 from tgxworld/remove_unnecessary_tests_method | Rafael Mendonça França | 2014-05-12 | 1 | -2/+0 |
|\ \ | | | | | | | Remove redundant tests method. | ||||
| * | | Remove redundant tests method. | Guo Xiang Tan | 2014-05-11 | 1 | -2/+0 |
| | | | |||||
* | | | Update attribute_methods.rb | Guillermo Iguaran | 2014-05-11 | 1 | -1/+1 |
| | | | | | | | | | Improve documentation | ||||
* | | | Merge pull request #15063 from cbeer/correct-attribute_present-docs | Guillermo Iguaran | 2014-05-11 | 1 | -7/+7 |
|\ \ \ | |/ / |/| | | correcting method documentation [ci skip] | ||||
| * | | correcting method documentation [ci skip] | Chris Beer | 2014-05-11 | 1 | -7/+7 |
| | | | |||||
* | | | Merge pull request #10662 from ↵ | Carlos Antonio da Silva | 2014-05-11 | 1 | -9/+9 |
|\ \ \ | | | | | | | | | | | | | | | | | take/change-test-name-for-ActiveRecord--Validations#valid- Refactor AR's validations_test.rb | ||||
| * | | | Refactor AR's validations_test.rb | Takehiro Adachi | 2013-12-03 | 1 | -9/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `:context` switch feature is implemented in ActiveRecord::Validations#valid? method, so we should rename the test names, and execute `valid?` in the test. Change test name in AR's validations_test.rb This test is testing save method's code | ||||
* | | | | Merge pull request #15059 from marcioj/patch-1 | Robin Dupret | 2014-05-11 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | Replace :base with :in [ci skip] | ||||
| * | | | | Replace :base with :in [ci skip] | Marcio Junior | 2014-05-11 | 1 | -2/+2 |
|/ / / / | |||||
* | | | | Tidy up implementation of #15010 | Andrew White | 2014-05-11 | 2 | -11/+7 |
| | | | | |||||
* | | | | Make TimeZone#parse behave more like Time#parse. | Ulysse Carion | 2014-05-11 | 3 | -1/+25 |
| | | | | | | | | | | | | | | | | | | | | Namely, if the mday is omitted but any other upper components are, then instead of supplying the mday from the current time, it defaults to 1. | ||||
* | | | | docs, make `ActionNotFound` public API. [ci skip] | Yves Senn | 2014-05-11 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to #15058. This exception is regularly raised during development. This means it will enter the user realm. We should provide an API page to show that this exception is public API. /cc @schneems | ||||
* | | | | Merge pull request #15058 from Gaurav2728/gaurav-doc_message | Richard Schneeman | 2014-05-11 | 1 | -3/+4 |
|\ \ \ \ | | | | | | | | | | | adding complete message in documentation [ci skip] | ||||
| * | | | | adding complete message in documentation [ci skip] | Gaurav Sharma | 2014-05-11 | 1 | -3/+4 |
|/ / / / | |||||
* | | | | Merge branch 'master' of github.com:rails/rails | Andrew White | 2014-05-11 | 1 | -0/+59 |
|\ \ \ \ | |||||
| * | | | | pg guide, PostgreSQL legacy table view example. [ci skip] | Yves Senn | 2014-05-11 | 1 | -0/+59 |
| | | | | | |||||
* | | | | | Always use the provided port for protocol relative urls | Andrew White | 2014-05-11 | 3 | -0/+20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided. | ||||
* | | | | | ActionDispatch::Http::URL.normalize_port should not strip port for protocol ↵ | Guilherme Cavalcanti | 2014-05-11 | 2 | -2/+12 |
|/ / / / | | | | | | | | | | | | | relative URL. | ||||
* | | | | docs, fix typo in docs added by ed56e596a04673. [ci skip] | Yves Senn | 2014-05-10 | 1 | -2/+2 |
| | | | | |||||
* | | | | Merge pull request #15056 from josemarluedke/single-quotes-on-plugin-gemfile | Rafael Mendonça França | 2014-05-10 | 2 | -7/+7 |
|\ \ \ \ | | | | | | | | | | | Change Gemfile’s double quotation marks in plugin generator | ||||
| * | | | | Change Gemfile’s double quotes in plugin generator | Josemar Luedke | 2014-05-10 | 2 | -7/+7 |
|/ / / / | | | | | | | | | | | | | | | | | Since the generated application’s Gemfile is using single quotation marks, it seems fair to use it on plugin’s Gemfile as well. | ||||
* | | | | Merge pull request #15054 from mechanicles/documentation-consistency | Rafael Mendonça França | 2014-05-10 | 1 | -3/+3 |
|\ \ \ \ | | | | | | | | | | | Keep method's description/documentation consistent [ci skip] | ||||
| * | | | | Keep method's description/documentation consistent [ci skip] | Santosh Wadghule | 2014-05-11 | 1 | -3/+3 |
|/ / / / | |||||
* | | | | feature detect for FNM_EXTGLOB for older Ruby. Fixes #15053 | Aaron Patterson | 2014-05-10 | 1 | -5/+21 |
| | | | | |||||
* | | | | minor change in AR readme [ci skip] | Vijay Dev | 2014-05-10 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2014-05-10 | 6 | -11/+49 |
|\ \ \ \ | |||||
| * | | | | copy edits [ci skip] | Vijay Dev | 2014-05-10 | 2 | -14/+13 |
| | | | | | |||||
| * | | | | [ci skip] add example to AR#assign_attributes | schneems | 2014-05-09 | 1 | -0/+10 |
| | | | | | |||||
| * | | | | [ci skip] doc ActiveSupport::TimeWithZone#to_s | schneems | 2014-05-09 | 1 | -2/+5 |
| | | | | | | | | | | | | | | | Current docs are wrong. Does not accept strftime inputs. | ||||
| * | | | | [ci skip] doc Http::Headers methods | schneems | 2014-05-09 | 1 | -1/+17 |
| | | | | | |||||
| * | | | | fix formatting errors [ci skip] | Vijay Dev | 2014-05-09 | 1 | -6/+6 |
| | | | | | |||||
| * | | | | copy edits [ci skip] | Vijay Dev | 2014-05-08 | 2 | -3/+2 |
| | | | | | |||||
| * | | | | [ci skip] document ActionDispatch::HTTP::Headers | schneems | 2014-05-07 | 1 | -0/+6 |
| | | | | | |||||
| * | | | | [ci skip] document type_cast_for_write | schneems | 2014-05-07 | 2 | -0/+5 |
| | | | | | |||||
| * | | | | Fix Formatting in AR Readme | Gaurish Sharma | 2014-05-04 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | Don't make free form text appear in code blocks [ci skip] | ||||
* | | | | | deprecate, join, preload, eager load of instance dependent associations. | Yves Senn | 2014-05-10 | 6 | -4/+56 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior. | ||||
* | | | | | Merge pull request #15049 from arthurnn/fix_ci | Rafael Mendonça França | 2014-05-09 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | Fix broken proc syntax for 1.9.3 | ||||
| * | | | | | Fix broken proc syntax for 1.9.3 | Arthur Neves | 2014-05-09 | 1 | -1/+1 |
|/ / / / / | |||||
* | | | | | skip dealing with params if none are provided | Aaron Patterson | 2014-05-09 | 1 | -4/+11 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets us avoid 1. A slow call to Hash#slice 2. An is_a? test 3. Extra hash allocations (from slice) 4. String allocations etc. |