| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Eventually we don't want to expose the "options" hash from scope, only
read values from it. Lets start by adding a reader method.
|
|
|
|
|
| |
now we don't need to construct a Mapping object just to get an
ArgumentError if there is no `via` parameter provided.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
We're going to try pulling this up further, and check `via` validity
sooner. This way we don't have to do a bunch of processing on `options`
hashes only to find out that the route is incorrect
|
|
|
|
|
| |
If we do the Regexp verification in a second method, then the
`split_constraints` method gets much easier.
|
| |
|
| |
|
|
|
|
|
|
| |
I don't want `split_constraints` to mutate any instance variables. That
way it's easier to move the method around and understand what it does
(it has no side effects)
|
|
|
|
|
| |
I don't want to rely on mutating ivars. This gives me more freedom when
refactoring
|
|\
| |
| | |
[ci skip] Removed link to reSRC.io - site closed
|
| | |
|
|\ \
| | |
| | | |
[ci skip] Fix rdoc markup
|
| | | |
|
|/ /
| |
| |
| | |
`+` doesn't work around content with spaces fallback `<tt>`.
|
|\ \
| | |
| | | |
[ci skip] Fix the indentation
|
| | | |
|
|\ \ \
| | | |
| | | | |
[ci skip] Swap ruby -v and the installation tip
|
| | |/
| |/| |
|
| | | |
|
| | |
| | |
| | |
| | | |
we don't need to do it so many times.
|
| | | |
|
| | |
| | |
| | |
| | | |
Now we only need to call `split_constraints` possibly twice!
|
| | |
| | |
| | |
| | |
| | | |
apparently `format` can also come from the scope options, so we need to
extract it there too.
|
|\ \ \
| | | |
| | | | |
Authorization scheme should be case insensitive. Fixes #21199
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
this way we don't have to insert / delete it from the options hash so
many times.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
eventually we'll remove the need to access `scope` inside the Mapping
object.
|
|\ \ \ \
| | | | |
| | | | | |
Rename match_attribute_method? to matched_attribute_method
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
`match_attribute_method?` is a bit confusing because it suggest
that a return value is a boolean which is not true.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`using_match_shorthand?` doesn't need to know that an options hash
exists. Also use this opportunity to make the boolean logic a little
more sane
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
this simplifies the "downstream" logic since we know we'll only be
dealing with one particular type
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
I think we can find the original place where `action` is added to the
options hash now.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
we want to try to pull this logic up to where the user actually passed
in "controller" so that it's close to the related call. That way when
we're down the stack, we don't need to wonder "why are we doing this?"
|
|\ \ \ \
| | | | |
| | | | | |
Parametrize break sequence for word_wrap on ActionView Text Helpers
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
today the only option we have is "\n" and is hardcoded.
With this change you will be able to specify any break sequence ("\r\n" for example) as an option.
adding proper documentation for break_sequence in ActionView::Helpers::TextHelper.word_wrap
adding some more documentation for word_wrap custom break sequence and making sure we use new hash syntax
|
|\ \ \ \
| | | | |
| | | | | |
fix comment about which mail headers are excluded
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
[ci skip] Fix broken link markup
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Dont try to call method missing in routes if thats not what we want
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If, doing a test like this:
```
class BugTest < ActionView::TestCase
def test_foo
omg
end
```
Will raise with:
```
RuntimeError: In order to use #url_for, you must include routing helpers
explicitly. For instance, `include
Rails.application.routes.url_helpers`.
```
Thats a bit confusing, as we are not calling url_for at all.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add method to run command-line db apps
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Added run_cmd() class method to dry up Kernel.system() messages within
this namespace and avoid shell expansion by passing a list of
arguments instead of a string
- Update structure_dump, structure_load, and related tests units to
pass a list of params instead of using a string to
avoid shell expansion
|
| | | | | |
|