| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Sufficiently large integers cause `find` and `find_by` to raise
`StatementInvalid` instead of `RecordNotFound` or just returning `nil`.
Given that we can't cast to `nil` for `Integer` like we would with junk
data for other types, we raise a `RangeError` instead, and rescue in
places where it would be highly unexpected to get an exception from
casting.
Fixes #17380
|
|\ \ \ \
| |/ / /
|/| | | |
Masked authenticity token section, finder options details, misc typos [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | | |
It is internal use only. This is to avoid conflicting with users' method
names. Fixes #17458
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Arel has changed so that `.sum` no longer aliases `SUM(the_column)` to
`sum_id`. This means the type returned by the adapter will be at the key
`"SUM(the_column)"`. Longer term, we should eventually be able to retain
type information from the AR::Base subclasses used in joined queries
|
| | | |
| | | |
| | | |
| | | | |
Fixes #17455
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] fix incorrect key in Active Support Instrumentation guide
|
|/ / / / |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove redundant `to_s` in interpolation
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* master-sec:
FileHandler should not be called for files outside the root
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
FileHandler#matches? should return false for files that are outside the
"root" path.
|
| | | | | | |
|
|\ \ \ \ \ \ |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
It was missing from table, but is present in sample hash below
|
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Passing ranges to `#in` has been deprecated in Arel.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove redundant `to_s` in interpolation
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Faster to call `gsub` with a regexp literal than a string literal
|
| | | | | | | |
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Fix typo [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
correct GlobalID mixin name in the guides
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Update 2.7 & 2.8 of upgrading_ruby_on_rails.md [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
section 2.8 "Rails DOM Testing"
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
The email preview iframe height is fixed and does not scale to the browser size
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
800 pixels, and the full available screen size is not being used.
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
mcfiredrill/doc-change-column-default-abstract-mysql-adapter
document change_column and change_column_default for abstract_mysql_adapter [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
better example for tokenizer lambda [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Splitting on whitespace makes more sense in the context of counting words in an
essay.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Added 'tzinfo-data' if we are using jruby
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The MySQLAdapter type map used the lowest priority for enum types.
This was the result of a recent refactoring and lead to some broken lookups
for enums with values that match other types. Like `8bit`.
This patch restores the priority to what we had before the refactoring.
/cc @sgrif
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This patch uniformizes warning messages. I used the most common style
already present in the code base:
* Capitalize the first word.
* End the message with a full stop.
* "Rails 5" instead of "Rails 5.0".
* Backticks for method names and inline code.
Also, converted a few long strings into the new heredoc convention.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
let warn with heredocs
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The current style for warning messages without newlines uses
concatenation of string literals with manual trailing spaces
where needed.
Heredocs have better readability, and with `squish` we can still
produce a single line.
This is a similar use case to the one that motivated defining
`strip_heredoc`, heredocs are super clean.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We were relying on hash inequality in tests
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The query cache uses bind values as hash keys. The current
implementation relies on reference equality for hash equality. This is
brittle, and can easily break in the future.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We shouldn't rely on reference equality of these objects in tests
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The value methods will default to an empty array for us automatically
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The change to accessing keys directly was originally added to allow
`merge` to take a hash. The implementation of `HashMerger` no longer
requires us to be doing so. Accessing the values directly makes it
impossible to change internal storage details, even if shim methods are
added temporarily
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Added ability to configure the queue_name_prefix delimiter to ActiveJob::QueueName.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Added ActiveJob::Base#queue_name_delimiter to allow for
developers using ActiveJob to change the delimiter from the default
('_') to whatever else they may be using (e.g., '.', '-', ...).
- Updated source guide to include a blurb about the delimiter.
|