| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
This also marks Action Cable routes as internal to Rails.
|
|\
| |
| |
| |
| | |
akshaymohite/api-app-debug-exception-response-format-in-doc
[ci skip] Need to mention debug_exception_response_format in the api_app documentation.
|
|/
|
|
|
|
|
|
|
| |
documentation.
- #23771 removed the reference to debug_exception_response_format from the api_app documentation.
- We need to let users know, they have ability to configure debug_exception_response_format in their development environment.
- Added documentation for the same in api_app.md file
- Grammar corrections
|
|\
| |
| | |
[ci skip] Replace usage of rake routes with rails routes
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I ran into an issue where validations on a suppressed record were
causing validation errors to be thrown on a record that was never going
to be saved.
There isn't a reason to run the validations on a record that doesn't
matter.
This change moves the suppressor up the chain to be run on the `save` or
`save!` in the validations rather than in persistence. The issue with
running it when we hit persistence is that the validations are run
first, then we hit persistance, and then we hit the suppressor. The
suppressor comes first.
The change to the test was required since I added the
`validates_presence_of` validations. Adding this alone was enough to
demonstrate the issue. I added a new test to demonstrate the new
behavior is explict.
|
|\|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* master: (113 commits)
remove useless method
Updated file documentation [ci skip]
changes caching guide to add note on weak etags
Don't put config.action_mailer.perform_caching entry twice in development.rb
Fix wording and wrong reference
Add Ruby formatting to CHANGELOG entry
Fix ActionView's cache section reference
Do not define methods in the included block
Add caching guide in ActionMailer basics
Add ActionMailer configuration options
Preparing for 5.0.0.beta3 release
Update 5.0 release notes
Enable tmp_restart plugin for puma
Prep release for Rails 5 beta3
[ci skip] Move collection caching changelog entry.
Ensure `drop_table` even if tests failure or interrupted
:bomb: run the test @rafaelfranca :angry:
Remove changelog entry for reverted commit
Add CHANGELOG for https://github.com/rails/rails/pull/23734 [ci skip]
No need CHANGELOG entry for #23849.
...
|
| | |
|
| |\
| | |
| | | |
Updated file documentation [ci skip]
|
| |/ |
|
| |\
| | |
| | | |
Changes caching guide to add note on weak etags
|
| | | |
|
| |\ \
| | | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/dont-put-perform-caching-config-twice
Don't put config.action_mailer.perform_caching entry twice in development.rb
|
| | | | |
|
| |\ \ \
| | |/ /
| |/| | |
[ci skip] Update guide sources for mailer view caching feature
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
Add Ruby formatting to CHANGELOG entry
|
| |/ / /
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
Instance methods can be defined in the module itself
|
| | | |
| | | |
| | | |
| | | | |
Adds changelog headers for beta3 release
|
| | | |
| | | |
| | | |
| | | | |
Fixes #23855
|
| |/ / |
|
| | |
| | |
| | |
| | |
| | | |
We changed this in beta2, and only editing the original entry means
people can't see that it was significantly changed.
|
| |\ \
| | | |
| | | | |
Ensure `drop_table` even if tests failure or interrupted
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I was encountered remaining `:binary_testings` table by tests failure.
When remaining `:binary_testings` table, never reach `drop_table` due to
`create_table` in the test always fails.
|
| |/ / |
|
| | |
| | |
| | |
| | |
| | | |
I had to revert changes made for this CHANGELOG entry so this is no
longer valid. The change for this entry was removed in 2c02bc0.
|
| |\ \
| | | |
| | | | |
Add CHANGELOG for https://github.com/rails/rails/pull/23734 [ci skip]
|
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It is not a released feature so we don't need to add changelogs to
changes on it.
[ci skip]
|
| | |
| | |
| | |
| | | |
Also use the new hash syntax.
|
| |\ \
| | | |
| | | |
| | | | |
Fix logger silencing for broadcasted loggers
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix #23609
Commit 629efb6 introduced thread safety to logger silencing but it
didn't take into account the fact that the logger can be extended with
broadcasting to other logger.
This commit introduces local_level to broadcasting Module which enables
broadcasted loggers to be properly silenced.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
coffee-rails is stable now so we don't need to point to the master
branch.
|
| |\ \ \
| | | | |
| | | | | |
Show permitted flag in the output of AC::Parameters#inspect
|
| | | | |
| | | | |
| | | | |
| | | | | |
- Fixes #23822.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #22982.
|
| |\ \ \ \
| | |/ / /
| |/| | | |
AppGenerator: Replace 'rake' with 'rails_command'
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Follows the convention from Rails 5 of invoking tasks on the command-line
with `rails …` rather than `rake …`.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since Rails 5.0 is switching the Rails command line from 'rake …'
to 'rails …', it makes sense to also replace the `rake` method in
the Rails templates API.
Based on feedback from @matthewd and @kaspth, I chose to replace
`rake` with `rails_command`, which is less confusing than
the alternatives `rails` or `command` or `rails_run` and is not
Thor-reserved word like `task`.
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Give Sessions Indifferent Access
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This is a rebased version of #22825.
Closes #22825.
|