Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #18350 from brainopia/fix_build_from_bind_values | Sean Griffin | 2015-01-05 | 2 | -2/+12 |
|\ | | | | | Propagate bind_values from join in subquery | ||||
| * | Correctly fetch bind_values from join in subquery | brainopia | 2015-01-06 | 2 | -2/+12 |
| | | |||||
* | | Define attribute methods before attempting to populate records | Sean Griffin | 2015-01-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | `initialize_internals_callback` will attempt to assign attributes from the current scope, which will fail if something defined the method and calls super (meaning it won't hit `method_missing`). Fixes #18339 | ||||
* | | Whitespace fixes from #18349 | Sean Griffin | 2015-01-05 | 1 | -2/+1 |
| | | |||||
* | | Merge pull request #18349 from jdelStrother/primarykeyless | Sean Griffin | 2015-01-05 | 2 | -1/+23 |
|\ \ | |/ |/| | Fix rollback of primarykey-less tables | ||||
| * | Fix rollback of primarykey-less tables | Jonathan del Strother | 2015-01-05 | 2 | -1/+23 |
| | | | | | | If you have a table without a primary key, and an `after_commit` callback on that table (ie `has_transactional_callbacks?` returns true), then trying to rollback a transaction involving that record would result in “ActiveModel::MissingAttributeError: can't write unknown attribute ``” | ||||
* | | Avoid changing the global state on the tests | Rafael Mendonça França | 2015-01-05 | 1 | -1/+6 |
| | | |||||
* | | Merge pull request #17676 from ↵ | Rafael Mendonça França | 2015-01-05 | 2 | -6/+27 |
|\ \ | | | | | | | | | | | | | | | | tigrish/fix_custom_i18n_exception_handler_regression Fix I18n regression introduced by #13832 | ||||
| * | | Fix I18n regression introduced by #13832 | Christopher Dell | 2014-11-19 | 2 | -6/+27 |
| | | | | | | | | | | | | Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used. | ||||
* | | | Merge pull request #17720 from rzane/firebird-test-support | Rafael Mendonça França | 2015-01-05 | 5 | -21/+28 |
|\ \ \ | | | | | | | | | | | | | Add Firebird support to test suite | ||||
| * | | | Add firebird support to test suite | Ray Zane | 2015-01-05 | 5 | -21/+28 |
|/ / / | |||||
* | | | Merge pull request #18344 from jonatack/patch-1 | Rafael Mendonça França | 2015-01-05 | 1 | -5/+5 |
|\ \ \ | | | | | | | | | Clean up secure_token_test | ||||
| * | | | Clean up secure_token_test | Jon Atack | 2015-01-05 | 1 | -5/+5 |
| | | | | |||||
* | | | | Merge pull request #18345 from mtthgn/patch-1 | Rafael Mendonça França | 2015-01-05 | 1 | -1/+1 |
|\ \ \ \ | |/ / / |/| | | | Fix TypeError in Fixture creation | ||||
| * | | | Fix TypeError in Fixture creation | Matt Hogan | 2015-01-05 | 1 | -1/+1 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby 4.2 started doing `value.gsub('$LABEL', label)` for fixture label interpolation, but you can have have valid YAML where `label` isn't a String. For example: ```YAML 0: name: John email: johndoe@gmail.com 1: name: Jane email: janedoe@gmail.com ``` This YAML will create a label that is a Fixnum, causing `TypeError: no implicit conversion of Fixnum into String.` | ||||
* | | | reflects changes in 34cd7e2 in the index [ci skip] | Xavier Noria | 2015-01-05 | 1 | -3/+3 |
| | | | |||||
* | | | Merge pull request #18341 from aditya-kapoor/remove-unneeded-checks | Rafael Mendonça França | 2015-01-05 | 1 | -2/+1 |
|\ \ \ | | | | | | | | | remove unneeded check since /_one_time_conditions/ is not present anymore. | ||||
| * | | | remove unneeded check since /_one_time_conditions/ is removed | Aditya Kapoor | 2015-01-05 | 1 | -2/+1 |
| | | | | |||||
* | | | | Merge pull request #18342 from ↵ | Rafael Mendonça França | 2015-01-05 | 1 | -2/+4 |
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | brainopia/reset_template_assertion_without_warnings Reset template assertions without warnings | ||||
| * | | | Reset template assertions without warnings | brainopia | 2015-01-05 | 1 | -2/+4 |
|/ / / | |||||
* | | | Fix typo in changelog [ci skip] | Carlos Antonio da Silva | 2015-01-05 | 1 | -1/+1 |
| | | | |||||
* | | | remove deprecated support to preload instance-dependent associaitons. | Yves Senn | 2015-01-05 | 4 | -32/+16 |
| | | | | | | | | | | | | Addresses https://github.com/rails/rails/commit/ed56e596a0467390011bc9d56d462539776adac1#commitcomment-9145960 | ||||
* | | | remove deprecated support for PG ranges with exclusive lower bounds. | Yves Senn | 2015-01-05 | 3 | -37/+10 |
| | | | | | | | | | | | | addresses https://github.com/rails/rails/commit/91949e48cf41af9f3e4ffba3e5eecf9b0a08bfc3#commitcomment-9144563 | ||||
* | | | can't kill thread with in-memory db. fixes `rake test:sqlite3_mem`. | Yves Senn | 2015-01-05 | 1 | -0/+2 |
| | | | |||||
* | | | remove deprecation warning when modifying a Relation with cached arel. | Yves Senn | 2015-01-05 | 3 | -21/+27 |
| | | | | | | | | | | | | This adresses https://github.com/rails/rails/commit/1b7aa62b184c4410c99208f71b59bbac5c5f03be#commitcomment-9147803 | ||||
* | | | add punctuation. [ci skip] | Yves Senn | 2015-01-05 | 1 | -2/+2 |
| | | | |||||
* | | | Merge pull request #18332 from gchan/update-adequate-record-notes | Rafael Mendonça França | 2015-01-04 | 1 | -0/+3 |
|\ \ \ | | | | | | | | | Include newer `find_by` syntax example in 4.2 release notes for Adequate Record | ||||
| * | | | [guides] Added newer find_by syntax example in 4.2 release notes for ↵ | Gordon Chan | 2015-01-05 | 1 | -0/+3 |
| | | | | | | | | | | | | | | | | Adequate Record [skip ci] | ||||
* | | | | Merge pull request #18331 from simi/document-protect-from-forgery-options | David Heinemeier Hansson | 2015-01-04 | 1 | -8/+2 |
|\ \ \ \ | |/ / / |/| | | | Document all options for protect_from_forgery. | ||||
| * | | | Document all options for protect_from_forgery. | Josef Šimánek | 2015-01-04 | 1 | -8/+2 |
|/ / / | | | | | | | | | | [ci skip] | ||||
* | | | Merge pull request #18090 from egilburg/patch-3 | Rafael Mendonça França | 2015-01-04 | 1 | -9/+1 |
|\ \ \ | | | | | | | | | | | | | simplify ActiveSupport.test_order definition | ||||
| * | | | simplify ActiveSupport.test_order definition | Eugene Gilburg | 2014-12-18 | 1 | -9/+2 |
| | | | | |||||
* | | | | Do not include Active Support on tests | Rafael Mendonça França | 2015-01-04 | 3 | -30/+24 |
| | | | | | | | | | | | | | | | | It was not done to be included | ||||
* | | | | Merge pull request #18328 from brainopia/remove_tz_proxy | Rafael Mendonça França | 2015-01-04 | 3 | -12/+7 |
|\ \ \ \ | | | | | | | | | | | Use directly TZInfo::Timezone without proxy | ||||
| * | | | | Use directly TZInfo::Timezone without proxy | brainopia | 2015-01-04 | 3 | -12/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | Since real timezone is loaded anyway in `#utc_offset` which is called during `#create` | ||||
* | | | | | Remove unused require | Carlos Antonio da Silva | 2015-01-04 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | This was used by the respond_to/respond_with implementation on this file, which is now extracted to the responders gem. | ||||
* | | | | | Remove respond_to/respond_with placeholder methods | Carlos Antonio da Silva | 2015-01-04 | 3 | -52/+5 |
| | | | | | | | | | | | | | | | | | | | | This functionality has been extracted to the responders gem. | ||||
* | | | | | Remove extra class_eval for Ruby 1.9 | Carlos Antonio da Silva | 2015-01-04 | 1 | -5/+2 |
| | | | | | |||||
* | | | | | Remove workaround to a Ruby 2.0.0 bug | Rafael Mendonça França | 2015-01-04 | 1 | -7/+0 |
| | | | | | |||||
* | | | | | Remove Struct#to_h backport | Rafael Mendonça França | 2015-01-04 | 4 | -18/+5 |
| | | | | | |||||
* | | | | | String already respond_to scrub at Ruby 2.2 | Rafael Mendonça França | 2015-01-04 | 1 | -2/+1 |
| | | | | | |||||
* | | | | | singleton_class? is already pressent at Ruby 2.2 | Rafael Mendonça França | 2015-01-04 | 1 | -8/+0 |
| | | | | | |||||
* | | | | | Remove unneeded Time patch to support Ruby 1.9 | Rafael Mendonça França | 2015-01-04 | 2 | -30/+2 |
| | | | | | |||||
* | | | | | Remove some comments about Ruby 1.9 behaviors | Rafael Mendonça França | 2015-01-04 | 6 | -9/+9 |
| | | | | | |||||
* | | | | | Remove wrong TODO comment | Rafael Mendonça França | 2015-01-04 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | No need to disable sidikiq tests with 1.9.3 anymore | Rafael Mendonça França | 2015-01-04 | 1 | -11/+0 |
| | | | | | |||||
* | | | | | Remove debugger support | Rafael Mendonça França | 2015-01-04 | 14 | -138/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | bebugger doesn't work with Ruby 2.2 so we don't need to support it anymore | ||||
* | | | | | Remove version conditional for calling GC.disable | Rafael Mendonça França | 2015-01-04 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Remove version conditional for find_template_paths | Rafael Mendonça França | 2015-01-04 | 1 | -18/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | Now that we only support Ruby 2.2+ we don't need this conditional anymore | ||||
* | | | | | Remove LoadError#path hack for Ruby 1.9 | claudiob | 2015-01-04 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | Now that Rails requires Ruby >= 2.0 there is need to skip the `test_depend_on_path` test. |