| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
There were a few places where I missed a `create` vs `new`
before_type_cast check, and the semantics of `reload` became wrong.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can skip the allocation of a full `AttributeSet` by changing the
semantics of how we structure things. Instead of comparing two separate
`AttributeSet` objects, and `Attribute` is now a singly linked list of
every change that has happened to it. Since the attribute objects are
immutable, to apply the changes we simply need to copy the head of the
list.
It's worth noting that this causes one subtle change in the behavior of
AR. When a record is saved successfully, the `before_type_cast` version
of everything will be what was sent to the database. I honestly think
these semantics make more sense, as we could have just as easily had the
DB do `RETURNING *` and updated the record with those if we had things
like timestamps implemented at the DB layer.
This brings our performance closer to 4.2, but we're still not quite
there.
|
|\
| |
| | |
Response#add_header for adding to multi-valued headers like Vary
|
|/ |
|
|\
| |
| | |
Don't set a nil Set-Cookie header when there aren't any cookies
|
|/
|
|
| |
header.
|
|\
| |
| | |
adding test for content type with default charset
|
|/
|
|
|
| |
* first test is for `default_charset` i.e `ActionDispatch::Response.default_charset = “utf-8”`
* In below test we are passing `ActionDispatch::Response.default_charset = 'utf-16’` so name of the test is irrelevant — “read content type without charset”
|
|\
| |
| | |
Regex fix for mattr_accessor validation
|
|/
|
|
|
| |
Change ^ and $ operators to \A and \z to prevent
code injection after the line breaks
|
|\
| |
| | |
Refactor AS::Callbacks halt config and fix the documentation
|
|/
|
|
|
|
|
|
|
| |
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)
Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
|
|\
| |
| | |
Added test cases for checkbox_tag
|
|/ |
|
|
|
|
|
| |
this should fix the error where isolation tests raise an exception and
we just get a marshal error
|
|\
| |
| | |
Add test cases for text_field_tag
|
|/ |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Allow fixtures YAML files to set the model class in the file itself
Conflicts:
activerecord/CHANGELOG.md
|
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, `set_fixture_class` is only available using the
`TestFixtures` concern and it is ignored for `rake db:fixtures:load`.
Using the correct model class, it is possible for the fixture load
to also load the associations from the YAML files (e.g., `:belongs_to`
and `:has_many`).
|
|\ \
| | |
| | | |
Fixed concurrent-ruby warnings.
|
|/ /
| |
| |
| |
| | |
Bumped version of concurrent-ruby to 1.0.0.pre3, which fixes all
interpreter warnings.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
`default_middleware_stack` seems to kick off the `on_load` calls that
may mutate the middleware stack. We have to call that method before
merging middleware stacks, otherwise the middleware stacks get mutated
*after* the app middleware stack is built.
|
| |
| |
| |
| |
| | |
We shouldn't merge the app middleware in to the config middleware for
engines.
|
|\ \
| | |
| | |
| | |
| | | |
jeremy/sprockets/move-asset-manifest-from-toplevel-to-config-subdir
Eliminate overlapping `app/assets` load path
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Move `app/assets/manifest.js` to `app/assets/config/manifest.js`.
Avoid the suggestion that you can/should deep-link `stylesheets/foo`.
* Pull in all toplevel stylesheets and JavaScripts, not just
`application.js` and `.css`. Demonstrate how to use `link_directory`
with a specified `.js`/`.css` type.
* Fix RAILS_ENV handling in assets tests.
* Shush warnings spam from third-party libs that distract from tests.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Allocating a new middleware proxy in each application configuration and
then merging the app specific config with the global config when the app
is built.
|
|\ \ \
| | | |
| | | | |
Improve readability of docs by using code tag [ci skip]
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Fix documentation for has_many dependant options.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
* A `has_many` dependant association accepts `[:destroy, :delete_all, :nullify,
:restrict_with_error, :restrict_with_exception]` as options.
Currently the documentation references `delete` instead of `delete_all`
* Adds documentation for other options
|
|\ \ \
| | | |
| | | | |
Add fail fast reporting to test runner.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Passing `--fail-fast` to the test runner will now abort the test run
on the first failure. The run continues on any unexpected errors.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Any failures or errors will be reported inline during the run by default.
Skipped tests will be reported if run in verbose mode.
Any result is output with failure messages and a rerun snippet for that test.
Rerun snippets won't be output after a run, unless `--defer-output` is passed.
|
|\ \ \ \
| | | | |
| | | | | |
Fix - Prevent adding of `data-disable-with` option twice in html.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Earlier
when `data-disable-with` option is added direclty as in options then
```ruby
submit_tag("Save", { "data-disable-with" => "Processing..." })
# => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." data-disable-with="Processing..." />
```
Now
when `data-disable-with` option is added direclty as in options then
```ruby
submit_tag("Save", { "data-disable-with" => "Processing..." })
# => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." />
```
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove TestRouter#add_routes
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Now, we use the mapper to build the routing table
related to https://github.com/rails/rails/commit/703275ba70efbefb3358052b6ba750443eff1a28
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Fix names of test cases
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Update docs for `formatted_offset`
|
| | | | |
| | | | |
| | | | | |
Output of `formatted_offset` is depends on input so it’s not always in +HH:MM format. Possible outputs are “+5:30”, “+530” or provided alternate UTC string [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
the caller of `handle_conditional_get!` checks the committed state of
the response, so we don't need to in the subclass.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I'm looking to move towards a tree-like structure for dirty checking
that involves an attribute holding onto the attribute that it was
created from. This means that `changed?` can be fully encapsulated on
that object. Since the objects are immutable, in `changes_applied`, we
can simply perform a shallow dup, instead of a deep one.
I'm not sure if that will actually end up in a performance boost, but
I'd like to semantically separate these concepts regardless
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The external uses of this method have been removed, and I'd like to
internally re-use that name, as I'm planning to encapsulate `changed?`
into the attribute object itself.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | |
| | | | | |
Gaurav2728/no_more_class_methods_for_JoinDependency
no more class methods for JoinDependency [ci skip]
|
| | | | |
| | | | |
| | | | | |
`ActiveRecord::Associations::JoinDependency` now it’s own class` and `ActiveRecord::Associations::ThroughAssociationScope` doesn’t exists
|