aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add an ignored options parameter to ActiveSupport::JSON::Variable#to_json to ↵Michael Koziarski2007-10-251-1/+1
| | | | | | make sure it duck-types nicely with the other JSON types. [Pascal Belloncle] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make sure that the Schema Dumper supports non-standard primary keys with ↵Michael Koziarski2007-10-252-0/+17
| | | | | | MySQL. Closes #9971 [RubyRedRick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Refactor the default rendering out to a method called default_render to ↵Michael Koziarski2007-10-252-5/+31
| | | | | | provide a hook for plugin authors. Closes #9953 [cjheath] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Document Enumerable and Hash #to_json. Add test for hash with integer key. ↵Jeremy Kemper2007-10-244-0/+42
| | | | | | Closes #9970. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Remove unnecessary returns from builtin filters since render/return is now ↵Jeremy Kemper2007-10-244-9/+1
| | | | | | sufficient. Closes #9952 [Josh Peek] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* rake test aborts if tests failed. Closes #9962 [Jason Roelofs]Jeremy Kemper2007-10-231-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8008 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Disabled checkboxes don't submit a form value. Closes #9301.Jeremy Kemper2007-10-233-1/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Limited eager loading no longer ignores scoped :order. Closes #9561 [danger, ↵Marcel Molina2007-10-233-6/+15
| | | | | | josh] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added tests for options to ActiveRecordHelper#form. Closes #7213 ↵Marcel Molina2007-10-232-0/+11
| | | | | | [richcollins, mikong, mislav] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Assigning an instance of a foreign class to a composed_of aggregate calls an ↵Jeremy Kemper2007-10-233-39/+30
| | | | | | optional conversion block. Refactor and simplify composed_of implementation. Closes #6322. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Assigning nil to a composed_of aggregate also sets its immediate value to ↵Jeremy Kemper2007-10-233-2/+19
| | | | | | nil. Closes #9843. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Some mime type refactoring. Closes #9957 [Josh Peek]Jeremy Kemper2007-10-233-22/+11
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* validates_uniqueness_of behaves well with abstract superclasses. References ↵Jeremy Kemper2007-10-234-2/+68
| | | | | | #3833, closes #9886. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Remove duplicate rjs layout check. Closes #9956 [Josh Peek]Jeremy Kemper2007-10-231-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Refactor and test boot.rb. Include tests from and closes #9834.Jeremy Kemper2007-10-233-26/+232
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Hash#to_xml handles symbol values. Closes #9954.Jeremy Kemper2007-10-233-2/+12
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Reinstate test_change_column_nullability for all adapters. Closes #9945 ↵Jeremy Kemper2007-10-221-2/+1
| | | | | | [lawrence] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* test_select_rows shouldn't depend on implicit result ordering. Closes #9898 ↵Jeremy Kemper2007-10-221-2/+2
| | | | | | [lawrence] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Expand form helper test coverage. Closes #9950 [robinjfisher]Jeremy Kemper2007-10-221-1/+55
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* request.parameters doesn't overwrite request.request_parameters. Closes ↵Jeremy Kemper2007-10-223-3/+12
| | | | | | #9949 [nullstyle] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Changed before_filter halting to happen automatically on render or redirect ↵David Heinemeier Hansson2007-10-213-23/+36
| | | | | | but no longer on simply returning false [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Ensure that mysql quotes table names with database names correctly. Closes ↵Rick Olson2007-10-203-1/+9
| | | | | | #9911 [crayz] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Ensure that cookies handle array values correctly. Closes #9937 [queso]Rick Olson2007-10-203-2/+15
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* typo in test nameMichael Koziarski2007-10-191-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Remove more potential clashes with asset methods and resource routes. ↵Michael Koziarski2007-10-193-5/+37
| | | | | | Closes #9928 [gbuesing] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Few more tests for Sexy MigrationsMichael Koziarski2007-10-191-0/+24
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Forgotten changelog entryMichael Koziarski2007-10-191-0/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add t.belongs_to and t.references to sexy migrations [arthurgeek]Michael Koziarski2007-10-192-1/+66
| | | | | | | | Test harness for Sexy Migrations. [Koz] Closes #9775 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Move all Schema creation into schema.rb for Mysql. Closes #9899 [mikong, ↵Michael Koziarski2007-10-198-283/+231
| | | | | | lawrence] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Rename image_path path_to_image to avoid conflicting with named routes. ↵Michael Koziarski2007-10-193-2/+7
| | | | | | Closes #9924 [gbuesing] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* SQL Server: test for affected row count. References #9558 [lawrence, ryepup]Jeremy Kemper2007-10-181-25/+19
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use SecureRandom to generate unique ids, if available.Jeremy Kemper2007-10-181-12/+22
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Merge [7832] from 1-2-stable: Correct RAILS_GEM_VERSION regexp. Use =version ↵Jeremy Kemper2007-10-181-8/+11
| | | | | | gem requirement instead of ~>version so you don't get surprised by a beta gem in production. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed incorrect migration number if script/generate executed outside of ↵David Heinemeier Hansson2007-10-182-1/+3
| | | | | | Rails root (closes #7080) [jeremymcanally] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Docfix (cloases #9832)David Heinemeier Hansson2007-10-181-7/+8
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Read in binary mode to make sure windows support keeps working. [lawrence] ↵Michael Koziarski2007-10-171-1/+1
| | | | | | Closes #9912 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use a smaller binary fixture so we don't overflow column size limitations in ↵Michael Koziarski2007-10-172-435/+130
| | | | | | some commercial / legacy databases. Closes #7987 [roderickvd, lawrence] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Raise an intelligible error message when migration aren't named correctly ↵Michael Koziarski2007-10-171-1/+9
| | | | | | [bronson] Closes #9909 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7957 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* caches_page uses a single after_filter instead of one per action. Closes #9891.Jeremy Kemper2007-10-162-3/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Update Prototype to 1.6.0_rc1 and script.aculo.us to 1.8.0 preview 0.Sam Stephenson2007-10-1610-3286/+5296
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* More Performant Cookie Regexp for Integration tests. [Ola Bini]Michael Koziarski2007-10-161-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Hash#symbolize_keys behaves well with integer keys. Closes #9890.Jeremy Kemper2007-10-163-3/+11
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Dispatcher: fix that to_prepare should only run once in production. Closes ↵Jeremy Kemper2007-10-163-1/+12
| | | | | | #9889. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Qualified column names work in hash conditions, like :conditions => { ↵Jeremy Kemper2007-10-163-1/+20
| | | | | | 'comments.created_at' => ... }. Closes #9733. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix regression where the association would not construct new finder SQL on ↵Jeremy Kemper2007-10-163-4/+16
| | | | | | save causing bogus queries for "WHERE owner_id = NULL" even after owner was saved. Closes #8713. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* remove empty dirs missed by git-svnJeremy Kemper2007-10-160-0/+0
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Refactor association create and build so before & after callbacks behave ↵Jeremy Kemper2007-10-168-45/+94
| | | | | | consistently. Closes #8854. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Improve the error message for assert_redirected_to. Closes #7337 [mikong, ↵Jeremy Kemper2007-10-162-5/+4
| | | | | | sandofsky] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Test link_to 'back', :backJeremy Kemper2007-10-161-0/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Quote table names. Defaults to column quoting. Closes #4593.Jeremy Kemper2007-10-1615-46/+283
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7932 5ecf4fe2-1ee6-0310-87b1-e25e094e27de