| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / /
| | |
| | |
| | | |
Keep in sync with 3-2-stable.
|
| |/
|/|
| |
| |
| | |
This reverts commit 408227d9c5ed7de26310d72a1a99c1ee02311c63, reversing
changes made to dca0b57d03deffc933763482e615c3cf0b9a1d97.
|
| | |
|
| |
| |
| |
| | |
Closes #9386
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix calculation of db_runtime property in
ActiveRecord::Railties::ControllerRuntime#cleanup_view_runtime.
Previously, after raising ActionView::MissingTemplate, db_runtime was
not populated.
Closes #9218, Fixes #9215.
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| | |
| | |
| | | |
exception
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Remove duplicated number_helper tests in AP. They are already in AS.
With 155cd5e the number_helpers were moved into AS all the tests were copied over but the tests in AP were not deleted. This is confusing.
This removes all duplicated tests and reorganized the tests in AP to only test the functionality, that is added in AP.
Also cleanup some of the number helper tests.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* use 1.9 style hash syntax
* don't use brances on assert_equal
* prefere " over '
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
With 155cd5e6 the number_helpers were moved into AS all the tests were copied over
but the tests in AP were not deleted. This is confusing.
I removed all duplicated tests and reorganized the tests in AP to only test the
functionality, that is added in AP.
|
|\ \ \ \
| |/ / /
|/| | | |
Removed template_root as a configuration option
|
| | | |
| | | |
| | | | |
Removed template root from actionmailer configuration options as it seems to have been pulled out completely in favor of explicit definition via template_path / template_name.
|
|\ \ \ \
| | | | |
| | | | | |
remove private attribute? warning
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
convert non-string default params to strings in the router.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #9435.
Skip valid encoding checks for non-String parameters that come
from the matched route's defaults.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
the router allows String contraints.
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Closes #9432.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix default output for postgres network address types
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | | |
I merged b883706 but forgot to move the entry past beta1.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix deletion of empty directories
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
1. When comparing the directory to delete against the top level
cache_path, use File.realpath to make sure we aren't comparing two
unequal strings that point to the same path. This occurs, for
example, when cache_path has a trailing slash, which it does in the
default Rails configuration. Since the input to
delete_empty_directories never has a trailing slash, the comparison
will never be true and the top level cache directory (and above) may
be deleted. However…
2. File.delete raises EPERM when trying to delete a directory, so no
directories have ever been deleted. Changing the code to Dir.delete
fixes that.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add routing guide doc on root with namespaces. [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
I read #9419 and realized I didn't know you could have namespaced
roots, checked around, and a few friends didn't either. Figured
this makes it guide worthy.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix touching an invalid parent record for belongs_to
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If the parent of a `belongs_to` record fails to be saved due to
validation errors, `touch` will be called on a new record, which causes
an exception (see https://github.com/rails/rails/pull/9320).
Example:
class Owner < ActiveRecord::Base
validates_presence_of :name
end
class Pet < ActiveRecord::Base
belongs_to :owner, touch: true
end
pet = Pet.new(owner: Owner.new)
# Before, this line would raise ActiveRecord::ActiveRecordError
# "can not touch on a new record object"
pet.save
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[ci skip]
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Journey::Path::Pattern#new raise more meaningful exception message.
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | | |
exception message.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use less hyperbole in the language re: allowed parameters
|
| | |/ / / /
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add tests for #9441
|
| |/ / / / / |
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Support Core Extensions guide
|
| | | | | |
| | | | | |
| | | | | | |
Cannot find the screencast on the internet, guess it was removed
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
versions for 3.1 and 3.2 are now 3.2.12 and 3.1.11 respectively.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The code in 2.3.2 assumed that render has an alert option like
redirect_to to create a flash alert message, but it doesn't.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix missing `ORDER BY id ASC` for Client.first(2);
Uppercase the little y in the SQL equivalent of the Client.last(2).
|
| | | | | |
| | | | | |
| | | | | | |
Found the wording on line 158 somewhat confusing. Added short example to clarify.
|