| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Tell people to install `activerecord-session_store` gem when it's not
installed instead ofraising `NameError` on missing
`ActionDispatch::Session::ActiveRecordStore`.
|
| |
|
| |
|
|
|
|
|
| |
This functionality will be available from gem
`active_record-session_store` instead.
|
|\
| |
| | |
Fix tests that depend on run order
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
The new regexp has less work to do, we anchor a fixed string at the end
and need no group.
|
| | |
|
|/ |
|
|\
| |
| | |
Model.select takes a variable list of arguments
|
|/
|
|
|
|
| |
This is a cleaner version of #6916.
Closes #3165.
|
|\
| |
| | |
Update the documentation for the :autosave option on belongs_to
|
|/
|
|
|
|
|
|
|
|
|
| |
I've noticed a caveat with the :autosave option biting people before.
Questions arise about why they must explicitly save an associated object
in their own before_save callbacks. I've updated the documentation as
such to note to users that the :autosave callback occurs before any
user defined callbacks. They must save the associated record themselves
if altering it in their own callbacks.
Signed-off-by: David Celis <david@davidcelis.com>
|
|
|
|
|
|
| |
This reverts commit b0ab8dc0b2b0f580ffe5ac9ff57fd13152e18577
because it was removing the contents of the message when we
did not have any tag. A test case is also committed.
|
|
|
|
|
|
|
| |
The reason the test was failing was because when the test
invokes `app.config`, the app is loaded and, as `eager_load`
is set to true, it disables the dependency loading mechanism,
so controllers that are later defined are not loaded.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
The revised test assumed that the default permissions of a file
matched the umask of the process, but in the general case that
depends also on the file system. This test was failing in the
/vagrant shared folder of Rails development boxes.
|
| |
|
| |
|
|\
| |
| | |
Extended documentation for `time_ago_in_words` helper
|
| | |
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 8cb9460437eddde6952fbebbc969203cd4d00294.
Reason: #7377 was merged and it fixes this behavior.
|
| | |
| | |
| | |
| | | |
Fixed bug in the example code. A bit related to rails issue in
https://github.com/rails/rails/issues/3223
|
| | |
| | |
| | |
| | |
| | | |
Make doc output in grouped_options_for_select divider example match
actual output. The options groups were in backwards order of actual.
|
|\ \ \
| | | |
| | | | |
Remind user a good way to generate a secret code [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
AR::Relation#model would be a better API than AR::Relation#klass
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove j alias for ERB::Util.json_escape
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
These tests rely on "make_basic_app", which is a faster version that
does not need to create the whole app directory structure.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Avoid output with config option not set when running some tests.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improve eager load on Rails
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The new option allows any Ruby namespace to be registered and set
up for eager load. We are effectively exposing the structure existing
in Rails since v3.0 for all developers in order to make their applications
thread-safe and CoW friendly.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Previously, ActiveSupport::Autoload was global and reserved
for usage inside Rails. This pull request makes it local,
fixes its test (they were not being run because its file
was named wrongly) and make it part of Rails public API.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The flag was mainly used to add a Rack::Lock middleware to
the stack, but the only scenario the lock is desired is in
development.
If you are deploying on a not-threaded server, the Rack::Lock
does not provide any benefit since you don't have concurrent
accesses. On the other hand, if you are on a threaded server,
you don't want the lock, since it defeats the purpose of using
a threaded server.
If there is someone out there, running on a thread server
and does want a lock, it can be added to your environment
as easy as: `use Rack::Lock`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Previously, the eager load behavior was mostly coupled to
config.cache_classes, however this was suboptimal since in
some environments a developer may want to cache classes but
not necessarily load them all on boot (for example, test env).
This pull request also promotes the use of config.eager_load
set to true by default in production. In the majority of the
cases, this is the behavior you want since it will copy most
of your app into memory on boot (which was also the previous
behavior).
Finally, this fix a long standing Rails bug where it was
impossible to access a model in a rake task when Rails was
set as thread safe.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Clarify and correct the description for the --full option of the
plugin_new generator. [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
generator
|
| |/ / / / /
|/| | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Fix for #5200
|