| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Adds stuff
Fixes a typo
Integrates changes
Adds link to append_view_path in actionmailer guide.
|
|\
| |
| | |
Add lambdas in conditional validations
|
|/
|
|
|
|
|
|
| |
As `Lambdas` are a type of `Proc`, they can also be used in the
`if`/`unless` option of a validation to decide when the validation is
executed. Add this case to the guide for clarification.
Closes https://github.com/rails/rails/issues/33212
|
|\
| |
| | |
Fix filtering out ActionView::Template method names from backtrace.
|
|/
|
|
| |
ActionView::Template method names
|
|
|
|
|
|
|
| |
Avoid mangling service names that end in S:
"GCS".classify # => "GC"
"GCS".camelize # => "GCS"
|
|\
| |
| | |
Improve ActiveStorage service adapter error handling
|
|/ |
|
|\
| |
| | |
Filter backtrace in test to ensure irb counts as user code
|
|/ |
|
|\
| |
| | |
Move changelog entry of 47018a82 up [ci skip]
|
|/
|
|
|
|
|
| |
We always add new entries on the top of changelog file.
This commit moves the entry added in 47018a82 up in order to
preserve the chronology.
Follows up 3e2629eb7fae33cd521bf1c265d1bbe8ed04c59e
|
|
|
|
|
|
|
|
|
|
|
|
| |
* test case for fetch cache miss with skip_nil
* abondon nil cache if skip_nil specified
* ensure not cache key for skip nil
* add document with skip_nil for Store#fetch
* add a new change log entry for #25437
|
|\
| |
| | |
Call build when extend with nested attributes defined
|
| |
| |
| |
| |
| |
| |
| |
| | |
What?
From now on when `accepts_nested_attributes_for` defined and `extend` option
added the overwritten `build` method being called.
[Alireza Bashiri, Martins Polakovs]
|
|\ \
| | |
| | |
| | |
| | | |
albertoalmagro/change-references-from-rake-to-rails-command
Change references from Rake task to Rails command
|
| | |
| | |
| | |
| | |
| | | |
This commit follows the path we started at commit #ea4f0e2
and continued at PR #33229.
|
| | |
| | |
| | |
| | | |
Closes #32530.
|
|\ \ \
| | | |
| | | | |
Fix file upload location recommendation
|
| |/ /
| | |
| | | |
Going one level downwards from Rails' /public directory would still be inside the public directory and therefore servable by the web server. Files should stored upwards of the public directory.
|
|\ \ \
| | | |
| | | | |
[Documentation] Mention default HTTP headers in Rails 3.2 to 4.0 upgrade guide
|
| | | |
| | | |
| | | |
| | | | |
handling the addition of configurable default HTTP headers. [ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
[Documentation] Fix "adding member routes" guide inconsistency
|
|/ / / /
| | | |
| | | |
| | | | |
implementation. Closes #33518
|
| | | | |
|
| |_|/
|/| | |
|
|\ \ \
| |_|/
|/| | |
remove redundant establish_connection call in test_databases.rb
|
|/ /
| |
| |
| | |
load_schema
|
| | |
|
|\ \
| | |
| | | |
Make parallel testing db faster
|
|/ / |
|
| | |
|
|\ \
| | |
| | | |
Revert the breaking existing default sort order contract
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit d162188dd662a7d9f62ba8431474f50bc35e3e93, reversing
changes made to 3576782888c307e3e192c44e332b957cd1174128.
Reason: #24131 conflicts the #5153's default order contract, it means
that existing apps would be broken by that change.
We don't want to break existing apps without a deprecation cycle.
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Default content type for `head` is `text/html`
|
| | |
| | |
| | |
| | | |
Otherwise Mime::NullType will be returned as the `Content-Type` header.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
rails/revert-31883-remove-label-in-porgress-for-M-V-guides
Revert "Remove label 'work in progress' for AM and AV guides"
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
bogdanvlviv/remove-label-in-porgress-for-M-V-guides
Remove label 'work in progress' for AM and AV guides
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I've reviewed "Active Model Basics" and "Action View Overview" guides
and looks like they have good enough information and don't have errors.
This commit removes label 'work in progress' for these guides.
|
|\ \ \ \
| | | | |
| | | | | |
Throw if ujs loaded twice
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I saw two posts of problem about ajax requesting twice on qiita.
So I think detecting double loaded earlier make easy to find the problem.
https://qiita.com/hot_study_man/items/56dc87ad734cfda68bb6
https://qiita.com/hisas/items/8399aec3a5377bf75017
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Log the remote IP addr of clients behind a proxy
|
|/ / / /
| | | |
| | | |
| | | | |
[Atul Bhosale, Victor Nawothnig]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Raises exception when respond_to called multiple times in incompatible way
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Nesting respond_to calls can lead to unexpected behavior, so it should be
avoided. Currently, the first respond_to format match sets the content-type
for the resulting response. But, if a nested respond_to occurs, it is possible
to match on a different format. For example:
respond_to do |outer_type|
outer_type.js do
respond_to do |inner_type|
inner_type.html { render body: "HTML" }
end
end
end
Browsers will often include */* in their Accept headers. In the above example,
such a request would result in the outer_type.js match setting the content-
type of the response to text/javascript, while the inner_type.html match will
cause the actual response to return "HTML".
This change tries to minimize potential breakage by only raising an exception
if the nested respond_to calls are in conflict with each other. So, something
like the following example would not raise an exception:
respond_to do |outer_type|
outer_type.js do
respond_to do |inner_type|
inner_type.js { render body: "JS" }
end
end
end
While the above is nested, it doesn't affect the content-type of the response.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Fix example in thread_mattr_accessor documentation
[ci skip]
|
|/ / / / |
|