aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | | Merge pull request #30125 from yukideluxe/add-reload-to-associations-docsRafael França2017-08-082-4/+14
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | add reload_association to documentation
| * | | | | | | | | | | add reload_association to documentation [ci skip]Julia López2017-08-072-4/+14
| | |/ / / / / / / / / | |/| | | | | | | | |
* | | | | | | | | | | Merge pull request #30127 from y-yagi/deprecate_support_of_older_config_ruRafael França2017-08-083-1/+43
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Deprecate support of older `config.ru`
| * | | | | | | | | | | Deprecate support of older `config.ru`yuuji.yaginuma2017-08-083-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Rails 4.0, `config.ru` generated by default uses instances of `Rails.application`. Therefore, I think that it is good to deprecate the old behavior. Related: #9669
* | | | | | | | | | | | Merge pull request #30135 from ffmike/azure-storage-fix-content-typeRafael Mendonça França2017-08-082-3/+11
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | Support content_type in AzureStorageService#url
| * | | | | | | | | | | Support content_type in AzureStorageService#urlMike Gunderloy2017-08-082-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)"
* | | | | | | | | | | | ActiveStorage:Add migrations per rails engine conventions (#30111)Dino Maric2017-08-084-14/+6
|/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add migrations per rails engine conventions * Fix failing tests
* | | | | | | | | | | [ci skip] Postgres --> PostgreSQLRyuta Kamizono2017-08-084-4/+4
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #30132 from ydakuka/patch-1Ryuta Kamizono2017-08-081-1/+1
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / |/| | | | | | | | | | [ci skip] Update action_mailer_basics.md
| * | | | | | | | | | [ci skip] Update action_mailer_basics.mdYauheni Dakuka2017-08-081-1/+1
|/ / / / / / / / / /
* | / / / / / / / / [ci skip] Prefer cookies.encrypted over signed (#30129)Claudio B2017-08-074-4/+4
| |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some examples and guides we are recommending to use code like: ```ruby verified_user = User.find_by(id: cookies.signed[:user_id]) ``` My suggestion is to use instead: ```ruby verified_user = User.find_by(id: cookies.encrypted[:user_id]) ``` which invites users to prefer the "newer" encrypted cookies over the "legacy" signed cookies.
* | | | | | | | | Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-075-6/+66
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* | | | | | | | Capitalize RakeJon Moss2017-08-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Should _probably_ be done across the board with all of our documentation, but going to leave that for another time :) [ci skip]
* | | | | | | | Remove extra space between two sentencesJon Moss2017-08-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | Lint railties/CHANGELOG.mdJon Moss2017-08-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Light grammar edits. [ci skip]
* | | | | | | | Lint activesupport/CHANGELOG.mdJon Moss2017-08-061-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Light grammar edits. [ci skip]
* | | | | | | | Lint activerecord/CHANGELOG.mdJon Moss2017-08-061-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Light grammar fixes, and added a few backticks. [ci skip]
* | | | | | | | Lint actionpack/CHANGELOG.mdJon Moss2017-08-061-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes a few grammar things. [ci skip]
* | | | | | | | Lint actioncable/CHANGELOG.mdJon Moss2017-08-061-3/+3
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Postgres --> PostgreSQL ActionCable --> Action Cable [ci skip]
* | | | | | | Merge pull request #30094 from dixpac/change_azure_name_in_storage_ymlDavid Heinemeier Hansson2017-08-061-3/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix wrong service name in the storage.yml
| * | | | | | | Fix wrong service name in the storage.ymldixpac2017-08-061-3/+3
| | |_|_|/ / / | |/| | | | |
* | | | | | | Merge pull request #30099 from ↵David Heinemeier Hansson2017-08-061-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bogdanvlviv/set_version_of_active_storage_to_5_2_0_alpha_inside_package_json Active Storage to 5.2.0.alpha inside `activestorage/package.json`
| * | | | | | | Active Storage to 5.2.0.alpha inside `activestorage/package.json`bogdanvlviv2017-08-061-1/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | Follow #30083
* | | | | | | Merge pull request #30097 from mgiagante/masterRyuta Kamizono2017-08-071-1/+1
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Replaces the 17 for the actual call to params[:id] that would make th…
| * | | | | | Replaces the 17 for the actual call to params[:id] that would make the code ↵Mariano Giagante2017-08-061-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | work as intended. [ci skip]
* | | | | | Pass over Active Storage readme [ci skip] (#30086)Vipul A M2017-08-061-2/+2
| | | | | |
* | | | | | Merge pull request #30089 from yboulkaid/masterRyuta Kamizono2017-08-061-4/+0
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Remove outdated comment [ci skip]
| * | | | | Remove outdated comment [ci skip]Youssef Boulkaid2017-08-061-4/+0
|/ / / / / | | | | | | | | | | | | | | | | | | | | The comment was describing a previous version of the method with a different signature. This is outdated since e76c38e
* | | | | Merge pull request #30066 from claudiob/ast-moduleDavid Heinemeier Hansson2017-08-0512-665/+690
|\ \ \ \ \ | | | | | | | | | | | | `module ActiveStorage`, not `ActiveStorage::Class`
| * \ \ \ \ Merge branch 'master' into ast-moduleDavid Heinemeier Hansson2017-08-0515-28/+33
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Merge pull request #30068 from kamipo/user_start_with_than_regexpDavid Heinemeier Hansson2017-08-051-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use `content_type.start_with?("...")` than `content_type =~ /^.../`
| * | | | | | Use `content_type.start_with?("...")` than `content_type =~ /^.../`Ryuta Kamizono2017-08-051-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `start_with?` is a little faster than regexp for prefix matching by a fixed string.
* | | | | | | Merge pull request #30081 from y-yagi/fix_ruby_warningsDavid Heinemeier Hansson2017-08-056-11/+17
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix ruby warnings
| * | | | | | | Fix ruby warningsyuuji.yaginuma2017-08-056-11/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes following warnings: ``` test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized ```
* | | | | | | | Merge pull request #30080 from georgeclaghorn/active-storage-secret-key-baseDavid Heinemeier Hansson2017-08-052-4/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`
| * | | | | | | | Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`George Claghorn2017-08-052-4/+2
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | By default, apps only have the former set.
* | | | | | | | Merge pull request #30082 from kamipo/add_missing_blank_lineDavid Heinemeier Hansson2017-08-051-0/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add missing blank line between `config.active_storage` and `config.action_cable`
| * | | | | | | | Add missing blank line between `config.active_storage` and `config.action_cable`Ryuta Kamizono2017-08-051-0/+1
| |/ / / / / / /
* | | | | | | | Merge pull request #30083 from ↵David Heinemeier Hansson2017-08-051-2/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | koic/change_gem_version_of_active_storage_to_5_2_0 Change gem version of Active Storage to 5.2.0.alpha
| * | | | | | | | Change gem version of Active Storage to 5.2.0.alphaKoichi ITO2017-08-051-2/+2
| |/ / / / / / /
* | | | | | | | Merge pull request #30056 from dixpac/remove_unecessary_variableDavid Heinemeier Hansson2017-08-051-1/+1
|\ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ |/| | | | | | | Remove unnecessary variable
| * | | | | | | Remove unecesarry exception variabledixpac2017-08-051-1/+1
|/ / / / / / /
* / / / / / / Revert "Merge pull request #15446 from akshay-vishnoi/doc_changes"Matthew Draper2017-08-051-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | It was right as originally written in #15440.
* | | | | | Merge pull request #30078 from y-yagi/fix_respositoryRyuta Kamizono2017-08-052-4/+4
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Fix repository URL [ci skip]
| * | | | | Fix repository URL [ci skip]yuuji.yaginuma2017-08-052-4/+4
|/ / / / / | | | | | | | | | | | | | | | changed `rails/activestorage` to `rails/rails`.
| * / / / `module ActiveStorage`, not `ActiveStorage::Class`claudiob2017-08-0412-660/+685
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The reasons for this commit are: - uniformity with the other Rails libraries - (possibly) behave better with respect to autoloading - fix the index in the generated documentation Before this commit, run `rake rdoc` generates this left sidebar (ActiveStorage entries are indexed twice, both inside and outside the module): <img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png"> After this commit, run `rake rdoc` generates this left sidebar: (ActiveStorage entries are only indexed inside the module): <img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png">
* | | | Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-04144-26/+7217
|\ \ \ \ | | | | | | | | | | Add Active Storage to Rails
| * | | | Rename Azure to AzureStorage (#30057)Dino Maric2017-08-046-8/+8
| | | | |
| * | | | Fix tests for AWS buckets that include a . (#30059)Claudio B2017-08-042-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical URL for an object will start with "https://s3.amazonaws.com/bucket.name/" and not with "https://bucket.name.s3.amazonaws.com/". The URL tests have now been separated into two separate asserts, to ensure that both the "s3.amazonaws.com" and the "bucket.name" components are included, but not specifically in that order.
| * | | | Add Active Storage to README and release (#30065)Claudio B2017-08-042-1/+3
| | | | | | | | | | | | | | | Before we forget...
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-21 22:51:32 +0000